Skip to contentSkip to conversation

postgresql: disable spinlock support for riscv64

PATCH New Fabrice Fontaine 3 participants 4 messages Oct 20, 2018 – Oct 21, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 postgresql: disable spinlock support for riscv64

Fixes:
- http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/postgresql/postgresql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/postgresql/postgresql.mk +1 -1
index 540e1540ca..8b3fd6f439 100644
@@ -29,7 +29,7 @@ ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 POSTGRESQL_CONF_OPTS += --disable-thread-safety
 endif
 
-ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y)
+ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y)
 POSTGRESQL_CONF_OPTS += --disable-spinlocks
 endif
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 postgresql: disable spinlock support for riscv64

Hello,

+Mark Corbin in Cc.

package/postgresql/postgresql.mk ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y) · line 32

Quoted 7 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68

Signed-off-by Fabrice Fontaine <[email protected]>
package/postgresql/postgresql.mk +1 -1
-ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y)
+ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y)

Any reason for doing that only for riscv64 and not for RISC-V entirely ? Does PostgreSQL has a spinlock implementation for RISC-V 32 but not RISC-V 64 ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 postgresql: disable spinlock support for riscv64

Hello Thomas

Quoted 8 lines · Thomas Petazzoni

Hello,

+Mark Corbin in Cc.

Quoted 3 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68

Quoted 6 lines

package/postgresql/postgresql.mk ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y) · line 32

Quoted 3 lines
Signed-off-by Fabrice Fontaine <[email protected]>
package/postgresql/postgresql.mk +1 -1
-ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y)
+ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y)

Any reason for doing that only for riscv64 and not for RISC-V entirely ? Does PostgreSQL has a spinlock implementation for RISC-V 32 but not RISC-V 64 ?

PostgreSQL does not have any support for RISC-V architecture, so I it? makes sense to use BR2_riscv here instead of BR2_RISCV_64.

Regards

Mark

Quoted 4 lines

Thanks,

Thomas

Signature · 22 lines
*Mark Corbin*
Embedded Operating Systems Lead
Phone: +44 1590 610184?????Mobile: +44 7765 703479
Email: mark.corbin at embecosm.com
<mailto:[email protected]>?????Web: https://www.embecosm.com

Embecosm Logo

Embecosm Ltd., Palamos House #208, 66/67 High Street, Lymington, SO41
9AL, UK
Company No. 6577021 (England & Wales).
--
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181021/4451036c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.png
Type: image/png
Size: 8442 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181021/4451036c/attachment.png>
#3 lore raw

PATCH 1/1 postgresql: disable spinlock support for riscv64

In reply to Fabrice Fontaine

Hello,

Quoted 7 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/postgresql/postgresql.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I've changed the condition to use BR2_riscv instead of BR2_RISCV_64, and then applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com