Skip to contentSkip to conversation

arm: qemu: rework Kconfig

PATCH New AKASHI Takahiro 2 participants 4 messages Oct 19, 2018 – Oct 22, 2018

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

AKASHI Takahiro

author
#0 lore raw

PATCH 1/1 arm: qemu: rework Kconfig

Define a missing CONFIG_SYS_SOC and move some CONFIG_SYS_* to a more canonical place (i.e. under board).

Signed-off-by AKASHI Takahiro <[email protected]>
---
 arch/arm/Kconfig                 |  1 +
 arch/arm/mach-qemu/Kconfig       | 18 ++++++++++--------
 board/emulation/qemu-arm/Kconfig |  9 +++++++++
 3 files changed, 20 insertions(+), 8 deletions(-)
 create mode 100644 board/emulation/qemu-arm/Kconfig
arch/arm/Kconfig +1 -0
index b39d08539aee..6dadf5a56f0c 100644
@@ -1474,6 +1474,7 @@ source "board/broadcom/bcmns2/Kconfig"
 source "board/cavium/thunderx/Kconfig"
 source "board/cirrus/edb93xx/Kconfig"
 source "board/eets/pdu001/Kconfig"
+source "board/emulation/qemu-arm/Kconfig"
 source "board/freescale/ls2080a/Kconfig"
 source "board/freescale/ls2080aqds/Kconfig"
 source "board/freescale/ls2080ardb/Kconfig"
arch/arm/mach-qemu/Kconfig +10 -8
index a2e4b98b8887..d75a95183a75 100644
@@ -3,22 +3,24 @@ if ARCH_QEMU
 config SYS_VENDOR
 	default "emulation"
 
-config SYS_BOARD
-	default "qemu-arm"
+config SYS_SOC
+	default "qemu"
 
-config SYS_CONFIG_NAME
-	default "qemu-arm"
-
-endif
+choice
+	prompt "QEMU cpu type"
 
 config TARGET_QEMU_ARM_32BIT
-	bool "Support qemu_arm"
+	bool "Arm"
 	depends on ARCH_QEMU
 	select ARCH_SUPPORT_PSCI
 	select CPU_V7A
 	select SYS_ARCH_TIMER
 
 config TARGET_QEMU_ARM_64BIT
-	bool "Support qemu_arm64"
+	bool "AArch64"
 	depends on ARCH_QEMU
 	select ARM64
+
+endchoice
+
+endif
board/emulation/qemu-arm/Kconfig new file +9 -0
new file mode 100644
index 000000000000..db8b2a4dfae2
@@ -0,0 +1,9 @@
+if TARGET_QEMU_ARM_32BIT || TARGET_QEMU_ARM_64BIT
+
+config SYS_BOARD
+	default "qemu-arm"
+
+config SYS_CONFIG_NAME
+	default "qemu-arm"
+
+endif
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 arm: qemu: rework Kconfig

Hi,

Quoted 4 lines · AKASHI Takahiro

Define a missing CONFIG_SYS_SOC and move some CONFIG_SYS_* to a more canonical place (i.e. under board).

Quoted 8 lines
Signed-off-by AKASHI Takahiro <[email protected]>
---
 arch/arm/Kconfig                 |  1 +
 arch/arm/mach-qemu/Kconfig       | 18 ++++++++++--------
 board/emulation/qemu-arm/Kconfig |  9 +++++++++
 3 files changed, 20 insertions(+), 8 deletions(-)
 create mode 100644 board/emulation/qemu-arm/Kconfig

Please rebase your changes on top of http://patchwork.ozlabs.org/patch/984021/

Regards,
Bin

author
#2 lore raw

PATCH 1/1 arm: qemu: rework Kconfig

Quoted 17 lines · Bin Meng

Hi,

Quoted 4 lines · AKASHI Takahiro

Define a missing CONFIG_SYS_SOC and move some CONFIG_SYS_* to a more canonical place (i.e. under board).

Quoted 8 lines
Signed-off-by AKASHI Takahiro <[email protected]>
---
 arch/arm/Kconfig                 |  1 +
 arch/arm/mach-qemu/Kconfig       | 18 ++++++++++--------
 board/emulation/qemu-arm/Kconfig |  9 +++++++++
 3 files changed, 20 insertions(+), 8 deletions(-)
 create mode 100644 board/emulation/qemu-arm/Kconfig
Quoted 1 line

Please rebase your changes on top of http://patchwork.ozlabs.org/patch/984021/

OK, but has this patch already acked?
Anyway, I will include this patch in my patch set of "efi_loader: improve boot sequence in distro_bootcmd."

Thanks,
-Takahiro Akashi

Quoted 2 lines

Regards,
Bin

#3 lore raw

PATCH 1/1 arm: qemu: rework Kconfig

Hi Takahiro,

Quoted 19 lines · AKASHI Takahiro
Quoted 17 lines · Bin Meng

Hi,

Quoted 12 lines · AKASHI Takahiro

Define a missing CONFIG_SYS_SOC and move some CONFIG_SYS_* to a more canonical place (i.e. under board).

Signed-off-by AKASHI Takahiro <[email protected]>
---
 arch/arm/Kconfig                 |  1 +
 arch/arm/mach-qemu/Kconfig       | 18 ++++++++++--------
 board/emulation/qemu-arm/Kconfig |  9 +++++++++
 3 files changed, 20 insertions(+), 8 deletions(-)
 create mode 100644 board/emulation/qemu-arm/Kconfig
Quoted 3 lines
Quoted 1 line

Please rebase your changes on top of http://patchwork.ozlabs.org/patch/984021/

OK, but has this patch already acked?

Yes, it's in Simon's DM tree (guess it targets to next release)

Quoted 3 lines

Anyway, I will include this patch in my patch set of "efi_loader: improve boot sequence in distro_bootcmd."

Regards,
Bin