drm/i915: Ensure proper HDA suspend/resume ordering with a device link
Subsystems (2)
PATCH 1/1 drm/i915: Ensure proper HDA suspend/resume ordering with a device link
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the HDA->i915 suspend (and shutdown) and i915->HDA resume order.
Atm, the lack of this ordering is not a problem, since all the i915 suspend/resume steps that need to be ordered wrt. the HDA driver's suspend/resume steps are separated out to the i915 suspend_late/resume_early hooks. That will change in a follow-up patchset where we'll need this ordering guarantee for steps that are in the i915 suspend/resume hooks (and which can't be moved to suspend_late/resume_early for other reasons). So this patch is a preparation for that follow-up patchset.
The change also allows us to move towards removing the i915 suspend_late/resume_early hooks alltogether.
Since we only need to ensure the ordering during suspend/resume and not during driver probing create the link with DL_FLAG_STATELESS. Since the probe time ordering has to be optional we use the component framework for that.
--- drivers/gpu/drm/i915/intel_audio.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/intel_audio.c +4 -0
@@ -921,6 +921,8 @@ static int i915_audio_component_bind(struct device *i915_kdev, dev_priv->audio_component = acomp;drm_modeset_unlock_all (&dev_priv->drm); +WARN_ON (!device_link_add (hda_kdev, i915_kdev,DL_FLAG_STATELESS )); +return 0 ; }
@@ -930,6 +932,8 @@ static void i915_audio_component_unbind(struct device *i915_kdev,struct i915_audio_component *acomp = data;struct drm_i915_private *dev_priv =kdev_to_i915 (i915_kdev); +device_link_remove (hda_kdev, i915_kdev); +drm_modeset_lock_all (&dev_priv->drm); acomp->base.ops =NULL ; acomp->base.dev =NULL ;
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Ensure proper HDA suspend/resume ordering with a device link
== Series Details ==
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link
URL : https://patchwork.freedesktop.org/series/51189/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5008 -> Patchwork_10504 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51189/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10504 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: PASS -> DMESG-WARN (fdo#105998)
==== Possible fixes ====
igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS +1 fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (44 -> 39) ==
Missing (5): fi-ilk-m540 fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-pnv-d510
== Build changes ==
* Linux: CI_DRM_5008 -> Patchwork_10504
CI_DRM_5008: b144c1d1f643907661fdd379245efe2402bb6b15 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4683: 7766b1e2348b32cc8ed58a972c6fd53b20279549 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10504: 710ef2bc107ea545cddfba7a9b531d1d91ed55b0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
710ef2bc107e drm/i915: Ensure proper HDA suspend/resume ordering with a device link
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10504/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Imre Deak
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the
HDA->i915suspend (and shutdown) andi915->HDAresume order.Atm, the lack of this ordering is not a problem, since all the i915 suspend/resume steps that need to be ordered wrt. the HDA driver's suspend/resume steps are separated out to the i915 suspend_late/resume_early hooks. That will change in a follow-up patchset where we'll need this ordering guarantee for steps that are in the i915 suspend/resume hooks (and which can't be moved to suspend_late/resume_early for other reasons). So this patch is a preparation for that follow-up patchset.
The change also allows us to move towards removing the i915 suspend_late/resume_early hooks alltogether.
Quoted 8 lines
Since we only need to ensure the ordering during suspend/resume and not during driver probing create the link with
DL_FLAG_STATELESS. Since the probe time ordering has to be optional we use the component framework for that.Cc Ville Syrjälä <[email protected]>Cc Takashi Iwai <[email protected]>Signed-off-by Imre Deak <[email protected]>
This looks like a good idea!
thanks,
Takashi
Quoted 29 lines
--- drivers/gpu/drm/i915/intel_audio.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/i915/intel_audio.c +4
-0@@ -921,6 +921,8 @@ static int i915_audio_component_bind(struct device *i915_kdev, dev_priv->audio_component = acomp;drm_modeset_unlock_all (&dev_priv->drm); +WARN_ON (!device_link_add (hda_kdev, i915_kdev,DL_FLAG_STATELESS )); +return 0 ; }@@ -930,6 +932,8 @@ static void i915_audio_component_unbind(struct device *i915_kdev,struct i915_audio_component *acomp = data;struct drm_i915_private *dev_priv =kdev_to_i915 (i915_kdev); +device_link_remove (hda_kdev, i915_kdev); +drm_modeset_lock_all (&dev_priv->drm); acomp->base.ops =NULL ; acomp->base.dev =NULL ;Signature · 1 line
2.13.2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915: Ensure proper HDA suspend/resume ordering with a device link
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link
URL : https://patchwork.freedesktop.org/series/51189/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5008_full -> Patchwork_10504_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10504_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10504_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10504_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: PASS -> DMESG-WARN== Known issues ==
Here are the changes found in Patchwork_10504_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_await@wide-contexts:
shard-apl: PASS -> FAIL (fdo#106680)
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
igt@kms_color@pipe-a-legacy-gamma:
shard-apl: PASS -> FAIL (fdo#104782, fdo#108145)
igt@kms_color@pipe-c-ctm-max:
shard-skl: PASS -> FAIL (fdo#108147)
igt@kms_flip@dpms-vs-vblank-race:
shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +12
igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
shard-apl: NOTRUN -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
shard-skl: NOTRUN -> FAIL (fdo#107815, fdo#108145)
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166)
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166)
igt@kms_setmode@basic:
shard-apl: PASS -> DMESG-WARN (fdo#103558)
igt@syncobj_wait@wait-all-for-submit-complex:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@drv_suspend@fence-restore-untiled:
shard-skl: INCOMPLETE (fdo#104108, fdo#107773) -> PASS
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@drv_suspend@shrink:
shard-kbl: FAIL (fdo#103375, fdo#106886) -> PASS
igt@gem_exec_await@wide-contexts:
shard-glk: FAIL (fdo#106680) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS
igt@kms_flip@flip-vs-modeset-interruptible:
shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +3
igt@perf_pmu@idle-no-semaphores-rcs0:
shard-apl: INCOMPLETE (fdo#103927) -> PASS fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5008 -> Patchwork_10504
CI_DRM_5008: b144c1d1f643907661fdd379245efe2402bb6b15 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4683: 7766b1e2348b32cc8ed58a972c6fd53b20279549 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10504: 710ef2bc107ea545cddfba7a9b531d1d91ed55b0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10504/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Imre Deak
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the
HDA->i915suspend (and shutdown) andi915->HDAresume order.
Thanks for doing this. Can you also revert 7b3b61b62a58 ("drm/todo:
i915 could use device_link_add") while at it?
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Lukas Wunner
Quoted 5 lines · Imre Deak
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the
HDA->i915suspend (and shutdown) andi915->HDAresume order.Thanks for doing this. Can you also revert
7b3b61b62a58("drm/todo:
i915 could usedevice_link_add") while at it?
Thanks, will update that once this gets merged and we get some testing coverage.
--Imre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 15 lines · Imre Deak
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the
HDA->i915suspend (and shutdown) andi915->HDAresume order.Atm, the lack of this ordering is not a problem, since all the i915 suspend/resume steps that need to be ordered wrt. the HDA driver's suspend/resume steps are separated out to the i915 suspend_late/resume_early hooks. That will change in a follow-up patchset where we'll need this ordering guarantee for steps that are in the i915 suspend/resume hooks (and which can't be moved to suspend_late/resume_early for other reasons). So this patch is a preparation for that follow-up patchset.
Quoted 7 lines
The change also allows us to move towards removing the i915 suspend_late/resume_early hooks alltogether.
Since we only need to ensure the ordering during suspend/resume and not during driver probing create the link with
DL_FLAG_STATELESS. Since the probe time ordering has to be optional we use the component framework for that.
And we manage runtime pm explicitly too so don't need/want DL_FLAG_PM_RUNTIME.
Quoted 13 lines
Cc Ville Syrjälä <[email protected]>Cc Takashi Iwai <[email protected]>Signed-off-by Imre Deak <[email protected]>--- drivers/gpu/drm/i915/intel_audio.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/i915/intel_audio.c +0
-0
drivers/gpu/drm/i915/intel_audio.c static int i915_audio_component_bind(struct device *i915_kdev, · line 925
Quoted 5 lines
drivers/gpu/drm/i915/intel_audio.c +2
-0@@ -921,6 +921,8 @@ static int i915_audio_component_bind(struct device *i915_kdev, dev_priv->audio_component = acomp;drm_modeset_unlock_all (&dev_priv->drm); +WARN_ON (!device_link_add (hda_kdev, i915_kdev,DL_FLAG_STATELESS )); +
I guess it's just the kzalloc() that could theoretically fail. Probably not a practical concern.
Didn't read through the entire device_link code, but this seems to agree with the docs.
Quoted 14 lines
drivers/gpu/drm/i915/intel_audio.c +2
-0return 0 ; }@@ -930,6 +932,8 @@ static void i915_audio_component_unbind(struct device *i915_kdev,struct i915_audio_component *acomp = data;struct drm_i915_private *dev_priv =kdev_to_i915 (i915_kdev); +device_link_remove (hda_kdev, i915_kdev); +drm_modeset_lock_all (&dev_priv->drm); acomp->base.ops =NULL ; acomp->base.dev =NULL ;Signature · 1 line
2.13.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Ville Syrjälä
Quoted 18 lines · Imre Deak
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the
HDA->i915suspend (and shutdown) andi915->HDAresume order.Atm, the lack of this ordering is not a problem, since all the i915 suspend/resume steps that need to be ordered wrt. the HDA driver's suspend/resume steps are separated out to the i915 suspend_late/resume_early hooks. That will change in a follow-up patchset where we'll need this ordering guarantee for steps that are in the i915 suspend/resume hooks (and which can't be moved to suspend_late/resume_early for other reasons). So this patch is a preparation for that follow-up patchset.
The change also allows us to move towards removing the i915 suspend_late/resume_early hooks alltogether.
Quoted 7 lines
Quoted 4 lines
Since we only need to ensure the ordering during suspend/resume and not during driver probing create the link with
DL_FLAG_STATELESS. Since the probe time ordering has to be optional we use the component framework for that.And we manage runtime pm explicitly too so don't need/want
DL_FLAG_PM_RUNTIME.
Yes, will add that too to the commit message.
Quoted 16 lines
Quoted 16 lines
Cc Ville Syrjälä <[email protected]>Cc Takashi Iwai <[email protected]>Signed-off-by Imre Deak <[email protected]>--- drivers/gpu/drm/i915/intel_audio.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/i915/intel_audio.c +0
-0@@ -921,6 +921,8 @@ static int i915_audio_component_bind(struct device *i915_kdev, dev_priv->audio_component = acomp;drm_modeset_unlock_all (&dev_priv->drm);
Quoted 5 lines
drivers/gpu/drm/i915/intel_audio.c static int i915_audio_component_bind(struct device *i915_kdev, · line 925
Quoted 2 lines
drivers/gpu/drm/i915/intel_audio.c +2
-0+WARN_ON (!device_link_add (hda_kdev, i915_kdev,DL_FLAG_STATELESS )); +I guess it's just the
kzalloc()that could theoretically fail. Probably not a practical concern.
Yep, missed that. For clarity we should still fail the component bind, which will make the HDA driver's bind time out and continue without HDMI functionality. For simpler error handling I'll move the device_link_add() call before initing acomp (moving the call to device_link_remove() accordingly).
Quoted 5 lines
Didn't read through the entire
device_linkcode, but this seems to agree with the docs.Reviewed-by Ville Syrjälä <[email protected]>
Thanks will respin with the above changes.
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_audio.c +0
-0return 0 ; }@@ -930,6 +932,8 @@ static void i915_audio_component_unbind(struct device *i915_kdev,struct i915_audio_component *acomp = data;struct drm_i915_private *dev_priv =kdev_to_i915 (i915_kdev);
Quoted 11 lines
Quoted 7 lines
drivers/gpu/drm/i915/intel_audio.c +2
-0+device_link_remove (hda_kdev, i915_kdev); +drm_modeset_lock_all (&dev_priv->drm); acomp->base.ops =NULL ; acomp->base.dev =NULL ;Signature · 1 line
2.13.2Signature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915: Ensure proper HDA suspend/resume ordering with a device link
In reply to Imre DeakIn order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the HDA->i915 suspend (and shutdown) and i915->HDA resume order.
Atm, the lack of this ordering is not a problem, since all the i915 suspend/resume steps that need to be ordered wrt. the HDA driver's suspend/resume steps are separated out to the i915 suspend_late/resume_early hooks. That will change in a follow-up patchset where we'll need this ordering guarantee for steps that are in the i915 suspend/resume hooks (and which can't be moved to suspend_late/resume_early for other reasons). So this patch is a preparation for that follow-up patchset.
The change also allows us to move towards removing the i915 suspend_late/resume_early hooks alltogether.
Since we only need to ensure the ordering during suspend/resume and not during driver probing create the link with DL_FLAG_STATELESS. Since the probe time ordering has to be optional we use the component framework for that.
Similarly for runtime PM we depend on the audio driver getting/putting an i915 runtime PM reference whenever it needs it (along with the proper i915 display power domain) via the audio component ops get_power / put_power hooks. So we create the device link without DL_FLAG_PM_RUNTIME.
v2: (Ville)
- Add a note to the commit message about not using the device link runtime PM ordering.
- Handle the error return from device_link_add().
--- drivers/gpu/drm/i915/intel_audio.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/intel_audio.c +5 -0
@@ -912,6 +912,9 @@ static int i915_audio_component_bind(struct device *i915_kdev,if (WARN_ON (acomp->base.ops || acomp->base.dev))return -EEXIST ; +if (WARN_ON (!device_link_add (hda_kdev, i915_kdev,DL_FLAG_STATELESS ))) +return -ENOMEM ; +drm_modeset_lock_all (&dev_priv->drm); acomp->base.ops = &i915_audio_component_ops; acomp->base.dev = i915_kdev;
@@ -935,6 +938,8 @@ static void i915_audio_component_unbind(struct device *i915_kdev, acomp->base.dev =NULL ; dev_priv->audio_component =NULL ;drm_modeset_unlock_all (&dev_priv->drm); + +device_link_remove (hda_kdev, i915_kdev); }static const struct component_ops i915_audio_component_bind_ops = {
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
URL : https://patchwork.freedesktop.org/series/51189/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5021 -> Patchwork_10546 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10546 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10546, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51189/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10546:
=== IGT changes ===
==== Possible regressions ====
igt@gem_ctx_switch@basic-default:
fi-icl-u: PASS -> INCOMPLETE== Known issues ==
Here are the changes found in Patchwork_10546 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#105128, fdo#107139)
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: PASS -> FAIL (fdo#103841, fdo#102672)
==== Possible fixes ====
igt@kms_flip@basic-flip-vs-dpms:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS
igt@kms_flip@basic-plain-flip:
fi-ilk-650: DMESG-WARN (fdo#106387) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362) -> PASS fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (49 -> 45) ==
Additional (1): fi-glk-j4005
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5021 -> Patchwork_10546
CI_DRM_5021: ac225ff8de488cb58eb8a241102abfb4342ff1e5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4688: fa6dbf8c048961356fd642df047cb58ab49309b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10546: 5e808ba1d550026425b7e5505f480503f51e1600 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5e808ba1d550 drm/i915: Ensure proper HDA suspend/resume ordering with a device link
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10546/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
URL : https://patchwork.freedesktop.org/series/51189/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5023 -> Patchwork_10548 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10548 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10548, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51189/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10548:
=== IGT changes ===
==== Warnings ====
igt@gem_ctx_switch@basic-default:
fi-icl-u: DMESG-FAIL -> INCOMPLETE== Known issues ==
Here are the changes found in Patchwork_10548 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_basic@cs-compute:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#108094)
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#107341)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362) -> PASS fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108094 https://bugs.freedesktop.org/show_bug.cgi?id=108094
== Participating hosts (49 -> 44) ==
Additional (1): fi-kbl-7560u
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5023 -> Patchwork_10548
CI_DRM_5023: 166bc98d7b77005943ab670506f164783cdc3f56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4688: fa6dbf8c048961356fd642df047cb58ab49309b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10548: a8f4eac6ac094dc14f113d4ae1383e90332aec5f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a8f4eac6ac09 drm/i915: Ensure proper HDA suspend/resume ordering with a device link
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10548/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
URL : https://patchwork.freedesktop.org/series/51189/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5023 -> Patchwork_10557 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51189/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10557 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_basic@cs-compute:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#108094)
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#107341)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362)
==== Possible fixes ====
igt@drv_selftest@live_execlists:
fi-apl-guc: INCOMPLETE (fdo#106693) -> PASS
igt@gem_ctx_switch@basic-default:
fi-icl-u: DMESG-FAIL -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362) -> PASS fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#108094 https://bugs.freedesktop.org/show_bug.cgi?id=108094
== Participating hosts (49 -> 44) ==
Additional (1): fi-kbl-7560u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u
== Build changes ==
* Linux: CI_DRM_5023 -> Patchwork_10557
CI_DRM_5023: 166bc98d7b77005943ab670506f164783cdc3f56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4688: fa6dbf8c048961356fd642df047cb58ab49309b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10557: 1eec8ecd4d23ecb162b91879700c76f183df23e5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1eec8ecd4d23 drm/i915: Ensure proper HDA suspend/resume ordering with a device link
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10557/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
URL : https://patchwork.freedesktop.org/series/51189/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5023_full -> Patchwork_10557_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10557_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_eio@in-flight-10ms:
shard-glk: PASS -> FAIL (fdo#107799)
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-kbl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-hang-newfb-render-b:
shard-apl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-b-degamma:
shard-apl: PASS -> FAIL (fdo#104782)
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-glk: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-skl: PASS -> FAIL (fdo#100368)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
shard-glk: PASS -> FAIL (fdo#103167) +1
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-glk: PASS -> FAIL (fdo#103166) +1
igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
shard-skl: NOTRUN -> FAIL (fdo#108146)
igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
shard-apl: PASS -> FAIL (fdo#108145)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-kbl: NOTRUN -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_cursor_crc@cursor-256x256-onscreen:
shard-glk: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-size-change:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS +1
igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
shard-skl: FAIL (fdo#103184) -> PASS
igt@kms_flip@busy-flip-interruptible:
shard-skl: FAIL (fdo#103257) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
shard-skl: FAIL (fdo#103167) -> PASS
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
shard-skl: INCOMPLETE (fdo#107773, fdo#104108) -> PASS
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: FAIL (fdo#103166) -> PASS
igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
shard-skl: FAIL (fdo#108145, fdo#107815) -> PASS
igt@kms_rotation_crc@sprite-rotation-180:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_vblank@pipe-a-ts-continuation-suspend:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS +1
igt@perf@short-reads:
shard-skl: FAIL (fdo#103183) -> PASS
igt@pm_rpm@legacy-planes-dpms:
shard-skl: INCOMPLETE (fdo#105959, fdo#107807) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103183 https://bugs.freedesktop.org/show_bug.cgi?id=103183
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103257 https://bugs.freedesktop.org/show_bug.cgi?id=103257
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107799 https://bugs.freedesktop.org/show_bug.cgi?id=107799
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5023 -> Patchwork_10557
CI_DRM_5023: 166bc98d7b77005943ab670506f164783cdc3f56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4688: fa6dbf8c048961356fd642df047cb58ab49309b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10557: 1eec8ecd4d23ecb162b91879700c76f183df23e5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10557/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Imre Deak
AppliedRe: ✓ Fi.CI.IGT: success for drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link (rev2)
URL : https://patchwork.freedesktop.org/series/51189/
State : success
Pushed to -dinq, thanks for the review.
Quoted 147 lines
== Summary ==
= CI Bug Log - changes from
CI_DRM_5023_full->Patchwork_10557_full=== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in
Patchwork_10557_fullthat come from known issues:=== IGT changes ===
==== Issues hit ==== igt@gem_eio@in-flight-10ms: shard-glk: PASS -> FAIL (fdo#107799) igt@kms_busy@extended-modeset-hang-newfb-render-b: shard-kbl: NOTRUN -> DMESG-WARN (fdo#107956) igt@kms_busy@extended-pageflip-hang-newfb-render-b: shard-apl: NOTRUN -> DMESG-WARN (fdo#107956) igt@kms_color@pipe-b-degamma: shard-apl: PASS -> FAIL (fdo#104782) igt@kms_cursor_crc@cursor-256x85-onscreen: shard-glk: PASS -> FAIL (fdo#103232) +2 igt@kms_cursor_crc@cursor-256x85-random: shard-apl: PASS -> FAIL (fdo#103232) +2 igt@kms_cursor_legacy@cursorb-vs-flipb-toggle: shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538) igt@kms_flip@plain-flip-fb-recreate-interruptible: shard-skl: PASS -> FAIL (fdo#100368) igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move: shard-apl: PASS -> FAIL (fdo#103167) igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen: shard-glk: PASS -> FAIL (fdo#103167) +1 igt@kms_plane@plane-position-covered-pipe-c-planes: shard-glk: PASS -> FAIL (fdo#103166) +1 igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: shard-glk: PASS -> FAIL (fdo#108145) igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: shard-skl: NOTRUN -> FAIL (fdo#108146) igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: shard-apl: PASS -> FAIL (fdo#108145) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) shard-kbl: NOTRUN -> FAIL (fdo#99912) ==== Possible fixes ==== igt@kms_ccs@pipe-b-crc-sprite-planes-basic: shard-glk: FAIL (fdo#108145) -> PASS igt@kms_cursor_crc@cursor-256x256-onscreen: shard-glk: FAIL (fdo#103232) -> PASS igt@kms_cursor_crc@cursor-size-change: shard-apl: FAIL (fdo#103232) -> PASS igt@kms_cursor_legacy@cursora-vs-flipa-toggle: shard-glk: DMESG-WARN (fdo#105763, fdo#106538) -> PASS +1 igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled: shard-skl: FAIL (fdo#103184) -> PASS igt@kms_flip@busy-flip-interruptible: shard-skl: FAIL (fdo#103257) -> PASS igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc: shard-apl: FAIL (fdo#103167) -> PASS igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu: shard-skl: FAIL (fdo#103167) -> PASS igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: shard-skl: INCOMPLETE (fdo#107773, fdo#104108) -> PASS igt@kms_plane@plane-position-covered-pipe-a-planes: shard-apl: FAIL (fdo#103166) -> PASS igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: shard-skl: FAIL (fdo#108145, fdo#107815) -> PASS igt@kms_rotation_crc@sprite-rotation-180: shard-apl: INCOMPLETE (fdo#103927) -> PASS igt@kms_vblank@pipe-a-ts-continuation-suspend: shard-kbl: INCOMPLETE (fdo#103665) -> PASS +1 igt@perf@short-reads: shard-skl: FAIL (fdo#103183) -> PASS igt@pm_rpm@legacy-planes-dpms: shard-skl: INCOMPLETE (fdo#105959, fdo#107807) -> PASSfdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103183 https://bugs.freedesktop.org/show_bug.cgi?id=103183
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103257 https://bugs.freedesktop.org/show_bug.cgi?id=103257
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105959 https://bugs.freedesktop.org/show_bug.cgi?id=105959
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107799 https://bugs.freedesktop.org/show_bug.cgi?id=107799
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108146 https://bugs.freedesktop.org/show_bug.cgi?id=108146
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux:
CI_DRM_5023->Patchwork_10557
Quoted 8 lines
CI_DRM_5023:166bc98d7b77005943ab670506f164783cdc3f56@git://anongit.freedesktop.org/gfx-ci/linux
IGT_4688:fa6dbf8c048961356fd642df047cb58ab49309b2@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10557:1eec8ecd4d23ecb162b91879700c76f183df23e5@git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509:fdc5a4ca11124ab8413c7988896eec4c97336694@git://anongit.freedesktop.org/piglit== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10557/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx