Skip to contentSkip to conversation

security: fix documentation for the task_setscheduler hook

PATCH In review [email protected] 2 participants 2 messages Oct 23, 2018 Security (LSM)

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 security: fix documentation for the task_setscheduler hook

From: Denis Efremov <[email protected]>

The task_setscheduler hook was changed in the commit "security: remove unused parameter from security_task_setscheduler()" (b0ae19811375). The arguments @policy, @lp were removed from the hook. This patch updates the documentation accordingly.

Signed-off-by Denis Efremov <[email protected]>
---
 include/linux/lsm_hooks.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
include/linux/lsm_hooks.h +1 -3
index accf6f34ac8e..ae3766720264 100644
@@ -655,10 +655,8 @@
  *	Return 0 if permission is granted.
  * @task_setscheduler:
  *	Check permission before setting scheduling policy and/or parameters of
- *	process @p based on @policy and @lp.
+ *	process @p.
  *	@p contains the task_struct for process.
- *	@policy contains the scheduling policy.
- *	@lp contains the scheduling parameters.
  *	Return 0 if permission is granted.
  * @task_getscheduler:
  *	Check permission before obtaining scheduling information for process
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Tue, Oct 23, 2018 at 4:12 AM, <[email protected]> wrote:

From: Denis Efremov <[email protected]>

The task_setscheduler hook was changed in the commit "security: remove unused parameter from security_task_setscheduler()" (b0ae19811375). The arguments @policy, @lp were removed from the hook. This patch updates the documentation accordingly.

Signed-off-by Denis Efremov <[email protected]>
Reviewed-by Kees Cook <[email protected]>

-Kees

Quoted 23 lines
---
 include/linux/lsm_hooks.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
include/linux/lsm_hooks.h +1 -4
index accf6f34ac8e..ae3766720264 100644
@@ -655,10 +655,8 @@
  *     Return 0 if permission is granted.
  * @task_setscheduler:
  *     Check permission before setting scheduling policy and/or parameters of
- *     process @p based on @policy and @lp.
+ *     process @p.
  *     @p contains the task_struct for process.
- *     @policy contains the scheduling policy.
- *     @lp contains the scheduling parameters.
  *     Return 0 if permission is granted.
  * @task_getscheduler:
  *     Check permission before obtaining scheduling information for process
--

2.17.2

Signature · 1 line
Kees Cook