Skip to contentSkip to conversation

security: fix documentation for the path_chmod hook

PATCH In review [email protected] 2 participants 2 messages Oct 23, 2018 Security (LSM)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 security: fix documentation for the path_chmod hook

From: Denis Efremov <[email protected]>

The path_chmod hook was changed in the commit
"switch security_path_chmod() to struct path *" (cdcf116d44e7). The argument @mnt was removed from the hook, @dentry was changed to @path. This patch updates the documentation accordingly.

---
 include/linux/lsm_hooks.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/lsm_hooks.h +1 -2
index a598e601ccb3..596351f7c3d1 100644
@@ -304,8 +304,7 @@
  *	Return 0 if permission is granted.
  * @path_chmod:
  *	Check for permission to change DAC's permission of a file or directory.
- *	@dentry contains the dentry structure.
- *	@mnt contains the vfsmnt structure.
+ *	@path contains the path structure.
  *	@mode contains DAC's mode.
  *	Return 0 if permission is granted.
  * @path_chown:
Signature · 1 line
2.17.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Tue, Oct 23, 2018 at 4:16 AM, <[email protected]> wrote:

From: Denis Efremov <[email protected]>

The path_chmod hook was changed in the commit
"switch security_path_chmod() to struct path *" (cdcf116d44e7). The argument @mnt was removed from the hook, @dentry was changed to @path. This patch updates the documentation accordingly.

-Kees

Quoted 21 lines
---
 include/linux/lsm_hooks.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
include/linux/lsm_hooks.h +1 -3
index a598e601ccb3..596351f7c3d1 100644
@@ -304,8 +304,7 @@
  *     Return 0 if permission is granted.
  * @path_chmod:
  *     Check for permission to change DAC's permission of a file or directory.
- *     @dentry contains the dentry structure.
- *     @mnt contains the vfsmnt structure.
+ *     @path contains the path structure.
  *     @mode contains DAC's mode.
  *     Return 0 if permission is granted.
  * @path_chown:
--

2.17.2

Signature · 1 line
Kees Cook