Skip to contentSkip to conversation

rapidjson: Update to newer 1.1.0 + git

PATCH In review Joshua Watt 1 participant 2 messages Oct 23, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rapidjson: Update to newer 1.1.0 + git

Bring in a newer version of rapidjson which includes a fixes when running on ARM, specifically 748a652f04 ("Fix SIGBUS due to unaligned access")

Also remove the existing patch file as the issue was resolved in the mainline by 4c9a28a28e ("CMake: do not pass -march=native or -mcpu=native when crosscompiling")

---
 meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb +2 -4
index 76e01f824..ec3df8263 100644
@@ -4,11 +4,9 @@ SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://license.txt;md5=ba04aa8f65de1396a7e59d1d746c2125"
 
-SRC_URI = "git://github.com/miloyip/rapidjson.git;nobranch=1 \
-           file://remove-march-native-from-CMAKE_CXX_FLAGS.patch \
-"
+SRC_URI = "git://github.com/miloyip/rapidjson.git;nobranch=1"
 
-SRCREV = "e5635fb27feab7f6e8d7b916aa20ad799045a641"
+SRCREV = "6a905f9311f82d306da77bd963ec5aa5da07da9c"
 
 PV = "1.1.0+git${SRCPV}"
 
Signature · 1 line
2.17.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 10 lines · On Tue, Oct 23, 2018, 5:32 PM akuster808 <[email protected]> wrote:
Quoted 3 lines · Joshua Watt

Bring in a newer version of rapidjson which includes a fixes when running on ARM, specifically 748a652f04 ("Fix SIGBUS due to unaligned access")

Master can do what it want bug Stable has many concerns. What version was the old hash? How many changes between the two versions? Is this a bug fix only update? Did you build it on all arches and with musl too?

Right. I reused the same git command to send both rapidjson patches, which I should not have done. This doesn't need to be backported (or, a least, I can send another patch with just the ARM alignment fix later). Sorry.

Quoted 35 lines

- armin

Quoted 5 lines

Also remove the existing patch file as the issue was resolved in the mainline by 4c9a28a28e ("CMake: do not pass -march=native or -mcpu=native when crosscompiling")

Review

Quoted 7 lines
---
 meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb

meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb SECTION = "libs" · line 5

Quoted 6 lines

index 76e01f824..ec3df8263 100644

meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb +0 -0
@@ -4,11 +4,9 @@ SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM =

"file://license.txt;md5=ba04aa8f65de1396a7e59d1d746c2125"

Quoted 11 lines
meta-oe/recipes-devtools/rapidjson/rapidjson_git.bb +2 -4
-SRC_URI = "git://github.com/miloyip/rapidjson.git;nobranch=1 \
-           file://remove-march-native-from-CMAKE_CXX_FLAGS.patch \
-"
+SRC_URI = "git://github.com/miloyip/rapidjson.git;nobranch=1"
 
-SRCREV = "e5635fb27feab7f6e8d7b916aa20ad799045a641"
+SRCREV = "6a905f9311f82d306da77bd963ec5aa5da07da9c"
 
 PV = "1.1.0+git${SRCPV}"