Skip to contentSkip to conversation

systemd-conf: add CLEANBROKEN

PATCH In review Andreas Müller 3 participants 4 messages Oct 24, 2018 – Oct 25, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemd-conf: add CLEANBROKEN

| DEBUG: Executing shell function do_configure
| NOTE: make clean
| make: *** No rule to make target 'clean'.  Stop.
| ERROR: oe_runmake failed
---
 meta/recipes-core/systemd/systemd-conf.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/systemd/systemd-conf.bb +2 -0
index c694efbbf14..111ef2497a3 100644
@@ -18,6 +18,8 @@ FILES_${PN} = "${sysconfdir}/machine-id ${sysconfdir}/systemd"
 
 do_compile[noexec] = '1'
 
+CLEANBROKEN = "1"
+
 do_install() {
 	install -d ${D}/${sysconfdir}/systemd
 
Signature · 1 line
2.14.5
#1 lore raw
Quoted 20 lines · Andreas Müller
Quoted 4 lines

DEBUG: Executing shell function do_configure
NOTE: make clean
make: *** No rule to make target 'clean'. Stop.
ERROR: oe_runmake failed

---
 meta/recipes-core/systemd/systemd-conf.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/systemd/systemd-conf.bb +0 -0
index c694efbbf14..111ef2497a3 100644
@@ -18,6 +18,8 @@ FILES_${PN} = "${sysconfdir}/machine-id

${sysconfdir}/systemd"

do_compile[noexec] = '1'

meta/recipes-core/systemd/systemd-conf.bb FILES_${PN} = "${sysconfdir}/machine-id ${sysconfdir}/systemd" · line 22

Quoted 2 lines
meta/recipes-core/systemd/systemd-conf.bb +2 -0
+CLEANBROKEN = "1"
+

I suspect a do_configure[noexec] = '1' may be a better way to fix this?

I also suspect Mark's other patch needs this tweak too?

Cheers,

Richard

#2 lore raw
Quoted 20 lines · Richard Purdie
Quoted 18 lines · Andreas Müller
Quoted 4 lines

DEBUG: Executing shell function do_configure
NOTE: make clean
make: *** No rule to make target 'clean'. Stop.
ERROR: oe_runmake failed

---
 meta/recipes-core/systemd/systemd-conf.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/systemd/systemd-conf.bb +0 -0
index c694efbbf14..111ef2497a3 100644
@@ -18,6 +18,8 @@ FILES_${PN} = "${sysconfdir}/machine-id

${sysconfdir}/systemd"

Quoted 6 lines

meta/recipes-core/systemd/systemd-conf.bb FILES_${PN} = "${sysconfdir}/machine-id ${sysconfdir}/systemd" · line 22

Quoted 4 lines

do_compile[noexec] = '1'

meta/recipes-core/systemd/systemd-conf.bb +2 -0
+CLEANBROKEN = "1"
+

I suspect a do_configure[noexec] = '1' may be a better way to fix this?

Have no idea if there (path-)replacements done during configure which would not be performed and break install then.

Andreas

Quoted 7 lines

I also suspect Mark's other patch needs this tweak too?

Cheers,

Richard

#3 lore raw
Quoted 22 lines · Andreas Müller
Quoted 20 lines · Richard Purdie
Quoted 18 lines · Andreas Müller
Quoted 4 lines

DEBUG: Executing shell function do_configure
NOTE: make clean
make: *** No rule to make target 'clean'. Stop.
ERROR: oe_runmake failed

---
 meta/recipes-core/systemd/systemd-conf.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/systemd/systemd-conf.bb +0 -0
index c694efbbf14..111ef2497a3 100644
@@ -18,6 +18,8 @@ FILES_${PN} = "${sysconfdir}/machine-id

${sysconfdir}/systemd"

Quoted 8 lines
Quoted 6 lines

meta/recipes-core/systemd/systemd-conf.bb FILES_${PN} = "${sysconfdir}/machine-id ${sysconfdir}/systemd" · line 22

Quoted 4 lines

do_compile[noexec] = '1'

meta/recipes-core/systemd/systemd-conf.bb +2 -0
+CLEANBROKEN = "1"
+

I suspect a do_configure[noexec] = '1' may be a better way to fix this?

Have no idea if there (path-)replacements done during configure which would not be performed and break install then.

Neither recipe has a configure step, but since it looks for 'configure', it becomes no-op.

I'll check if just do_configure[noexec] = '1' is enough, if not, I'll add the cleanbroken.

Quoted 8 lines

Andreas

Quoted 7 lines

I also suspect Mark's other patch needs this tweak too?

Cheers,

Richard