Skip to contentSkip to conversation

xen/pvh: don't try to unplug emulated devices

PATCH In review Juergen Gross 2 participants 3 messages Oct 25, 2018

Subsystems (3)
lore
Share & tools
lore

Juergen Gross

author maintainer
#0 lore raw

PATCH 1/1 xen/pvh: don't try to unplug emulated devices

A Xen PVH guest has no associated qemu device model, so trying to unplug any emulated devices is making no sense at all.

Bail out early from xen_unplug_emulated_devices() when running as PVH guest. This will avoid issuing the boot message:

[    0.000000] Xen Platform PCI: unrecognised magic value
---
 arch/x86/xen/platform-pci-unplug.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/x86/xen/platform-pci-unplug.c +4 -0
index 66ab96a4e2b3..96d7f7d39cb9 100644
@@ -134,6 +134,10 @@ void xen_unplug_emulated_devices(void)
 {
 	int r;
 
+	/* PVH guests don't have emulated devices. */
+	if (xen_pvh_domain())
+		return;
+
 	/* user explicitly requested no unplug */
 	if (xen_emul_unplug & XEN_UNPLUG_NEVER)
 		return;
Signature · 1 line
2.16.4
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Juergen Gross

A Xen PVH guest has no associated qemu device model, so trying to unplug any emulated devices is making no sense at all.

Bail out early from xen_unplug_emulated_devices() when running as PVH guest. This will avoid issuing the boot message:

[    0.000000] Xen Platform PCI: unrecognised magic value

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Juergen Gross
Quoted 10 lines · Juergen Gross

A Xen PVH guest has no associated qemu device model, so trying to unplug any emulated devices is making no sense at all.

Bail out early from xen_unplug_emulated_devices() when running as PVH guest. This will avoid issuing the boot message:

[    0.000000] Xen Platform PCI: unrecognised magic value