Skip to contentSkip to conversation

attempts at catching mmu_notifer deadlocks

PATCH New Daniel Vetter 2 participants 11 messages Oct 25, 2018

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

cover attempts at catching mmu_notifer deadlocks

Hi all,

So this is my 2nd attempt (more successful I hope also with CI) at catching the mmu notifier deadlock using lockdep. Ingredients:
- cross-release patches resurrect (so that lockdep see through flush_workqueue).
- fake lock context for mmu notifier callbacks (similar trick to fs_reclaim)
- bunch of sanity checks because hey! paranoia is good

Intentionally not yet submitting to core/mm since I want to figure out whether this is indeed useful for us first.

Cheers, Daniel

Daniel Vetter (6):
locking/lockdep: restore cross-release checks
kthread: finer-grained lockdep/cross-release completion
lockdep: Remove GFP_NOLOCKDEP annotation
mm: Check if mmut notifier callbacks are allowed to fail mm, notifier: Catch sleeping/blocking for !blockable mm, notifier: Add a lockdep map for invalidate_range_start

 .../admin-guide/kernel-parameters.txt         |   3 +
 Documentation/locking/crossrelease.txt        | 874 ++++++++++++++++++
 include/linux/completion.h                    |  46 +
 include/linux/gfp.h                           |  10 +-
 include/linux/irqflags.h                      |   4 +
 include/linux/kthread.h                       |  48 +-
 include/linux/lockdep.h                       | 127 +++
 include/linux/mmu_notifier.h                  |   7 +
 include/linux/sched.h                         |  11 +
 kernel/kthread.c                              |  68 +-
 kernel/locking/lockdep.c                      | 652 ++++++++++++-
 kernel/sched/completion.c                     |   5 +
 lib/Kconfig.debug                             |  33 +
 mm/mmu_notifier.c                             |  17 +-
 mm/page_alloc.c                               |   3 -
 15 files changed, 1832 insertions(+), 76 deletions(-)
 create mode 100644 Documentation/locking/crossrelease.txt
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

PATCH 1/6 locking/lockdep: restore cross-release checks

This reverts the following commits:

commit 527187d28569e39c5d489d6306d3b79605cf85a6

Author: Ingo Molnar <[email protected]>
Date:   Mon Jan 8 17:27:19 2018 +0100

locking/lockdep: Remove cross-release leftovers

commit dba04eb76df982703fefc021a4d278347b6176a9

Author: David Sterba <[email protected]>
Date:   Mon Jan 8 16:27:31 2018 +0100

locking/Documentation: Remove stale crossrelease_fullstack parameter

commit e966eaeeb623f09975ef362c2866fae6f86844f9

Author: Ingo Molnar <[email protected]>
Date:   Tue Dec 12 12:31:16 2017 +0100

locking/lockdep: Remove the cross-release locking checks

---
 .../admin-guide/kernel-parameters.txt         |   3 +
 Documentation/locking/crossrelease.txt        | 874 ++++++++++++++++++
 include/linux/completion.h                    |  46 +
 include/linux/irqflags.h                      |   4 +
 include/linux/lockdep.h                       | 127 +++
 include/linux/sched.h                         |  11 +
 kernel/locking/lockdep.c                      | 652 ++++++++++++-
 kernel/sched/completion.c                     |   5 +
 lib/Kconfig.debug                             |  33 +
 9 files changed, 1720 insertions(+), 35 deletions(-)
 create mode 100644 Documentation/locking/crossrelease.txt
Documentation/admin-guide/kernel-parameters.txt +3 -0
index 92eb1f42240d..6ab3ad188c01 100644
@@ -724,6 +724,9 @@
 			It will be ignored when crashkernel=X,high is not used
 			or memory reserved is below 4G.
 
+	crossrelease_fullstack
+			[KNL] Allow to record full stack trace in cross-release
+
 	cryptomgr.notests
 			[KNL] Disable crypto self-tests
 
Documentation/locking/crossrelease.txt new file +874 -0

874 lines not on this page · raw message

include/linux/completion.h +46 -0

67 lines not on this page · raw message

include/linux/irqflags.h +4 -0
index 21619c92c377..bd1bda7248bf 100644
@@ -38,18 +38,22 @@
 # define trace_hardirq_enter()			\
 do {						\
 	current->hardirq_context++;		\
+	crossrelease_hist_start(XHLOCK_HARD);	\
 } while (0)
 # define trace_hardirq_exit()			\
 do {						\
 	current->hardirq_context--;		\
+	crossrelease_hist_end(XHLOCK_HARD);	\
 } while (0)
 # define lockdep_softirq_enter()		\
 do {						\
 	current->softirq_context++;		\
+	crossrelease_hist_start(XHLOCK_SOFT);	\
 } while (0)
 # define lockdep_softirq_exit()			\
 do {						\
 	current->softirq_context--;		\
+	crossrelease_hist_end(XHLOCK_SOFT);	\
 } while (0)
 #else
 # define trace_hardirqs_on()		do { } while (0)
include/linux/lockdep.h +127 -0

156 lines not on this page · raw message

include/linux/sched.h +11 -0
index 977cb57d7bc9..155c7690eb15 100644
@@ -936,6 +936,17 @@ struct task_struct {
 	struct held_lock		held_locks[MAX_LOCK_DEPTH];
 #endif
 
+#ifdef CONFIG_LOCKDEP_CROSSRELEASE
+#define MAX_XHLOCKS_NR 64UL
+	struct hist_lock *xhlocks; /* Crossrelease history locks */
+	unsigned int xhlock_idx;
+	/* For restoring at history boundaries */
+	unsigned int xhlock_idx_hist[XHLOCK_CTX_NR];
+	unsigned int hist_id;
+	/* For overwrite check at each context exit */
+	unsigned int hist_id_save[XHLOCK_CTX_NR];
+#endif
+
 #ifdef CONFIG_UBSAN
 	unsigned int			in_ubsan;
 #endif
kernel/locking/lockdep.c +617 -35

746 lines not on this page · raw message

kernel/sched/completion.c +5 -0
index a1ad5b7d5521..0f7c442f9dd7 100644
@@ -31,6 +31,11 @@ void complete(struct completion *x)
 
 	spin_lock_irqsave(&x->wait.lock, flags);
 
+	/*
+	 * Perform commit of crossrelease here.
+	 */
+	complete_release_commit(x);
+
 	if (x->done != UINT_MAX)
 		x->done++;
 	__wake_up_locked(&x->wait, TASK_NORMAL, 1);
lib/Kconfig.debug +33 -0
index 1ead06829fdb..fbfdf7c263d2 100644
@@ -1055,6 +1055,8 @@ config PROVE_LOCKING
 	select DEBUG_RWSEMS if RWSEM_SPIN_ON_OWNER
 	select DEBUG_WW_MUTEX_SLOWPATH
 	select DEBUG_LOCK_ALLOC
+	select LOCKDEP_CROSSRELEASE
+	select LOCKDEP_COMPLETIONS
 	select TRACE_IRQFLAGS
 	default n
 	help
@@ -1187,6 +1189,37 @@ config LOCKDEP
 config LOCKDEP_SMALL
 	bool
 
+config LOCKDEP_CROSSRELEASE
+	bool
+	help
+	 This makes lockdep work for crosslock which is a lock allowed to
+	 be released in a different context from the acquisition context.
+	 Normally a lock must be released in the context acquiring the lock.
+	 However, relexing this constraint helps synchronization primitives
+	 such as page locks or completions can use the lock correctness
+	 detector, lockdep.
+
+config LOCKDEP_COMPLETIONS
+	bool
+	help
+	 A deadlock caused by wait_for_completion() and complete() can be
+	 detected by lockdep using crossrelease feature.
+
+config BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK
+	bool "Enable the boot parameter, crossrelease_fullstack"
+	depends on LOCKDEP_CROSSRELEASE
+	default n
+	help
+	 The lockdep "cross-release" feature needs to record stack traces
+	 (of calling functions) for all acquisitions, for eventual later
+	 use during analysis. By default only a single caller is recorded,
+	 because the unwind operation can be very expensive with deeper
+	 stack chains.
+
+	 However a boot parameter, crossrelease_fullstack, was
+	 introduced since sometimes deeper traces are required for full
+	 analysis. This option turns on the boot parameter.
+
 config DEBUG_LOCKDEP
 	bool "Lock dependency engine debugging"
 	depends on DEBUG_KERNEL && LOCKDEP
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

PATCH 2/6 kthread: finer-grained lockdep/cross-release completion

In reply to Daniel Vetter

Since -rc1 we're hitting a bunch of lockdep splats using the new cross-release stuff around the 2 kthread completions. In all cases they are because totally independent uses of kthread are mixed up by lockdep into the same locking class, creating artificial deadlocks.

Fix this by converting kthread code in the same way as e.g. alloc_workqueue already works: Use macros for the public api so we can have a callsite specific lockdep key, then pass that through the entire callchain. Due to the many entry points this is slightly tedious.

Cc: Tvrtko Ursulin <[email protected]>
Cc: Marta Lofstedt <[email protected]>
Cc: Byungchul Park <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Shaohua Li <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: Oleg Nesterov <[email protected]>
References: https://bugs.freedesktop.org/show_bug.cgi?id=103950

---
 include/linux/kthread.h | 48 ++++++++++++++++++++++++-----
 kernel/kthread.c        | 68 ++++++++++++++++++++++++++++-------------
 2 files changed, 88 insertions(+), 28 deletions(-)
include/linux/kthread.h +41 -7
index c1961761311d..7a9463f0be5c 100644
@@ -6,10 +6,12 @@
 #include <linux/sched.h>
 #include <linux/cgroup.h>
 
-__printf(4, 5)
-struct task_struct *kthread_create_on_node(int (*threadfn)(void *data),
+__printf(6, 7)
+struct task_struct *_kthread_create_on_node(int (*threadfn)(void *data),
 					   void *data,
 					   int node,
+					   struct lock_class_key *exited_key,
+					   struct lock_class_key *parked_key,
 					   const char namefmt[], ...);
 
 /**
@@ -25,12 +27,27 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data),
  */
 #define kthread_create(threadfn, data, namefmt, arg...) \
 	kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg)
+#define kthread_create_on_node(threadfn, data, node, namefmt, arg...)	\
+({									\
+	static struct lock_class_key __exited_key, __parked_key;	\
+	_kthread_create_on_node(threadfn, data, node, &__exited_key,	\
+			       &__parked_key, namefmt, ##arg);		\
+})
 
 
-struct task_struct *kthread_create_on_cpu(int (*threadfn)(void *data),
+struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data),
 					  void *data,
 					  unsigned int cpu,
+					  struct lock_class_key *exited_key,
+					  struct lock_class_key *parked_key,
 					  const char *namefmt);
+#define kthread_create_on_cpu(threadfn, data, cpu, namefmt)		\
+({									\
+	static struct lock_class_key __exited_key, __parked_key;	\
+	_kthread_create_on_cpu(threadfn, data, cpu, &__exited_key,\
+			       &__parked_key, namefmt);			\
+})
+
 
 /**
  * kthread_run - create and wake a thread.
@@ -171,13 +188,30 @@ extern void __kthread_init_worker(struct kthread_worker *worker,
 
 int kthread_worker_fn(void *worker_ptr);
 
-__printf(2, 3)
+__printf(4, 5)
 struct kthread_worker *
-kthread_create_worker(unsigned int flags, const char namefmt[], ...);
+_kthread_create_worker(unsigned int flags,
+		       struct lock_class_key *exited_key,
+		       struct lock_class_key *parked_key,
+		       const char namefmt[], ...);
+#define kthread_create_worker(flags, namefmt...)				\
+({									\
+	static struct lock_class_key __exited_key, __parked_key;	\
+	_kthread_create_worker(flags, &__exited_key, &__parked_key,	\
+			       ##namefmt);				\
+})
 
-__printf(3, 4) struct kthread_worker *
-kthread_create_worker_on_cpu(int cpu, unsigned int flags,
+__printf(5, 6) struct kthread_worker *
+_kthread_create_worker_on_cpu(int cpu, unsigned int flags,
+		       struct lock_class_key *exited_key,
+		       struct lock_class_key *parked_key,
 			     const char namefmt[], ...);
+#define kthread_create_worker_on_cpu(cpu, flags, namefmt...)	\
+({									\
+	static struct lock_class_key __exited_key, __parked_key;	\
+	_kthread_create_worker_on_cpu(cpu, flags, &__exited_key, &__parked_key,\
+			       ##namefmt);				\
+})
 
 bool kthread_queue_work(struct kthread_worker *worker,
 			struct kthread_work *work);
kernel/kthread.c +47 -21

164 lines not on this page · raw message

Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

PATCH 3/6 lockdep: Remove GFP_NOLOCKDEP annotation

In reply to Daniel Vetter

This was originally added in 7e7844226f10 ("lockdep: allow to disable reclaim lockup detection") but a git log -G "GFP_NOLOCKDEP" indicates it was never used.

Cc Andrew Morton <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Levin, Alexander (Sasha Levin)" <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Huaisheng Ye <[email protected]>
Cc Pavel Tatashin <[email protected]>
Cc Aaron Lu <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Joonsoo Kim <[email protected]>
Cc Dave Chinner <[email protected]>
Cc Peter Zijlstra <[email protected]>
---
 include/linux/gfp.h | 10 +---------
 mm/page_alloc.c     |  3 ---
 2 files changed, 1 insertion(+), 12 deletions(-)
include/linux/gfp.h +1 -9
index 24bcc5eec6b4..7709106d87fd 100644
@@ -39,11 +39,6 @@ struct vm_area_struct;
 #define ___GFP_ACCOUNT		0x100000u
 #define ___GFP_DIRECT_RECLAIM	0x200000u
 #define ___GFP_KSWAPD_RECLAIM	0x400000u
-#ifdef CONFIG_LOCKDEP
-#define ___GFP_NOLOCKDEP	0x800000u
-#else
-#define ___GFP_NOLOCKDEP	0
-#endif
 /* If the above are modified, __GFP_BITS_SHIFT may need updating */
 
 /*
@@ -213,11 +208,8 @@ struct vm_area_struct;
 #define __GFP_COMP	((__force gfp_t)___GFP_COMP)
 #define __GFP_ZERO	((__force gfp_t)___GFP_ZERO)
 
-/* Disable lockdep for GFP context tracking */
-#define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP)
-
 /* Room for N __GFP_FOO bits */
-#define __GFP_BITS_SHIFT (23 + IS_ENABLED(CONFIG_LOCKDEP))
+#define __GFP_BITS_SHIFT 23
 #define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SHIFT) - 1))
 
 /**
mm/page_alloc.c +0 -3
index e2ef1c17942f..b238ab7c1c0d 100644
@@ -3717,9 +3717,6 @@ static bool __need_fs_reclaim(gfp_t gfp_mask)
 	if (!(gfp_mask & __GFP_FS))
 		return false;
 
-	if (gfp_mask & __GFP_NOLOCKDEP)
-		return false;
-
 	return true;
 }
 
Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

PATCH 4/6 mm: Check if mmut notifier callbacks are allowed to fail

In reply to Daniel Vetter

Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all.

---
 mm/mmu_notifier.c | 2 ++
 1 file changed, 2 insertions(+)
mm/mmu_notifier.c +2 -0
index 82bb1a939c0e..744840e5636e 100644
@@ -190,6 +190,8 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm,
 				pr_info("%pS callback failed with %d in %sblockable context.\n",
 						mn->ops->invalidate_range_start, _ret,
 						!blockable ? "non-" : "");
+				WARN(blockable,"%pS callback failure not allowed\n",
+				     mn->ops->invalidate_range_start);
 				ret = _ret;
 			}
 		}
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#5 lore raw

PATCH 5/6 mm, notifier: Catch sleeping/blocking for !blockable

In reply to Daniel Vetter

We need to make sure implementations don't cheat and don't have a possible schedule/blocking point deeply burried where review can't catch it.

---
 mm/mmu_notifier.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
mm/mmu_notifier.c +7 -1
index 744840e5636e..4d56e2645b6c 100644
@@ -185,7 +185,13 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm,
 	id = srcu_read_lock(&srcu);
 	hlist_for_each_entry_rcu(mn, &mm->mmu_notifier_mm->list, hlist) {
 		if (mn->ops->invalidate_range_start) {
-			int _ret = mn->ops->invalidate_range_start(mn, mm, start, end, blockable);
+			int _ret;
+
+			if (IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP) && !blockable)
+				preempt_disable();
+			_ret = mn->ops->invalidate_range_start(mn, mm, start, end, blockable);
+			if (IS_ENABLED(CONFIG_DEBUG_ATOMIC_SLEEP) && !blockable)
+				preempt_enable();
 			if (_ret) {
 				pr_info("%pS callback failed with %d in %sblockable context.\n",
 						mn->ops->invalidate_range_start, _ret,
Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

PATCH 6/6 mm, notifier: Add a lockdep map for invalidate_range_start

In reply to Daniel Vetter

This is a similar idea to the fs_reclaim fake lockdep lock. It's fairly easy to provoke a specific notifier to be run on a specific
range: Just prep it, and then munmap() it.

A bit harder, but still doable, is to provoke the mmu notifiers for all the various callchains that might lead to them. But both at the same time is really hard to reliable hit, especially when you want to exercise paths like direct reclaim or compaction, where it's not easy to control what exactly will be unmapped.

By introducing a lockdep map to tie them all together we allow lockdep to see a lot more dependencies, without having to actually hit them in a single challchain while testing.

Aside: Since I typed this to test i915 mmu notifiers I've only rolled this out for the invaliate_range_start callback. If there's interest, we should probably roll this out to all of them. But my undestanding of core mm is seriously lacking, and I'm not clear on whether we need a lockdep map for each callback, or whether some can be shared.

---
 include/linux/mmu_notifier.h | 7 +++++++
 mm/mmu_notifier.c            | 7 +++++++
 2 files changed, 14 insertions(+)
include/linux/mmu_notifier.h +7 -0
index 133ba78820ee..080a9173c7dc 100644
@@ -16,6 +16,10 @@ struct mmu_notifier_ops;
 
 #ifdef CONFIG_MMU_NOTIFIER
 
+#ifdef CONFIG_LOCKDEP
+extern struct lockdep_map __mmu_notifier_invalidate_range_start_map;
+#endif
+
 /*
  * The mmu notifier_mm structure is allocated and installed in
  * mm->mmu_notifier_mm inside the mm_take_all_locks() protected
@@ -283,8 +287,11 @@ static inline void mmu_notifier_change_pte(struct mm_struct *mm,
 static inline void mmu_notifier_invalidate_range_start(struct mm_struct *mm,
 				  unsigned long start, unsigned long end)
 {
+	mutex_acquire(&__mmu_notifier_invalidate_range_start_map, 0, 0,
+		      _RET_IP_);
 	if (mm_has_notifiers(mm))
 		__mmu_notifier_invalidate_range_start(mm, start, end, true);
+	mutex_release(&__mmu_notifier_invalidate_range_start_map, 1, _RET_IP_);
 }
 
 static inline int mmu_notifier_invalidate_range_start_nonblock(struct mm_struct *mm,
mm/mmu_notifier.c +7 -0
index 4d56e2645b6c..12b917733856 100644
@@ -23,6 +23,13 @@
 /* global SRCU for all MMs */
 DEFINE_STATIC_SRCU(srcu);
 
+#ifdef CONFIG_LOCKDEP
+struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
+	.name = "mmu_notifier_invalidate_range_start"
+};
+EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
+#endif
+
 /*
  * This function allows mmu_notifier::release callback to delay a call to
  * a function that will free appropriate resources. The function must be
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#7 lore raw

✗ Fi.CI.CHECKPATCH: warning for attempts at catching mmu_notifer deadlocks

In reply to Daniel Vetter
== Series Details ==

== Series Details ==

Series: attempts at catching mmu_notifer deadlocks
URL : https://patchwork.freedesktop.org/series/51522/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
13ea12ad517b locking/lockdep: restore cross-release checks
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 527187d28569 ("locking/lockdep: Remove cross-release leftovers")'
#8: 
commit 527187d28569e39c5d489d6306d3b79605cf85a6

-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit dba04eb76df9 ("locking/Documentation: Remove stale crossrelease_fullstack parameter")' #14:
commit dba04eb76df982703fefc021a4d278347b6176a9

-:20: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")' #20:
commit e966eaeeb623f09975ef362c2866fae6f86844f9

-:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #43:
new file mode 100644

-:619: WARNING:TYPO_SPELLING: 'prefered' may be misspelled - perhaps 'preferred'? #619: FILE: Documentation/locking/crossrelease.txt:572:
+deadlock or its possibility sooner. So the former way would be prefered

-:791: WARNING:TYPO_SPELLING: 'implmentation' may be misspelled - perhaps 'implementation'? #791: FILE: Documentation/locking/crossrelease.txt:744:
+like how lockdep handles held_locks. Lockless implmentation is important

-:814: WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'? #814: FILE: Documentation/locking/crossrelease.txt:767:
+that it has not occured yet, lockdep should consider all possible

-:961: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #961: FILE: include/linux/completion.h:53:
+#define init_completion_map(x, m) \
+do { \
+ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
+ (m)->name, (m)->key, 0); \
+ __init_completion(x); \
+} while (0)

-:961: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects? #961: FILE: include/linux/completion.h:53:
+#define init_completion_map(x, m) \
+do { \
+ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
+ (m)->name, (m)->key, 0); \
+ __init_completion(x); \
+} while (0)

-:968: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #968: FILE: include/linux/completion.h:60:
+#define init_completion(x) \
+do { \
+ static struct lock_class_key __key; \
+ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
+ "(completion)" #x, \
+ &__key, 0); \
+ __init_completion(x); \
+} while (0)

-:985: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'work' - possible side-effects? #985: FILE: include/linux/completion.h:77:
+#define COMPLETION_INITIALIZER(work) \
+ { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \
+ STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) }

-:1083: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #1083: FILE: include/linux/lockdep.h:310:
+ * Seperate stack_trace data. This will be used at commit step.

-:1089: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #1089: FILE: include/linux/lockdep.h:316:
+ * Seperate hlock instance. This will be used at commit step.

-:1117: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #1117: FILE: include/linux/lockdep.h:344:
+ * Seperate hlock instance. This will be used at commit step.

-:1140: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1140: FILE: include/linux/lockdep.h:561:
+extern void lockdep_init_map_crosslock(struct lockdep_map *lock,

-:1144: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1144: FILE: include/linux/lockdep.h:565:
+extern void lock_commit_crosslock(struct lockdep_map *lock);

-:1164: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1164: FILE: include/linux/lockdep.h:585:
+extern void crossrelease_hist_start(enum xhlock_context_t c);

-:1165: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1165: FILE: include/linux/lockdep.h:586:
+extern void crossrelease_hist_end(enum xhlock_context_t c);

-:1166: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1166: FILE: include/linux/lockdep.h:587:
+extern void lockdep_invariant_state(bool force);

-:1167: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1167: FILE: include/linux/lockdep.h:588:
+extern void lockdep_init_task(struct task_struct *task);

-:1168: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #1168: FILE: include/linux/lockdep.h:589:
+extern void lockdep_free_task(struct task_struct *task);

-:1283: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1283: FILE: kernel/locking/lockdep.c:1158:
+ printk(" Possible unsafe locking scenario by crosslock:\n\n");

-:1284: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1284: FILE: kernel/locking/lockdep.c:1159:
+ printk(" CPU0 CPU1\n");

-:1285: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1285: FILE: kernel/locking/lockdep.c:1160:
+ printk(" ---- ----\n");

-:1286: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1286: FILE: kernel/locking/lockdep.c:1161:
+ printk(" lock(");

-:1288: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1288: FILE: kernel/locking/lockdep.c:1163:
+ printk(KERN_CONT ");\n");

-:1288: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1288: FILE: kernel/locking/lockdep.c:1163:
+ printk(KERN_CONT ");\n");

-:1289: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1289: FILE: kernel/locking/lockdep.c:1164:
+ printk(" lock(");

-:1291: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1291: FILE: kernel/locking/lockdep.c:1166:
+ printk(KERN_CONT ");\n");

-:1291: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1291: FILE: kernel/locking/lockdep.c:1166:
+ printk(KERN_CONT ");\n");

-:1292: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1292: FILE: kernel/locking/lockdep.c:1167:
+ printk(" lock(");

-:1294: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1294: FILE: kernel/locking/lockdep.c:1169:
+ printk(KERN_CONT ");\n");

-:1294: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1294: FILE: kernel/locking/lockdep.c:1169:
+ printk(KERN_CONT ");\n");

-:1295: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1295: FILE: kernel/locking/lockdep.c:1170:
+ printk(" unlock(");

-:1297: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1297: FILE: kernel/locking/lockdep.c:1172:
+ printk(KERN_CONT ");\n");

-:1297: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1297: FILE: kernel/locking/lockdep.c:1172:
+ printk(KERN_CONT ");\n");

-:1298: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1298: FILE: kernel/locking/lockdep.c:1173:
+ printk("\n *** DEADLOCK ***\n\n");

-:1300: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1300: FILE: kernel/locking/lockdep.c:1175:
+ printk(" Possible unsafe locking scenario:\n\n");

-:1301: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1301: FILE: kernel/locking/lockdep.c:1176:
+ printk(" CPU0 CPU1\n");

-:1302: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1302: FILE: kernel/locking/lockdep.c:1177:
+ printk(" ---- ----\n");

-:1303: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1303: FILE: kernel/locking/lockdep.c:1178:
+ printk(" lock(");

-:1305: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1305: FILE: kernel/locking/lockdep.c:1180:
+ printk(KERN_CONT ");\n");

-:1305: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1305: FILE: kernel/locking/lockdep.c:1180:
+ printk(KERN_CONT ");\n");

-:1306: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1306: FILE: kernel/locking/lockdep.c:1181:
+ printk(" lock(");

-:1308: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1308: FILE: kernel/locking/lockdep.c:1183:
+ printk(KERN_CONT ");\n");

-:1308: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1308: FILE: kernel/locking/lockdep.c:1183:
+ printk(KERN_CONT ");\n");

-:1309: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1309: FILE: kernel/locking/lockdep.c:1184:
+ printk(" lock(");

-:1311: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1311: FILE: kernel/locking/lockdep.c:1186:
+ printk(KERN_CONT ");\n");

-:1311: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1311: FILE: kernel/locking/lockdep.c:1186:
+ printk(KERN_CONT ");\n");

-:1312: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1312: FILE: kernel/locking/lockdep.c:1187:
+ printk(" lock(");

-:1314: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ... #1314: FILE: kernel/locking/lockdep.c:1189:
+ printk(KERN_CONT ");\n");

-:1314: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible #1314: FILE: kernel/locking/lockdep.c:1189:
+ printk(KERN_CONT ");\n");

-:1315: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level #1315: FILE: kernel/locking/lockdep.c:1190:
+ printk("\n *** DEADLOCK ***\n\n");

-:1411: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1411: FILE: kernel/locking/lockdep.c:3287:
+void lockdep_init_map_crosslock(struct lockdep_map *lock, const char *name,
+ struct lock_class_key *key, int subclass)

-:1796: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1796: FILE: kernel/locking/lockdep.c:4945:
+ if (nr_stack_trace_entries >= MAX_STACK_TRACE_ENTRIES-1) {
^

-:1823: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1823: FILE: kernel/locking/lockdep.c:4972:
+ if (!add_chain_cache_classes(xid, pid, xhlock->hlock.irq_context,
+ chain_key))

-:1958: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*task->xhlocks)...) over kzalloc(sizeof(struct hist_lock)...) #1958: FILE: kernel/locking/lockdep.c:5107:
+ task->xhlocks = kzalloc(sizeof(struct hist_lock) * MAX_XHLOCKS_NR,

-:1966: WARNING:TYPO_SPELLING: 'Diable' may be misspelled - perhaps 'Disable'? #1966: FILE: kernel/locking/lockdep.c:5115:
+ /* Diable crossrelease for current */

-:2038: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <[email protected]>'

total: 3 errors, 41 warnings, 15 checks, 1947 lines checked 2ce40a1c1f3e kthread: finer-grained lockdep/cross-release completion -:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #47: FILE: include/linux/kthread.h:11:
+struct task_struct *_kthread_create_on_node(int (*threadfn)(void *data),
void *data,

-:68: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #68: FILE: include/linux/kthread.h:39:
+struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data),
void *data,

-:106: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #106: FILE: include/linux/kthread.h:206:
+_kthread_create_worker_on_cpu(int cpu, unsigned int flags,
+ struct lock_class_key *exited_key,

-:137: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #137: FILE: kernel/kthread.c:234:
+ lockdep_init_map_crosslock(&self->exited.map.map,
+ "(kthread completion)->exited",

-:137: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kthread', this function's name, in a string #137: FILE: kernel/kthread.c:234:
+ "(kthread completion)->exited",

-:141: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #141: FILE: kernel/kthread.c:238:
+ lockdep_init_map_crosslock(&self->parked.map.map,
+ "(kthread completion)->parked",

-:141: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kthread', this function's name, in a string #141: FILE: kernel/kthread.c:238:
+ "(kthread completion)->parked",

-:207: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #207: FILE: kernel/kthread.c:454:
+struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data),
void *data, unsigned int cpu,

-:295: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <[email protected]>'

total: 0 errors, 3 warnings, 6 checks, 240 lines checked
61785e43c2dc lockdep: Remove GFP_NOLOCKDEP annotation
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7e7844226f10 ("lockdep: allow to disable reclaim lockup detection")' #6:
This was originally added in 7e7844226f10 ("lockdep: allow to disable

-:69: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <[email protected]>'

total: 1 errors, 1 warnings, 0 checks, 32 lines checked cde527c93a7e mm: Check if mmut notifier callbacks are allowed to fail -:19: ERROR:SPACING: space required after that ',' (ctx:VxV) #19: FILE: mm/mmu_notifier.c:193:
+ WARN(blockable,"%pS callback failure not allowed\n",
^

-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <[email protected]>'

total: 1 errors, 1 warnings, 0 checks, 8 lines checked
39f75ea012b8 mm, notifier: Catch sleeping/blocking for !blockable
-:30: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
ec2c4fd67467 mm, notifier: Add a lockdep map for invalidate_range_start
-:73: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <[email protected]>'

total: 0 errors, 1 warnings, 0 checks, 34 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✗ Fi.CI.SPARSE: warning for attempts at catching mmu_notifer deadlocks

In reply to Daniel Vetter
== Series Details ==

== Series Details ==

Series: attempts at catching mmu_notifer deadlocks
URL : https://patchwork.freedesktop.org/series/51522/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: locking/lockdep: restore cross-release checks
+
+Error in reading or end of file.

Commit: kthread: finer-grained lockdep/cross-release completion Okay!

Commit: lockdep: Remove GFP_NOLOCKDEP annotation
Okay!

Commit: mm: Check if mmut notifier callbacks are allowed to fail Okay!

Commit: mm, notifier: Catch sleeping/blocking for !blockable Okay!

Commit: mm, notifier: Add a lockdep map for invalidate_range_start Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw

✓ Fi.CI.BAT: success for attempts at catching mmu_notifer deadlocks

In reply to Daniel Vetter
== Series Details ==

== Series Details ==

Series: attempts at catching mmu_notifer deadlocks
URL : https://patchwork.freedesktop.org/series/51522/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_5037 -> Patchwork_10579 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/51522/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_10579 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_switch@basic-default:
      fi-icl-u:           NOTRUN -> DMESG-FAIL (fdo#108535)

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106097)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    
    ==== Possible fixes ====

    igt@kms_busy@basic-flip-c:
      fi-glk-j4005:       DMESG-WARN (fdo#106000) -> PASS

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       FAIL (fdo#100368) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-glk-j4005:       FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362, fdo#103191) -> PASS

fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108535 https://bugs.freedesktop.org/show_bug.cgi?id=108535

== Participating hosts (46 -> 44) ==

Additional (1): fi-icl-u
Missing (3): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan

== Build changes ==

* Linux: CI_DRM_5037 -> Patchwork_10579

CI_DRM_5037: e11750586cb6054bd319ad217cecd045febaacc5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4694: ff8d1156723f235e82cb4fcfd2cd6e5a5bb211fa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10579: ec2c4fd6746769bb239e484c39f4d0c551765ee5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ec2c4fd67467 mm, notifier: Add a lockdep map for invalidate_range_start 39f75ea012b8 mm, notifier: Catch sleeping/blocking for !blockable cde527c93a7e mm: Check if mmut notifier callbacks are allowed to fail 61785e43c2dc lockdep: Remove GFP_NOLOCKDEP annotation 2ce40a1c1f3e kthread: finer-grained lockdep/cross-release completion 13ea12ad517b locking/lockdep: restore cross-release checks

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10579/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✗ Fi.CI.IGT: failure for attempts at catching mmu_notifer deadlocks

In reply to Daniel Vetter
== Series Details ==

== Series Details ==

Series: attempts at catching mmu_notifer deadlocks
URL : https://patchwork.freedesktop.org/series/51522/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_5037_full -> Patchwork_10579_full =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10579_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10579_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10579_full:

=== IGT changes ===

    ==== Possible regressions ====

    igt@gem_userptr_blits@dmabuf-sync:
      shard-kbl:          PASS -> DMESG-WARN +9

    igt@gem_userptr_blits@map-fixed-invalidate-busy:
      shard-glk:          PASS -> DMESG-WARN +6

    igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
      shard-apl:          PASS -> DMESG-WARN +6
      shard-skl:          PASS -> DMESG-WARN +5

    igt@gem_userptr_blits@sync-unmap-after-close:
      shard-hsw:          PASS -> DMESG-WARN +6

    igt@gem_userptr_blits@sync-unmap-cycles:
      shard-snb:          PASS -> DMESG-WARN +9
      shard-skl:          NOTRUN -> DMESG-WARN +1

    igt@kms_flip_tiling@flip-to-yf-tiled:
      shard-skl:          NOTRUN -> FAIL

== Known issues ==

Here are the changes found in Patchwork_10579_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_userptr_blits@readonly-unsync:
      shard-skl:          PASS -> INCOMPLETE (fdo#108074)

    igt@kms_busy@extended-modeset-hang-newfb-render-a:
      shard-skl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
      shard-hsw:          PASS -> DMESG-WARN (fdo#107956)

    igt@kms_chv_cursor_fail@pipe-b-64x64-right-edge:
      shard-apl:          PASS -> DMESG-WARN (fdo#108549) +19

    igt@kms_color@pipe-a-degamma:
      shard-apl:          PASS -> FAIL (fdo#108145, fdo#104782)

    igt@kms_color@pipe-b-degamma:
      shard-apl:          PASS -> FAIL (fdo#104782)

    igt@kms_cursor_crc@cursor-128x128-random:
      shard-apl:          PASS -> FAIL (fdo#103232) +6

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-apl:          PASS -> FAIL (fdo#103232, fdo#103191)

    igt@kms_cursor_crc@cursor-256x256-random:
      shard-skl:          NOTRUN -> FAIL (fdo#103232)

    igt@kms_cursor_crc@cursor-256x256-sliding:
      shard-glk:          PASS -> FAIL (fdo#103232) +5

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#106538, fdo#105763)

    igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled:
      shard-skl:          NOTRUN -> FAIL (fdo#103184)

    igt@kms_flip_tiling@flip-changes-tiling-yf:
      shard-skl:          PASS -> FAIL (fdo#108303, fdo#108228)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-glk:          PASS -> FAIL (fdo#103167) +7

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-apl:          PASS -> FAIL (fdo#103167) +3

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
      shard-skl:          NOTRUN -> FAIL (fdo#105682)

    igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
      shard-skl:          NOTRUN -> FAIL (fdo#103167) +2

    igt@kms_plane@pixel-format-pipe-c-planes:
      shard-skl:          NOTRUN -> DMESG-FAIL (fdo#106885, fdo#103166)

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
      shard-skl:          PASS -> INCOMPLETE (fdo#107773, fdo#104108)

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-glk:          PASS -> FAIL (fdo#103166)

    igt@kms_plane@plane-position-covered-pipe-c-planes:
      shard-apl:          PASS -> FAIL (fdo#103166) +2

    igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
      shard-skl:          NOTRUN -> FAIL (fdo#108145) +2

    igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
      shard-skl:          NOTRUN -> FAIL (fdo#107815, fdo#108145)

    igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
      shard-glk:          PASS -> FAIL (fdo#108145)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
      shard-skl:          NOTRUN -> FAIL (fdo#107815, fdo#103166)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@kms_universal_plane@universal-plane-pipe-c-functional:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@pm_backlight@fade_with_suspend:
      shard-skl:          NOTRUN -> FAIL (fdo#107847)

    igt@pm_rpm@dpms-mode-unset-lpsp:
      shard-skl:          PASS -> INCOMPLETE (fdo#107807)

    
    ==== Possible fixes ====

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
      shard-apl:          DMESG-FAIL (fdo#108549) -> PASS +3

    igt@kms_atomic_transition@plane-all-modeset-transition:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
      shard-kbl:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
      shard-glk:          FAIL (fdo#108145) -> PASS

    igt@kms_color@pipe-b-ctm-blue-to-red:
      shard-apl:          DMESG-WARN (fdo#108549) -> PASS +21

    igt@kms_color@pipe-c-degamma:
      shard-apl:          FAIL (fdo#104782) -> PASS

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-apl:          FAIL (fdo#103232) -> PASS +3

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
      shard-glk:          FAIL (fdo#103167) -> PASS +6

    igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
      shard-skl:          FAIL (fdo#103167) -> PASS +1

    igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
      shard-skl:          FAIL (fdo#107815, fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          FAIL (fdo#103166) -> PASS +1

    igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
      shard-apl:          FAIL (fdo#103166) -> PASS

    igt@pm_rpm@basic-pci-d3-state:
      shard-skl:          INCOMPLETE (fdo#107807) -> PASS

    
    ==== Warnings ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          FAIL (fdo#106641) -> DMESG-FAIL (fdo#108549)

    igt@kms_cursor_crc@cursor-64x21-sliding:
      shard-apl:          FAIL (fdo#103232) -> DMESG-WARN (fdo#108549) +1

    igt@pm_rpm@gem-mmap-cpu:
      shard-apl:          DMESG-WARN (fdo#108549) -> INCOMPLETE (fdo#103927)

fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107847 https://bugs.freedesktop.org/show_bug.cgi?id=107847
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108228 https://bugs.freedesktop.org/show_bug.cgi?id=108228
fdo#108303 https://bugs.freedesktop.org/show_bug.cgi?id=108303
fdo#108549 https://bugs.freedesktop.org/show_bug.cgi?id=108549
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (6 -> 6) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_5037 -> Patchwork_10579

CI_DRM_5037: e11750586cb6054bd319ad217cecd045febaacc5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4694: ff8d1156723f235e82cb4fcfd2cd6e5a5bb211fa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10579: ec2c4fd6746769bb239e484c39f4d0c551765ee5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10579/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx