Staging: rts5208: Capitalise preprocessor variable names
PATCH v2 1/1 Staging: rts5208: Capitalise preprocessor variable names
Capitalise header preprocesser variable names (and all occurences) to remove checkpatch camelcase warnings.
v2: Left some camel-case uses (namely xD) - they may refer to xD picture cards, as suggested by Julia Lawall <[email protected]>
--- drivers/staging/rts5208/xd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rts5208/xd.h +1 -1
@@ -90,7 +90,7 @@#define NO_OFFSET 0x0#define WITH_OFFSET 0x1 -#define Sect_Per_Page 4 +#define SECT_PER_PAGE 4#define XD_ADDR_MODE_2C XD_ADDR_MODE_2A#define ZONE0_BAD_BLOCK 23
Signature · 1 line
2.19.1
Quoted 5 lines · Kim Bradley
Capitalise header preprocesser variable names (and all occurences) to remove checkpatch camelcase warnings.
v2: Left some camel-case uses (namely xD) - they may refer to xD picture cards, as suggested by Julia Lawall <[email protected]>
The v2 discussion goes under the ---, not above it. The part above the --- goes in the commit history, but the previous versions do not. The discussion of previous versions will be meaningless in the commit history. On the other hand, the part between the --- and the diff is only visible in the mail thread and will be dropped when the patch is applied. So it's fine to put whatever you want there.
julia
Quoted 29 lines
Signed-off-by Kim Bradley <[email protected]>--- drivers/staging/rts5208/xd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rts5208/xd.h +1
-2@@ -90,7 +90,7 @@#define NO_OFFSET 0x0#define WITH_OFFSET 0x1 -#define Sect_Per_Page 4 +#define SECT_PER_PAGE 4#define XD_ADDR_MODE_2C XD_ADDR_MODE_2A#define ZONE0_BAD_BLOCK 23 --2.19.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181025163303.GA6666%40xubuntu-vm.
For more options, visit https://groups.google.com/d/optout.