Skip to contentSkip to conversation

arm64: dts: qcom: sdm845: Fix pcs_misc region address for UNI PHY

PATCH In review Manu Gautam 3 participants 3 messages Oct 25, 2018 – Oct 26, 2018

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Manu Gautam

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sdm845: Fix pcs_misc region address for UNI PHY

Correct address for pcs_misc register region of USB3 QMP UNI PHY. These registers are used during runtime-suspend/resume routines of phy.

Fixes ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes")
Signed-off-by Manu Gautam <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +1 -1
index b72bdb0a31a5..84bee81562a5 100644
@@ -1156,7 +1156,7 @@
 				reg = <0x88eb200 0x128>,
 				      <0x88eb400 0x1fc>,
 				      <0x88eb800 0x218>,
-				      <0x88e9600 0x70>;
+				      <0x88eb600 0x70>;
 				#phy-cells = <0>;
 				clocks = <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>;
 				clock-names = "pipe0";
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 16 lines · Manu Gautam

Correct address for pcs_misc register region of USB3 QMP UNI PHY. These registers are used during runtime-suspend/resume routines of phy.

Fixes ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes")
Signed-off-by Manu Gautam <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +0 -0
index b72bdb0a31a5..84bee81562a5 100644

arch/arm64/boot/dts/qcom/sdm845.dtsi line 1159

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +1 -1
@@ -1156,7 +1156,7 @@
                                reg = <0x88eb200 0x128>,
                                      <0x88eb400 0x1fc>,
                                      <0x88eb800 0x218>,
-                                     <0x88e9600 0x70>;
+                                     <0x88eb600 0x70>;

Whoops, sorry for not noticing this earlier. Thanks for the fix!

Evan's most recent patch to the bindings [1] should also be fixed eventually too. It feels like those patches have gone through enough spins though, so maybe we can just post this fix atop those?

Reviewed-by Douglas Anderson <[email protected]>

[1] https://lkml.kernel.org/r/[email protected]

#2 lore raw
Quoted 27 lines · Doug Anderson

Hi,

Quoted 16 lines · Manu Gautam

Correct address for pcs_misc register region of USB3 QMP UNI PHY. These registers are used during runtime-suspend/resume routines of phy.

Fixes ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes")
Signed-off-by Manu Gautam <[email protected]>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845.dtsi +0 -0
index b72bdb0a31a5..84bee81562a5 100644

arch/arm64/boot/dts/qcom/sdm845.dtsi line 1159

Quoted 5 lines
arch/arm64/boot/dts/qcom/sdm845.dtsi +1 -1
@@ -1156,7 +1156,7 @@
                                reg = <0x88eb200 0x128>,
                                      <0x88eb400 0x1fc>,
                                      <0x88eb800 0x218>,
-                                     <0x88e9600 0x70>;
+                                     <0x88eb600 0x70>;

Whoops, sorry for not noticing this earlier. Thanks for the fix!

Quoted 7 lines

Evan's most recent patch to the bindings [1] should also be fixed eventually too. It feels like those patches have gone through enough spins though, so maybe we can just post this fix atop those?

Reviewed-by Douglas Anderson <[email protected]>

[1] https://lkml.kernel.org/r/[email protected]

I'll spin mine. Incoming!