Skip to contentSkip to conversation

generic: update group file to indicate generic/456 uses {collapse,zero}_range

PATCH In review Theodore Ts'o 4 participants 4 messages Oct 26, 2018 – Oct 28, 2018

lore
Share & tools
lore

Theodore Ts'o

author
#0 lore raw

PATCH 1/1 generic: update group file to indicate generic/456 uses {collapse,zero}_range

Signed-off-by Theodore Ts'o <[email protected]>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/group +1 -1
index 28452732..8a21970e 100644
@@ -458,7 +458,7 @@
 453 auto quick dir
 454 auto quick attr
 455 auto log replay
-456 auto quick metadata
+456 auto quick metadata collapse zero
 457 auto log replay clone
 458 auto quick clone collapse zero
 459 auto thin
Signature · 1 line
2.18.0.rc0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Theodore Ts'o
Signed-off-by Theodore Ts'o <[email protected]>

---

Reviewed-by Bill O'Donnell <[email protected]>
Quoted 19 lines
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/group +1 -1
index 28452732..8a21970e 100644
@@ -458,7 +458,7 @@
 453 auto quick dir
 454 auto quick attr
 455 auto log replay
-456 auto quick metadata
+456 auto quick metadata collapse zero
 457 auto log replay clone
 458 auto quick clone collapse zero
 459 auto thin
Signature · 1 line
2.18.0.rc0
#2 lore raw
In reply to Theodore Ts'o
Quoted 11 lines · Theodore Ts'o
Signed-off-by Theodore Ts'o <[email protected]>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/group +0 -0
index 28452732..8a21970e 100644

tests/generic/group line 461

Quoted 5 lines
tests/generic/group +1 -1
@@ -458,7 +458,7 @@
 453 auto quick dir
 454 auto quick attr
 455 auto log replay
-456 auto quick metadata
+456 auto quick metadata collapse zero

Since it uses fallocate too, should also be in the 'prealloc' group.

Thanks.

Quoted 6 lines
tests/generic/group +0 -1
 457 auto log replay clone
 458 auto quick clone collapse zero
 459 auto thin
--

2.18.0.rc0

Signature · 3 lines
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”
#3 lore raw
Quoted 7 lines · Filipe Manana
Quoted 6 lines · Theodore Ts'o
Signed-off-by Theodore Ts'o <[email protected]>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines

tests/generic/group line 461

Quoted 10 lines
tests/generic/group +1 -1
index 28452732..8a21970e 100644
@@ -458,7 +458,7 @@
 453 auto quick dir
 454 auto quick attr
 455 auto log replay
-456 auto quick metadata
+456 auto quick metadata collapse zero

Since it uses fallocate too, should also be in the 'prealloc' group.

I'll add it on commit, thanks for review!

Eryu

Quoted 15 lines

Thanks.

Quoted 6 lines
tests/generic/group +0 -1
 457 auto log replay clone
 458 auto quick clone collapse zero
 459 auto thin
--

2.18.0.rc0

Signature · 3 lines
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”