Skip to contentSkip to conversation

sending out trewide patches

Cocci Julia Lawall 2 participants 10 messages Oct 27, 2018 – Oct 30, 2018

lore
Share & tools
lore
#0 lore raw

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

julia

#1 lore raw
Quoted 11 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

Quoted 8 lines

splitpatch 0001-changes.patch

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Thanx, Paul

PS. And in case you didn't make it there... ;-)

https://www.spatchchicken.co.uk/
https://www.spatchchicken.co.uk/about-us.html

#2 lore raw
Quoted 21 lines · Paul E. McKenney
Quoted 11 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

Quoted 8 lines

splitpatch 0001-changes.patch

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Quoted 8 lines

Thank you, Julia! I will give it a try.

Thanx, Paul

PS. And in case you didn't make it there... ;-)

https://www.spatchchicken.co.uk/
https://www.spatchchicken.co.uk/about-us.html

Amazing. Thanks!

julia

#3 lore raw
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

#4 lore raw
Quoted 33 lines · Paul E. McKenney
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

Quoted 8 lines

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

I'm not familiar with that. I assume you started with the github version of Coccinelle. Then ./autogen and ./configure. Then make. A recent version of OCaml would indeed be good. Maybe running make distclean before ./autogen would be good. The inconsistencies suggest that you have some old compiled code hanging around. The build infrastructure has changed a lot recently, so it might not be managing code that predates the changes in a way that you would expect.

julia

#5 lore raw
Quoted 46 lines · Julia Lawall
Quoted 33 lines · Paul E. McKenney
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

Quoted 8 lines

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

Quoted 7 lines

I'm not familiar with that. I assume you started with the github version of Coccinelle. Then ./autogen and ./configure. Then make. A recent version of OCaml would indeed be good. Maybe running make distclean before ./autogen would be good. The inconsistencies suggest that you have some old compiled code hanging around. The build infrastructure has changed a lot recently, so it might not be managing code that predates the changes in a way that you would expect.

Good point, that does work much better. Now -this- error message seems to be me having an old ocaml:

ocamlfind ocamlopt -c -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
ocamlopt: unknown option `-no-alias-deps'.

Will get a new one and see how it goes... ;-)

Thanx, Paul

#6 lore raw
Quoted 55 lines · Paul E. McKenney
Quoted 46 lines · Julia Lawall
Quoted 33 lines · Paul E. McKenney
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

Quoted 8 lines

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

Quoted 7 lines

I'm not familiar with that. I assume you started with the github version of Coccinelle. Then ./autogen and ./configure. Then make. A recent version of OCaml would indeed be good. Maybe running make distclean before ./autogen would be good. The inconsistencies suggest that you have some old compiled code hanging around. The build infrastructure has changed a lot recently, so it might not be managing code that predates the changes in a way that you would expect.

Quoted 7 lines

Good point, that does work much better. Now -this- error message seems to be me having an old ocaml:

ocamlfind ocamlopt -c -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
ocamlopt: unknown option `-no-alias-deps'.

Will get a new one and see how it goes... ;-)

What version do you have? I thought that the makefile would detect unsupported versions, so perhaps that check needs to be improved.

julia

#7 lore raw
Quoted 62 lines · Julia Lawall
Quoted 58 lines · Paul E. McKenney
Quoted 46 lines · Julia Lawall
Quoted 33 lines · Paul E. McKenney
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

Quoted 8 lines

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

Quoted 7 lines

I'm not familiar with that. I assume you started with the github version of Coccinelle. Then ./autogen and ./configure. Then make. A recent version of OCaml would indeed be good. Maybe running make distclean before ./autogen would be good. The inconsistencies suggest that you have some old compiled code hanging around. The build infrastructure has changed a lot recently, so it might not be managing code that predates the changes in a way that you would expect.

Good point, that does work much better. Now -this- error message seems to be me having an old ocaml:

Quoted 7 lines
Quoted 4 lines

ocamlfind ocamlopt -c -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
ocamlopt: unknown option `-no-alias-deps'.

Will get a new one and see how it goes... ;-)

What version do you have? I thought that the makefile would detect unsupported versions, so perhaps that check needs to be improved.

I am running 4.0.3 and now installing 4.0.5.

Thanx, Paul

#8 lore raw
Quoted 66 lines · Paul E. McKenney
Quoted 65 lines · Julia Lawall
Quoted 61 lines · Paul E. McKenney
Quoted 46 lines · Julia Lawall
Quoted 33 lines · Paul E. McKenney
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

Quoted 8 lines

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

Quoted 7 lines

I'm not familiar with that. I assume you started with the github version of Coccinelle. Then ./autogen and ./configure. Then make. A recent version of OCaml would indeed be good. Maybe running make distclean before ./autogen would be good. The inconsistencies suggest that you have some old compiled code hanging around. The build infrastructure has changed a lot recently, so it might not be managing code that predates the changes in a way that you would expect.

Good point, that does work much better. Now -this- error message seems to be me having an old ocaml:

ocamlfind ocamlopt -c -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
ocamlopt: unknown option `-no-alias-deps'.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Will get a new one and see how it goes... ;-)

What version do you have? I thought that the makefile would detect unsupported versions, so perhaps that check needs to be improved.

I am running 4.0.3 and now installing 4.0.5.

But, sad to say, I get the same coccinelle build error on v4.0.5 ocaml.

Enlightenment?

Thanx, Paul

#9 lore raw
Quoted 67 lines · Paul E. McKenney
Quoted 66 lines · Paul E. McKenney
Quoted 65 lines · Julia Lawall
Quoted 61 lines · Paul E. McKenney
Quoted 46 lines · Julia Lawall
Quoted 33 lines · Paul E. McKenney
Quoted 18 lines · Julia Lawall
Quoted 14 lines · Paul E. McKenney
Quoted 13 lines · Julia Lawall

Hello,

At OSS Europe, I got some questions about how to send out large Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch (go to the tools subdirectory of the Coccinelle distribution and run make) that splits patches by set of maintainers (the default), by directory (--dirmerge option), or by file (--nomerge option). There is a file tools/splitpatch.README that explains the various ways that it can be used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

The output will include a 0001-changes.cover file, a set of 0001-changesN.patch files with the various split patches, and a 0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle. Comments are welcome.

Thank you, Julia! I will give it a try.

Does the following error message mean that I need a more up-to-date version of ocaml or some such?

Thanx, Paul

Quoted 8 lines

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
does not match the interface globals/config.cmi:
The field python_interpreter' is required but not provided The field ocaml_version' is required but not provided The field configure_flags' is required but not provided The field get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

Quoted 7 lines

I'm not familiar with that. I assume you started with the github version of Coccinelle. Then ./autogen and ./configure. Then make. A recent version of OCaml would indeed be good. Maybe running make distclean before ./autogen would be good. The inconsistencies suggest that you have some old compiled code hanging around. The build infrastructure has changed a lot recently, so it might not be managing code that predates the changes in a way that you would expect.

Good point, that does work much better. Now -this- error message seems to be me having an old ocaml:

ocamlfind ocamlopt -c -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
ocamlopt: unknown option `-no-alias-deps'.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Will get a new one and see how it goes... ;-)

What version do you have? I thought that the makefile would detect unsupported versions, so perhaps that check needs to be improved.

I am running 4.0.3 and now installing 4.0.5.

But, sad to say, I get the same coccinelle build error on v4.0.5 ocaml.

I'm not so familiar with the OCaml version numbering system. Mine is 4.06.0. I don't see anything like 4.0.5 at https://ocaml.org/releases/

A buzilla entry suggests that this option has existed since OCaml 4.02.1.

julia