Skip to contentSkip to conversation

regulator: bd718x7: add missing linux/of.h inclusion

PATCH In review Matti Vaittinen 2 participants 3 messages Sep 19, 2018 – Oct 29, 2018 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: bd718x7: add missing linux/of.h inclusion

0-Day tests found compilation error on x86. Driver won't compile on x86_64 as "of_match_ptr" is not found. Add missing include <linux/of.h>

---
 drivers/regulator/bd71837-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/bd71837-regulator.c +1 -0
index 9b5e1297902f..4fe519581235 100644
@@ -9,6 +9,7 @@
 #include <linux/kernel.h>
 #include <linux/mfd/rohm-bd718x7.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
Signature · 1 line
2.14.3
#1 lore raw

Hello Mark,

I see we got build warning from 0-Day tests. It seems to me the bd718x7.c file lacks of <linux/of.h> inclusion.

I am not sure what has happened as this include was added to bd71837.c file with commit

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09

The bd71837.c was later renamed to bd718x7.c with
commit

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/drivers/regulator?h=for-next&id=2ece646c90c5b45dd76c76ea207a3f3459f2c472

So I am not sure where this include got lost. (I did search for all log entries with my name and was not able to spot this change)
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/log/drivers/regulator?h=for-next&qt=grep&q=Vaittinen

Should I just create another patch to you where this inclusion is done again or is there some better way to handle this? Can you cherry pick or re-apply the commit

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?h=for-next&id=df43519eb706edfe951284a825642ce2e1d38d09

- even though the file was later renamed?

Br,
Matti Vaittinen

Signature · 4 lines
Matti Vaittinen
ROHM Semiconductors

~~~ "I don't think so," said Rene Descartes.  Just then, he vanished ~~~
maintainer
#2 lore raw
Quoted 3 lines · Matti Vaittinen

Should I just create another patch to you where this inclusion is done again or is there some better way to handle this? Can you cherry pick or re-apply the commit

Just send another patch, it's easiest.