riscv: fix trace_sys_exit hook
Subsystems (2)
PATCH 1/1 riscv: fix trace_sys_exit hook
Depends on:
http://lists.infradead.org/pipermail/linux-riscv/2018-October/001931.html
Why we don't have HAVE_SYSCALL_TRACEPOINTS in arch/riscv/Kconfig?
--- arch/riscv/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/kernel/ptrace.c +1 -1
@@ -120,6 +120,6 @@ void do_syscall_trace_exit(struct pt_regs *regs)#ifdef CONFIG_HAVE_SYSCALL_TRACEPOINTS if (test_thread_flag (TIF_SYSCALL_TRACEPOINT )) -trace_sys_exit (regs, regs->regs[0 ]); +trace_sys_exit (regs,regs_return_value (regs));#endif }
Signature · 1 line
2.17.2
Quoted 6 lines · David Abdurachmanov
Depends on:
http://lists.infradead.org/pipermail/linux-riscv/2018-October/001931.htmlWhy we don't have
HAVE_SYSCALL_TRACEPOINTSinarch/riscv/Kconfig?
I looked this morning into Documentation/trace/ftrace-design.rst again.
Of all the things the document describes we are only missing HAVE_SYSCALL_TRACEPOINTS in Kconfig, yet we already have it implemented in ptrace.c (+ this minor fix). Reading document, I think, we check all the boxes needed for HAVE_SYSCALL_TRACEPOINTS.
I assume it was just missed (?) and will do v2 later on.
david
Quoted 15 lines · david.abdurachmanov at gmail.com
Depends on:
http://lists.infradead.org/pipermail/linux-riscv/2018-October/001931.htmlWhy we don't have
HAVE_SYSCALL_TRACEPOINTSinarch/riscv/Kconfig?Signed-off-by David Abdurachmanov <[email protected]>--- arch/riscv/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/kernel/ptrace.c +0
-0
arch/riscv/kernel/ptrace.c void do_syscall_trace_exit(struct pt_regs *regs) · line 125
Quoted 7 lines
arch/riscv/kernel/ptrace.c +1
-1@@ -120,6 +120,6 @@ void do_syscall_trace_exit(struct pt_regs *regs)#ifdef CONFIG_HAVE_SYSCALL_TRACEPOINTS if (test_thread_flag (TIF_SYSCALL_TRACEPOINT )) -trace_sys_exit (regs, regs->regs[0 ]); +trace_sys_exit (regs,regs_return_value (regs));#endif }
I'm dropping this onto next-audit on top of the other two.
Thanks!