Btrfs: remove no longer used logged range variables when logging extents
PATCH 1/1 Btrfs: remove no longer used logged range variables when logging extents
From: Filipe Manana <[email protected]>
The logged_start and logged_end variables, at btrfs_log_changed_extents(), were added in commit 8c6c592831a0 ("btrfs: log csums for all modified extents"). However since the recent simplification for fsync, which makes us wait for all ordered extents to complete before logging extents, we no longer need those variables. Commit a2120a473a80 ("btrfs: clean up the left over logged_list usage") forgot to remove them.
--- fs/btrfs/tree-log.c | 8 -------- 1 file changed, 8 deletions(-)
fs/btrfs/tree-log.c +0 -8
@@ -4383,7 +4383,6 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans,struct extent_map *em, *n;struct list_head extents;struct extent_map_tree *tree = &inode->extent_tree; -u64 logged_start, logged_end;u64 test_gen;int ret =0 ;int num =0 ;
@@ -4393,8 +4392,6 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans,down_write (&inode->dio_sem);write_lock (&tree->lock); test_gen = root->fs_info->last_trans_committed; - logged_start = start; - logged_end = end;list_for_each_entry_safe (em, n, &tree->modified_extents, list) {list_del_init (&em->list);
@@ -4418,11 +4415,6 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans, em->start >= i_size_read(&inode->vfs_inode))continue ; -if (em->start < logged_start) - logged_start = em->start; -if ((em->start + em->len -1 ) > logged_end) - logged_end = em->start + em->len -1 ; -/* Need a ref to keep it from getting evicted from cache */ refcount_inc (&em->refs);set_bit (EXTENT_FLAG_LOGGING , &em->flags);
Signature · 1 line
2.11.0
Quoted 10 lines · On 26.10.18 г. 23:26 ч., [email protected] wrote:
From: Filipe Manana <[email protected]>
The
logged_startandlogged_endvariables, atbtrfs_log_changed_extents(), were added in commit8c6c592831a0("btrfs: log csums for all modified extents"). However since the recent simplification for fsync, which makes us wait for all ordered extents to complete before logging extents, we no longer need those variables. Commita2120a473a80("btrfs: clean up the left overlogged_listusage") forgot to remove them.Signed-off-by Filipe Manana <[email protected]>
Quoted 38 lines
--- fs/btrfs/tree-log.c | 8 -------- 1 file changed, 8 deletions(-)fs/btrfs/tree-log.c +0
-8@@ -4383,7 +4383,6 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans,struct extent_map *em, *n;struct list_head extents;struct extent_map_tree *tree = &inode->extent_tree; -u64 logged_start, logged_end;u64 test_gen;int ret =0 ;int num =0 ;@@ -4393,8 +4392,6 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans,down_write (&inode->dio_sem);write_lock (&tree->lock); test_gen = root->fs_info->last_trans_committed; - logged_start = start; - logged_end = end;list_for_each_entry_safe (em, n, &tree->modified_extents, list) {list_del_init (&em->list);@@ -4418,11 +4415,6 @@ static int btrfs_log_changed_extents(struct btrfs_trans_handle *trans, em->start >= i_size_read(&inode->vfs_inode))continue ; -if (em->start < logged_start) - logged_start = em->start; -if ((em->start + em->len -1 ) > logged_end) - logged_end = em->start + em->len -1 ; -/* Need a ref to keep it from getting evicted from cache */ refcount_inc (&em->refs);set_bit (EXTENT_FLAG_LOGGING , &em->flags);
Quoted 10 lines · On Fri, Oct 26, 2018 at 09:26:40PM +0100, [email protected] wrote:
From: Filipe Manana <[email protected]>
The
logged_startandlogged_endvariables, atbtrfs_log_changed_extents(), were added in commit8c6c592831a0("btrfs: log csums for all modified extents"). However since the recent simplification for fsync, which makes us wait for all ordered extents to complete before logging extents, we no longer need those variables. Commita2120a473a80("btrfs: clean up the left overlogged_listusage") forgot to remove them.Signed-off-by Filipe Manana <[email protected]>
Added to misc-next, thanks.