Skip to contentSkip to conversation

ARM: dts: fsl: Fix improperly quoted stdout-path values

PATCH New Rob Herring 2 participants 2 messages Oct 31, 2018 – Nov 4, 2018

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 ARM: dts: fsl: Fix improperly quoted stdout-path values

A quoted label reference doesn't expand to the node path and is taken as a literal string. Dropping the quotes can fix this unless the baudrate string is appended in which case we have to use the alias.

At least on VF610, the problem was masked by setting the console in bootargs. Use the alias syntax with baudrate parameter so we can drop setting the console in bootargs.

Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Mark Rutland <[email protected]>

---
v2:
- Fix missing closing quote in vf610m4-colibri.dts

 arch/arm/boot/dts/imx53-ppd.dts       | 2 +-
 arch/arm/boot/dts/vf610m4-colibri.dts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/imx53-ppd.dts +1 -1
index cdb90bee7b4a..f202396e3f2a 100644
@@ -55,7 +55,7 @@
 	};
 
 	chosen {
-		stdout-path = "&uart1:115200n8";
+		stdout-path = "serial0:115200n8";
 	};
 
 	memory at 70000000 {
arch/arm/boot/dts/vf610m4-colibri.dts +2 -2
index 41ec66a96990..ca6249558760 100644
@@ -50,8 +50,8 @@
 	compatible = "fsl,vf610m4";
 
 	chosen {
-		bootargs = "console=ttyLP2,115200 clk_ignore_unused init=/linuxrc rw";
-		stdout-path = "&uart2";
+		bootargs = "clk_ignore_unused init=/linuxrc rw";
+		stdout-path = "serial2:115200";
 	};
 
 	memory at 8c000000 {
Signature · 1 line
2.19.1
Applied
#1 lore raw

PATCH v2 1/1 ARM: dts: fsl: Fix improperly quoted stdout-path values

Quoted 8 lines · Rob Herring

A quoted label reference doesn't expand to the node path and is taken as a literal string. Dropping the quotes can fix this unless the baudrate string is appended in which case we have to use the alias.

At least on VF610, the problem was masked by setting the console in bootargs. Use the alias syntax with baudrate parameter so we can drop setting the console in bootargs.

Quoted 8 lines
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Mark Rutland <[email protected]>

Applied, thanks.