Skip to contentSkip to conversation

ARM: dts: imx6qdl-icore: Add missing stdout-path property

PATCH Superseded Shyam Saini 3 participants 4 messages Oct 18, 2018 – Oct 31, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: imx6qdl-icore: Add missing stdout-path property

This would help us to get early boot logs by passing "earlycon" to kernel bootargs.

Further, by adding this we don't have to depend on complex earlyprintk configs for early boot logs.

---
 arch/arm/boot/dts/imx6qdl-icore.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx6qdl-icore.dtsi +4 -0
index 9ce993776160..f5b8ea6f7ee9 100644
@@ -49,6 +49,10 @@
 		reg = <0x10000000 0x80000000>;
 	};
 
+	chosen {
+		stdout-path = &uart4;
+	};
+
 	backlight_lvds: backlight-lvds {
 		compatible = "pwm-backlight";
 		pwms = <&pwm3 0 100000>;
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/1 ARM: dts: imx6qdl-icore: Add missing stdout-path property

Quoted 8 lines · Shyam Saini

This would help us to get early boot logs by passing "earlycon" to kernel bootargs.

Further, by adding this we don't have to depend on complex earlyprintk configs for early boot logs.

minor nit: your S-o-b line should be the last thing you write. So it's

if John added the Reviewed-by tag and

if it was you.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#2 lore raw

PATCH v2 1/1 ARM: dts: imx6qdl-icore: Add missing stdout-path property

Quoted 17 lines · Uwe Kleine-K?nig
Quoted 8 lines · Shyam Saini

This would help us to get early boot logs by passing "earlycon" to kernel bootargs.

Further, by adding this we don't have to depend on complex earlyprintk configs for early boot logs.

minor nit: your S-o-b line should be the last thing you write. So it's

Quoted 7 lines

if John added the Reviewed-by tag and

if it was you.

Thanks a lot Uwe for your suggestion. I'll take care of this thing next time. @Shawn would you please make the minor change as suggested by Uwe.

#3 lore raw

PATCH v2 1/1 ARM: dts: imx6qdl-icore: Add missing stdout-path property

Quoted 21 lines · Shyam Saini
Quoted 19 lines · Uwe Kleine-K?nig
Quoted 8 lines · Shyam Saini

This would help us to get early boot logs by passing "earlycon" to kernel bootargs.

Further, by adding this we don't have to depend on complex earlyprintk configs for early boot logs.

minor nit: your S-o-b line should be the last thing you write. So it's

if John added the Reviewed-by tag and

Quoted 8 lines
Quoted 5 lines

if it was you.

Thanks a lot Uwe for your suggestion. I'll take care of this thing next time. @Shawn would you please make the minor change as suggested by Uwe.

Applied with the suggested change, thanks.