webkitgtk: add an option to control USE_GSTREAMER_GL
PATCH 1/1 webkitgtk: add an option to control USE_GSTREAMER_GL
This covers the case where GL/GLES is available (so -DENABLE_OPENGL=ON gets passed), which makes the webkitgtk build system assume GStreamer-GL is available, while actually it is not.
Also, providing an option to manually disable usage of GStremer-GL can help with certain target configurations in which using OpenGL for video handling might result in incorrect rendering.
This fixes some autobuilder failures like the following:
http://autobuild.buildroot.net/results/187796535af53ece426641ff7d88aabada281674
http://autobuild.buildroot.net/results/00c1a8ea23a99728a4f3f4478705f2383414ae41
--- package/webkitgtk/Config.in | 15 +++++++++++++++ package/webkitgtk/webkitgtk.mk | 7 +++++++ 2 files changed, 22 insertions(+)
package/webkitgtk/Config.in +15 -0
@@ -105,6 +105,21 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA This option pulls in all of the required dependencies to enable multimedia (video/audio) support. +if BR2_PACKAGE_WEBKITGTK_MULTIMEDIA + +config BR2_PACKAGE_WEBKITGTK_USE_GSTREAMER_GL + bool "use gstreamer-gl" + default y + depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL + select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL + help + Use the GStreamer GL elements for handling video content. + This is recommended as it improves performance of video + playback. In some target configurations incorrect rendering + might be produced, and disabling this option may help. + +endif + config BR2_PACKAGE_WEBKITGTK_WEBDRIVER bool "WebDriver support" help
package/webkitgtk/webkitgtk.mk +7 -0
@@ -95,4 +95,11 @@ WEBKITGTK_CONF_OPTS += -DENABLE_WAYLAND_TARGET=ON endif endif +ifeq ($(BR2_PACKAGE_WEBKITGTK_USE_GSTREAMER_GL),y) +WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=ON +WEBKITGTK_DEPENDENCIES += gst1-plugins-bad +else +WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF +endif + $(eval $(cmake-package))
Signature · 1 line
2.19.1
Thomas Petazzoni
AppliedPATCH 1/1 webkitgtk: add an option to control USE_GSTREAMER_GL
Hello,
Quoted 10 lines · Adrian Perez de Castro
This covers the case where GL/GLES is available (so -DENABLE_OPENGL=ON gets passed), which makes the webkitgtk build system assume GStreamer-GL is available, while actually it is not.
Also, providing an option to manually disable usage of GStremer-GL can help with certain target configurations in which using OpenGL for video handling might result in incorrect rendering.
This fixes some autobuilder failures like the following:
Quoted 8 lines
http://autobuild.buildroot.net/results/187796535af53ece426641ff7d88aabada281674
http://autobuild.buildroot.net/results/00c1a8ea23a99728a4f3f4478705f2383414ae41Signed-off-by Adrian Perez de Castro <[email protected]>--- package/webkitgtk/Config.in | 15 +++++++++++++++ package/webkitgtk/webkitgtk.mk | 7 +++++++ 2 files changed, 22 insertions(+)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 webkitgtk: add an option to control USE_GSTREAMER_GL
In reply to Adrian Perez de CastroQuoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Adrian" == Adrian Perez de Castro <[email protected]> writes:
This covers the case where GL/GLES is available (so -DENABLE_OPENGL=ON gets passed), which makes the webkitgtk build system assume GStreamer-GL is available, while actually it is not.
Also, providing an option to manually disable usage of GStremer-GL can help with certain target configurations in which using OpenGL for video handling might result in incorrect rendering.
Quoted 6 lines
This fixes some autobuilder failures like the following:
http://autobuild.buildroot.net/results/187796535af53ece426641ff7d88aabada281674
http://autobuild.buildroot.net/results/00c1a8ea23a99728a4f3f4478705f2383414ae41Signed-off-by Adrian Perez de Castro <[email protected]>
Committed to 2018.02.x and 2018.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard