Skip to contentSkip to conversation

x86: acpi: Remove redundant Offset (0x00)

PATCH New Andy Shevchenko 3 participants 4 messages Oct 31, 2018 – Nov 6, 2018 x86

lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 x86: acpi: Remove redundant Offset (0x00)

New ACPI assembler issues a warning:

board/intel/edison/dsdt.asl.tmp 13: Offset (0x00),
Remark 2158 - ^ Unnecessary/redundant use of Offset operator

Indeed, in the OperationRegion the offset is 0x00 by default.

Thus, drop unneeded Offset() use as suggested by ACPI assembler.

Signed-off-by Andy Shevchenko <[email protected]>
---
 arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 -
 arch/x86/include/asm/arch-quark/acpi/global_nvs.asl    | 1 -
 arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl  | 1 -
 3 files changed, 3 deletions(-)
arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl +0 -1
index 9b8d1895ee..aaf87f4735 100644
@@ -8,7 +8,6 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-	Offset (0x00),
 	PCNT, 8,	/* processor count */
 	IURE, 8,	/* internal UART enabled */
 }
arch/x86/include/asm/arch-quark/acpi/global_nvs.asl +0 -1
index 44b9f12c7c..61602173f8 100644
@@ -8,6 +8,5 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-	Offset (0x00),
 	PCNT, 8,	/* processor count */
 }
arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl +0 -1
index a6296c2cb6..895b807e96 100644
@@ -10,6 +10,5 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-    Offset (0x00),
     PCNT, 8,    /* processor count */
 }
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 x86: acpi: Remove redundant Offset (0x00)

Quoted 10 lines · Andy Shevchenko

New ACPI assembler issues a warning:

board/intel/edison/dsdt.asl.tmp 13: Offset (0x00),
Remark 2158 - ^ Unnecessary/redundant use of Offset operator

Indeed, in the OperationRegion the offset is 0x00 by default.

Thus, drop unneeded Offset() use as suggested by ACPI assembler.

Would be nice to have this in the release, since till now it produces the only warning at least in my case.

Quoted 48 lines
Signed-off-by Andy Shevchenko <[email protected]>
---
 arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 -
 arch/x86/include/asm/arch-quark/acpi/global_nvs.asl    | 1 -
 arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl  | 1 -
 3 files changed, 3 deletions(-)
arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl +0 -1
index 9b8d1895ee..aaf87f4735 100644
@@ -8,7 +8,6 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-       Offset (0x00),
        PCNT, 8,        /* processor count */
        IURE, 8,        /* internal UART enabled */
 }
arch/x86/include/asm/arch-quark/acpi/global_nvs.asl +0 -1
index 44b9f12c7c..61602173f8 100644
@@ -8,6 +8,5 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-       Offset (0x00),
        PCNT, 8,        /* processor count */
 }
arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl +0 -2
index a6296c2cb6..895b807e96 100644
@@ -10,6 +10,5 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-    Offset (0x00),
     PCNT, 8,    /* processor count */
 }
--

2.19.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

PATCH 1/1 x86: acpi: Remove redundant Offset (0x00)

In reply to Andy Shevchenko
Quoted 8 lines · Andy Shevchenko

New ACPI assembler issues a warning:

board/intel/edison/dsdt.asl.tmp 13: Offset (0x00),
Remark 2158 - ^ Unnecessary/redundant use of Offset operator

Indeed, in the OperationRegion the offset is 0x00 by default.

Quoted 9 lines

Thus, drop unneeded Offset() use as suggested by ACPI assembler.

Signed-off-by Andy Shevchenko <[email protected]>
---
 arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 -
 arch/x86/include/asm/arch-quark/acpi/global_nvs.asl    | 1 -
 arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl  | 1 -
 3 files changed, 3 deletions(-)
Reviewed-by Bin Meng <[email protected]>
#3 lore raw

PATCH 1/1 x86: acpi: Remove redundant Offset (0x00)

Quoted 20 lines · Bin Meng
Quoted 8 lines · Andy Shevchenko

New ACPI assembler issues a warning:

board/intel/edison/dsdt.asl.tmp 13: Offset (0x00),
Remark 2158 - ^ Unnecessary/redundant use of Offset operator

Indeed, in the OperationRegion the offset is 0x00 by default.

Quoted 9 lines

Thus, drop unneeded Offset() use as suggested by ACPI assembler.

Signed-off-by Andy Shevchenko <[email protected]>
---
 arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl | 1 -
 arch/x86/include/asm/arch-quark/acpi/global_nvs.asl    | 1 -
 arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl  | 1 -
 3 files changed, 3 deletions(-)
Quoted 1 line
Reviewed-by Bin Meng <[email protected]>

applied to u-boot-x86, thanks!