Skip to contentSkip to conversation

KVM: s390: add functions to (un)register GISC with GISA

PATCH Cornelia Huck 1 participant 1 message Oct 31, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 30 lines · On Wed, 31 Oct 2018 17:35:11 +0100 Pierre Morel <[email protected]> wrote:
Quoted 8 lines · Cornelia Huck
Quoted 1 line · On Wed, 31 Oct 2018 15:05:09 +0100 Pierre Morel <[email protected]> wrote:

On 25/10/2018 14:37, Michael Mueller wrote:

The isc space is very limited and has on top of that priority ordering; I don't know if the gisa firmware code does have isc-specific semantics as well.

Yes it does.

Quoted 12 lines
Quoted 11 lines

Not having it will simplify the code.

Review

Quoted 3 lines
(quoted diff) +3 -0
+
+	return gib->nisc;
+}  

hum.
Will nisc change ?
It is hard coded in the call to kvm_s390_gib_init(GAL_ISC)

Quoted 2 lines

Should the nisc maybe be explicitly tied to the adapter type? Or is that a global thing? If yes, does this need any differentiation?

It is global and do not need differentiation pro adapter.

Quoted 1 line
Quoted 6 lines
Quoted 2 lines

IIRC, the aiv is a general "adapter interrupt virtualization" facility, so different adapter types may be present.

Yes, and it is easier if the host use the same host ISC value for all of them.
After all the type of adapter is not important for the GIB

OK, thanks for clearing that up. I believe we should just go with GAL_ISC directly in that case.

Quoted 12 lines
Quoted 10 lines
Quoted 9 lines

the NISC is a global value, if the only way to retrieve it is to register we need to keep it local in the space of the registering caller. I mean, registering to the GIB alert and registering an interruption are two different things and can be done in different functions.

Shouldn't we just need the GAL_ISC definition?