Skip to contentSkip to conversation

mmc: tmio: delete wait in tuning process

PATCH In review Niklas Söderlund 4 participants 5 messages Nov 1, 2018 – Nov 19, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: tmio: delete wait in tuning process

From: Masaharu Hayakawa <[email protected]>

The manual does not contain information that a wait is needed in the tuning process, this might be a leftover from early development. Removing the wait don't have any effect on operation so delete the wait to shorten the initialization time.

---
 drivers/mmc/host/tmio_mmc_core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/mmc/host/tmio_mmc_core.c +0 -2
index 8d64f6196f33e882..a8f917f744fb9f63 100644
@@ -734,8 +734,6 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode)
 		ret = mmc_send_tuning(mmc, opcode, NULL);
 		if (ret == 0)
 			set_bit(i, host->taps);
-
-		usleep_range(1000, 1200);
 	}
 
 	ret = host->select_tuning(host);
Signature · 1 line
2.19.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Niklas Söderlund

From: Masaharu Hayakawa <[email protected]>

The manual does not contain information that a wait is needed in the tuning process, this might be a leftover from early development. Removing the wait don't have any effect on operation so delete the wait to shorten the initialization time.

Tested-by on v1 1/1
#2 lore raw
In reply to Niklas Söderlund
Quoted 11 lines · Niklas Söderlund

From: Masaharu Hayakawa <[email protected]>

The manual does not contain information that a wait is needed in the tuning process, this might be a leftover from early development. Removing the wait don't have any effect on operation so delete the wait to shorten the initialization time.

Reviewed-by on v1 1/1
#3 lore raw
In reply to Niklas Söderlund
Quoted 11 lines · Niklas Söderlund

From: Masaharu Hayakawa <[email protected]>

The manual does not contain information that a wait is needed in the tuning process, this might be a leftover from early development. Removing the wait don't have any effect on operation so delete the wait to shorten the initialization time.

#4 lore raw
In reply to Niklas Söderlund
Quoted 11 lines · Niklas Söderlund

From: Masaharu Hayakawa <[email protected]>

The manual does not contain information that a wait is needed in the tuning process, this might be a leftover from early development. Removing the wait don't have any effect on operation so delete the wait to shorten the initialization time.

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/tmio_mmc_core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/mmc/host/tmio_mmc_core.c +0 -3
index 8d64f6196f33e882..a8f917f744fb9f63 100644
@@ -734,8 +734,6 @@ static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode)
                ret = mmc_send_tuning(mmc, opcode, NULL);
                if (ret == 0)
                        set_bit(i, host->taps);
-
-               usleep_range(1000, 1200);
        }
 
        ret = host->select_tuning(host);
--

2.19.1