arm64: dts: renesas: enable HS400 on R-Car Gen3
Subsystems (2)
PATCH 1/1 arm64: dts: renesas: enable HS400 on R-Car Gen3
From: Niklas Söderlund <[email protected]>
Successfully tested on H3 ES2.0 and M3-N ES1.0. Transfer rates where >160MB/s for H3 and >200MB/s for M3-N.
--- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 + arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 + 2 files changed, 2 insertions(+)
---
Hi Simon,
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
- [PATCH] mmc: renesas_sdhi: remove workaround for HS400 clock
- [PATCH v3 0/3] mmc: tmio: fix reset operation
- [PATCH v2 0/3] mmc: renesas_sdhi: extend quirk selection to handle ES revisions
- [PATCH 0/2] renesas: rcar-gen3: add HS400 quirk for SD clock
arch/arm64/boot/dts/renesas/salvator-common.dtsi +1 -0
@@ -762,6 +762,7 @@ vqmmc-supply = <®_1p8v>; bus-width = <8>; mmc-hs200-1_8v; + mmc-hs400-1_8v; non-removable; fixed-emmc-driver-type = <1>; status = "okay";
arch/arm64/boot/dts/renesas/ulcb.dtsi +1 -0
@@ -430,6 +430,7 @@ vqmmc-supply = <®_1p8v>; bus-width = <8>; mmc-hs200-1_8v; + mmc-hs400-1_8v; non-removable; status = "okay"; };
Signature · 1 line
2.19.1
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
For this patch already:
And this concludes my first patch review session while being on a ship :) Thanks for this SDHI hackathon guys, and looking forward to seeing you again!
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>
Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 13 lines · Simon Horman
Quoted 12 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
For this patch already:
Quoted 7 lines
Quoted 2 lines
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Hi Wolfram,
Quoted 17 lines · Wolfram Sang
Quoted 16 lines · Simon Horman
Quoted 14 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>
Quoted 7 lines
Quoted 4 lines
Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
Signature · 2 lines
Regards, Niklas S�derlund
Hi Simon, Wolfram,
Quoted 25 lines · Niklas S�derlund
Hi Wolfram,
Quoted 22 lines · Wolfram Sang
Quoted 20 lines · Simon Horman
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 9 lines
Quoted 2 lines
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon.
Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-)
Signature · 2 lines
Regards, Niklas S�derlund
Quoted 38 lines · Niklas Söderlund
Hi Simon, Wolfram,
Quoted 25 lines · Niklas Söderlund
Hi Wolfram,
Quoted 22 lines · Wolfram Sang
Quoted 20 lines · Simon Horman
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 9 lines
Quoted 2 lines
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
Quoted 6 lines
I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon.
Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-)
Hi Niklas,
I'm sorry but it was too late. I have queued this up for v4.22.
Hi Niklas, Simon,
Quoted 34 lines · Niklas Söderlund
Quoted 23 lines · Niklas Söderlund
Quoted 22 lines · Wolfram Sang
Quoted 20 lines · Simon Horman
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 9 lines
Quoted 2 lines
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
Quoted 6 lines
I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon.
Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-)
This patch seems to depend on both the clock patches, and mmc/next. Else the kernel hangs with an rcu check :-(
Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 41 lines · Geert Uytterhoeven
Hi Niklas, Simon,
Quoted 37 lines · Niklas Söderlund
Quoted 23 lines · Niklas Söderlund
Quoted 22 lines · Wolfram Sang
Quoted 20 lines · Simon Horman
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 9 lines
Quoted 2 lines
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon.
Quoted 8 lines
Quoted 3 lines
Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-)
This patch seems to depend on both the clock patches, and mmc/next. Else the kernel hangs with an rcu check :-(
Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.
Thanks, dropped and marked as deferred.
Niklas, please repost or ping me once the dependencies are present in an RC release.
Hi Simon,
Quoted 49 lines · Simon Horman
Quoted 48 lines · Geert Uytterhoeven
Hi Niklas, Simon,
Quoted 34 lines · Niklas Söderlund
Quoted 23 lines · Niklas Söderlund
Quoted 22 lines · Wolfram Sang
Quoted 20 lines · Simon Horman
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 9 lines
Quoted 2 lines
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
Quoted 6 lines
I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon.
Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-)
This patch seems to depend on both the clock patches, and mmc/next. Else the kernel hangs with an rcu check :-(
Quoted 6 lines
Quoted 1 line
Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.
Thanks, dropped and marked as deferred.
Niklas, please repost or ping me once the dependencies are present in an RC release.
Ping.
Signature · 2 lines
Regards, Niklas Söderlund
Quoted 52 lines · Niklas Söderlund
Hi Simon,
Quoted 49 lines · Simon Horman
Quoted 48 lines · Geert Uytterhoeven
Hi Niklas, Simon,
Quoted 34 lines · Niklas Söderlund
Quoted 23 lines · Niklas Söderlund
Quoted 22 lines · Wolfram Sang
Quoted 20 lines · Simon Horman
Quoted 10 lines · Wolfram Sang
Quoted 4 lines
This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved.
Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled?
Quoted 4 lines
For this patch already:
Reviewed-by Wolfram Sang <[email protected]>Tested-by Wolfram Sang <[email protected]>Thanks, I am marking this as deferred.
Please repost or ping me once the dependencies are present in an rc release.
Quoted 9 lines
Quoted 2 lines
Niklas, are we done now, so we can ask Simon to pick up the DTS change?
Almost :-)
I'm waiting for Geert to take the SD quirk patches before pinging Simon to take this one. Spoke to him today about that so I hope it will not be to long.
Quoted 6 lines
I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon.
Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-)
This patch seems to depend on both the clock patches, and mmc/next. Else the kernel hangs with an rcu check :-(
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Hence please drop, and requeue in renesas-devel after the release of v4.21-rc1.
Thanks, dropped and marked as deferred.
Niklas, please repost or ping me once the dependencies are present in an RC release.
Ping.
Hi Niklas,
with this applied on top of renesas-devel-20190124-v5.0-rc3 I see eMMC initialised in
* HS200 mode on Salvator-X/M3-W ES1.0
* HS400 mode on Salvator-XS/H3 ES2.0
* HS400 mode on Salvator-XS/M3-N ES1.0
I believe that is expected and have gone ahead and applied this patch.