Skip to contentSkip to conversation

check: use full paths for diff on error

PATCH New Dave Chinner 1 participant 1 message Nov 2, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 check: use full paths for diff on error

From: Dave Chinner <[email protected]>

i don't run fstests from the source directory, so when I get a golden image mismatch the relative path to the golden output is not useful:

(Run 'diff -u tests/generic/013.out /home/dave/src/xfstests-dev/results//xfs_64k/generic/013.out.bad' to see the entire diff)

Change the output to emit the real path for the golden out so this can be cut and pasted and run from anywhere.

(Run 'diff -u /home/dave/src/xfstests-dev/tests/generic/013.out /home/dave/src/xfstests-dev/results//xfs_64k/generic/013.out.bad' to see the entire diff)

---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
check +1 -1
index f3c8021d94b9..59f94c1c33f9 100755
@@ -799,7 +799,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
 			else
 				head -n "$DIFF_LENGTH"
 				echo "..."
-				echo "(Run '$diff $seq.out $seqres.out.bad'" \
+				echo "(Run '$diff $here/$seq.out $seqres.out.bad'" \
 					" to see the entire diff)"
 			fi; } | sed -e 's/^\(.\)/    \1/'
 			err=true
Signature · 1 line
2.19.1