Skip to contentSkip to conversation

pkgconfig: export variables

PATCH In review Joshua Watt 2 participants 4 messages Nov 2, 2018 – Dec 18, 2018

lore
Share & tools
lore

Joshua Watt

author
#0 lore raw

PATCH 1/1 pkgconfig: export variables

Export the PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR variables in case the parent shell hasn't done so.

---
 .../recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in +2 -2
index 5e44bb435c3..a9324de4cf3 100644
@@ -1,7 +1,7 @@
 #! /bin/sh
 
-PKG_CONFIG_PATH="@PATH_NATIVE@"
-PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
+export PKG_CONFIG_PATH="@PATH_NATIVE@"
+export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
 unset PKG_CONFIG_SYSROOT_DIR
 
 pkg-config "$@"
Signature · 1 line
2.19.1
#1 lore raw

✗ patchtest: failure for pkgconfig: export variables

== Series Details ==

Series: pkgconfig: export variables
Revision: 1
URL : https://patchwork.openembedded.org/series/14761/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            pkgconfig: export variables
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
author
#2 lore raw
In reply to Joshua Watt

Armin,

Would you mind backporting this to thud?

Thanks.

Quoted 24 lines · Joshua Watt

Export the PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR variables in case the
parent shell hasn't done so.

---
 .../recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in | 4
++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

native.in b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config- native.in
index 5e44bb435c3..a9324de4cf3 100644

meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in +2 -2
@@ -1,7 +1,7 @@
 #! /bin/sh
 
-PKG_CONFIG_PATH="@PATH_NATIVE@"
-PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
+export PKG_CONFIG_PATH="@PATH_NATIVE@"
+export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
 unset PKG_CONFIG_SYSROOT_DIR
 
 pkg-config "$@"
Signature · 1 line
Joshua Watt <[email protected]>
author
#3 lore raw
Quoted 4 lines · Joshua Watt

Armin,

Would you mind backporting this to thud?

Ping on the backport.

Quoted 31 lines

Thanks.

Quoted 15 lines · Joshua Watt

Export the PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR variables in case the
parent shell hasn't done so.

---
 .../recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in | 4
++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

native.in b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config- native.in
index 5e44bb435c3..a9324de4cf3 100644

meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in line 7

Quoted 9 lines
meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in +2 -2
@@ -1,7 +1,7 @@
 #! /bin/sh
 
-PKG_CONFIG_PATH="@PATH_NATIVE@"
-PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
+export PKG_CONFIG_PATH="@PATH_NATIVE@"
+export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
 unset PKG_CONFIG_SYSROOT_DIR
 
 pkg-config "$@"

--
Joshua Watt <[email protected]>