Skip to contentSkip to conversation

net-sysfs: fix formatting of tx_timeout attribute

PATCH In review Julian Wiedmann 2 participants 2 messages Nov 3, 2018 – Nov 4, 2018

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Julian Wiedmann

author
#0 lore raw

PATCH 1/1 net-sysfs: fix formatting of tx_timeout attribute

Add a missing newline.

Signed-off-by Julian Wiedmann <[email protected]>
---
 net/core/net-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/net-sysfs.c +1 -1
index bd67c4d0fcfd..ef06409d768e 100644
@@ -1039,7 +1039,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf)
 	trans_timeout = queue->trans_timeout;
 	spin_unlock_irq(&queue->_xmit_lock);
 
-	return sprintf(buf, "%lu", trans_timeout);
+	return sprintf(buf, "%lu\n", trans_timeout);
 }
 
 static unsigned int get_netdev_queue_index(struct netdev_queue *queue)
Signature · 1 line
2.16.4
maintainer
#1 lore raw

From: Julian Wiedmann <[email protected]>
Date: Fri, 2 Nov 2018 19:33:17 +0100

Quoted 12 lines

Add a missing newline.

Signed-off-by Julian Wiedmann <[email protected]>
---
 net/core/net-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/net-sysfs.c +0 -0
index bd67c4d0fcfd..ef06409d768e 100644

net/core/net-sysfs.c static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf) · line 1042

Quoted 5 lines
net/core/net-sysfs.c +1 -1
@@ -1039,7 +1039,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf)
 	trans_timeout = queue->trans_timeout;
 	spin_unlock_irq(&queue->_xmit_lock);
 
-	return sprintf(buf, "%lu", trans_timeout);
+	return sprintf(buf, "%lu\n", trans_timeout);

Maybe use 'fmt_ulong' instead?