Skip to contentSkip to conversation

package/bdwgc: drop AUTORECONF = YES

PATCH New Thomas Petazzoni 2 participants 3 messages Nov 2, 2018 – Nov 3, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 package/bdwgc: drop AUTORECONF = YES

Since commit 4e1dbd063d1f3ea7dfc95698320f6fd40139085d ("package/bdwgc:
bump to version 8.0.0"), we no longer have any patch that requires autoreconf. In addition, the libtool shipped with the package seems to no longer be bogus, because it builds perfectly fine without autoreconf. Therefore, let's drop this autoreconf.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/bdwgc/bdwgc.mk | 6 ------
 1 file changed, 6 deletions(-)
package/bdwgc/bdwgc.mk +0 -6
index 8607234e5d..8ffac476f3 100644
@@ -13,12 +13,6 @@ BDWGC_LICENSE_FILES = README.QUICK
 BDWGC_DEPENDENCIES = libatomic_ops host-pkgconf
 HOST_BDWGC_DEPENDENCIES = host-libatomic_ops host-pkgconf
 
-# The libtool shipped with the package is bogus and generates some
-# -L/usr/lib flags. It uses a version not supported by Buildroot
-# libtool patches, so autoreconfiguring the packages is the easiest
-# solution.
-BDWGC_AUTORECONF = YES
-
 BDWGC_CONF_OPTS = CFLAGS_EXTRA="$(BDWGC_CFLAGS_EXTRA)"
 ifeq ($(BR2_sparc),y)
 BDWGC_CFLAGS_EXTRA += -DAO_NO_SPARC_V9
Signature · 1 line
2.14.4
#1 lore raw

PATCH 1/1 package/bdwgc: drop AUTORECONF = YES

Dear Thomas,
Le ven. 2 nov. 2018 ? 21:33, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 8 lines

Since commit 4e1dbd063d1f3ea7dfc95698320f6fd40139085d ("package/bdwgc:
bump to version 8.0.0"), we no longer have any patch that requires autoreconf. In addition, the libtool shipped with the package seems to no longer be bogus, because it builds perfectly fine without autoreconf. Therefore, let's drop this autoreconf.

Signed-off-by Thomas Petazzoni <[email protected]>
Reviewed-by Fabrice Fontaine <[email protected]>
Quoted 22 lines
---
 package/bdwgc/bdwgc.mk | 6 ------
 1 file changed, 6 deletions(-)
package/bdwgc/bdwgc.mk +0 -7
index 8607234e5d..8ffac476f3 100644
@@ -13,12 +13,6 @@ BDWGC_LICENSE_FILES = README.QUICK
 BDWGC_DEPENDENCIES = libatomic_ops host-pkgconf
 HOST_BDWGC_DEPENDENCIES = host-libatomic_ops host-pkgconf
 
-# The libtool shipped with the package is bogus and generates some
-# -L/usr/lib flags. It uses a version not supported by Buildroot
-# libtool patches, so autoreconfiguring the packages is the easiest
-# solution.
-BDWGC_AUTORECONF = YES
-
 BDWGC_CONF_OPTS = CFLAGS_EXTRA="$(BDWGC_CFLAGS_EXTRA)"
 ifeq ($(BR2_sparc),y)
 BDWGC_CFLAGS_EXTRA += -DAO_NO_SPARC_V9
--
Quoted 2 lines

2.14.4

Best Regards,

Fabrice

author Applied
#2 lore raw

PATCH 1/1 package/bdwgc: drop AUTORECONF = YES

In reply to Thomas Petazzoni

Hello,

Quoted 10 lines · Thomas Petazzoni

Since commit 4e1dbd063d1f3ea7dfc95698320f6fd40139085d ("package/bdwgc:
bump to version 8.0.0"), we no longer have any patch that requires autoreconf. In addition, the libtool shipped with the package seems to no longer be bogus, because it builds perfectly fine without autoreconf. Therefore, let's drop this autoreconf.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/bdwgc/bdwgc.mk | 6 ------
 1 file changed, 6 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com