staging:dm365_ipipe:Add SPDX License Identifier
Subsystems (2)
PATCH 1/1 staging:dm365_ipipe:Add SPDX License Identifier
Add SPDX license Identifier to fix checkpatch malformed license warning
Remove old style text describing the License
--- .../staging/media/davinci_vpfe/dm365_ipipe.c | 31 ++++++------------- 1 file changed, 9 insertions(+), 22 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +9 -22
@@ -1,29 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* -* Copyright (C) 2012 Texas Instruments Inc -* -* This program is free software; you can redistribute it and/or -* modify it under the terms of the GNU General Public License as -* published by the Free Software Foundation version 2. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -* -* Contributors: -* Manjunath Hadli <[email protected]> -* Prabhakar Lad <[email protected]> * * -* IPIPE allows fine tuning of the input image using different -* tuning modules in IPIPE. Some examples :- Noise filter, Defect -* pixel correction etc. It essentially operate on Bayer Raw data -* or YUV raw data. To do image tuning, application call, +* IPIPE allows fine tuning of the input image using different +* tuning modules in IPIPE. Some examples :- Noise filter, Defect +* pixel correction etc. It essentially operate on Bayer Raw data +* or YUV raw data. To do image tuning, application call, * +* Contributors: +* Manjunath Hadli <[email protected]> +* Prabhakar Lad <[email protected]> */ #include <linux/slab.h>
Signature · 1 line
2.17.2
The subject line is still nto good. If you look at git log --oneline on this file, you will see eg:
106eb4d5f5be staging: media: davinci_vpfe: Use __func__ instead of function name
Actually, there are a lot of different examples for this file, but they all have in common that there is a space are the :, which is not found in your subject line. As you can see in the example, it is also not necssary to capitalize everything.
julia
Quoted 62 lines · Irenge Jules Bashizi
Add SPDX license Identifier to fix checkpatch malformed license warning
Remove old style text describing the License
Signed-off-by Irenge Jules Bashizi <[email protected]>--- .../staging/media/davinci_vpfe/dm365_ipipe.c | 31 ++++++------------- 1 file changed, 9 insertions(+), 22 deletions(-)drivers/staging/media/davinci_vpfe/dm365_ipipe.c +9
-23@@ -1,29 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* -* Copyright (C) 2012 Texas Instruments Inc -* -* This program is free software; you can redistribute it and/or -* modify it under the terms of the GNU General Public License as -* published by the Free Software Foundation version 2. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -* -* Contributors: -* Manjunath Hadli <[email protected]> -* Prabhakar Lad <[email protected]> * * -* IPIPE allows fine tuning of the input image using different -* tuning modules in IPIPE. Some examples :- Noise filter, Defect -* pixel correction etc. It essentially operate on Bayer Raw data -* or YUV raw data. To do image tuning, application call, +* IPIPE allows fine tuning of the input image using different +* tuning modules in IPIPE. Some examples :- Noise filter, Defect +* pixel correction etc. It essentially operate on Bayer Raw data +* or YUV raw data. To do image tuning, application call, * +* Contributors: +* Manjunath Hadli <[email protected]> +* Prabhakar Lad <[email protected]> */ #include <linux/slab.h> --2.17.2
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181103120109.780-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 14 lines · Irenge Jules Bashizi
Add SPDX license Identifier to fix checkpatch malformed license warning
Remove old style text describing the License
Signed-off-by Irenge Jules Bashizi <[email protected]>--- .../staging/media/davinci_vpfe/dm365_ipipe.c | 31 ++++++------------- 1 file changed, 9 insertions(+), 22 deletions(-)drivers/staging/media/davinci_vpfe/dm365_ipipe.c +0
-0
drivers/staging/media/davinci_vpfe/dm365_ipipe.c line 2
Quoted 4 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +2
-1@@ -1,29 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* -* Copyright (C) 2012 Texas Instruments Inc
Is it correct to remove this?
Quoted 17 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +0
-17-* -* This program is free software; you can redistribute it and/or -* modify it under the terms of the GNU General Public License as -* published by the Free Software Foundation version 2. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -* -* Contributors: -* Manjunath Hadli <[email protected]> -* Prabhakar Lad <[email protected]>
drivers/staging/media/davinci_vpfe/dm365_ipipe.c line 9
Quoted 10 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +4
-4* * -* IPIPE allows fine tuning of the input image using different -* tuning modules in IPIPE. Some examples :- Noise filter, Defect -* pixel correction etc. It essentially operate on Bayer Raw data -* or YUV raw data. To do image tuning, application call, +* IPIPE allows fine tuning of the input image using different +* tuning modules in IPIPE. Some examples :- Noise filter, Defect +* pixel correction etc. It essentially operate on Bayer Raw data +* or YUV raw data. To do image tuning, application call,
Is there a reason to indent this text?
julia
Quoted 17 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +3
-1* +* Contributors: +* Manjunath Hadli <[email protected]> +* Prabhakar Lad <[email protected]> */ #include <linux/slab.h> --2.17.2
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181103120109.780-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 13 lines · Julia Lawall
Quoted 9 lines · Irenge Jules Bashizi
Add SPDX license Identifier to fix checkpatch malformed license warning
Remove old style text describing the License
Signed-off-by Irenge Jules Bashizi <[email protected]>--- .../staging/media/davinci_vpfe/dm365_ipipe.c | 31 ++++++------------- 1 file changed, 9 insertions(+), 22 deletions(-)
Quoted 11 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c line 2
Quoted 9 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +2
-1@@ -1,29 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* -* Copyright (C) 2012 Texas Instruments Inc Is it correct to remove this?
Not at all, this should never be removed.
thanks,
greg k-h
Thanks all for your kind advise . really appreciate it.
*Jules*
*..*
Positive action combined with positive thinking results in success - Shiv Khera
Quoted 33 lines · Greg KH
Quoted 6 lines · Julia Lawall
Quoted 2 lines · Irenge Jules Bashizi
Add SPDX license Identifier to fix checkpatch malformed license warning
Quoted 8 lines
Review
Quoted 8 lines
Remove old style text describing the License
Signed-off-by Irenge Jules Bashizi <[email protected]>--- .../staging/media/davinci_vpfe/dm365_ipipe.c | 31 ++++++------------- 1 file changed, 9 insertions(+), 22 deletions(-)(quoted diff) +0
-0
b/drivers/staging/media/davinci_vpfe/dm365_ipipe.cQuoted 10 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c line 2
Quoted 8 lines
index
dcfeac818451..20bd6d652931100644drivers/staging/media/davinci_vpfe/dm365_ipipe.c +2
-1@@ -1,29 +1,16 @@ +// SPDX-License-Identifier: GPL-2.0 +/* -* Copyright (C) 2012 Texas Instruments Inc Is it correct to remove this?
Not at all, this should never be removed.
thanks,
greg k-h