staging: greybus: remove unmatched right bracket
PATCH 1/1 staging: greybus: remove unmatched right bracket
Remove unmatched right bracket.
Reported by uncrustify.
--- drivers/staging/greybus/camera.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/greybus/camera.c +0 -1
@@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)debugfs_create_file (entry->name, entry->mask, gcam->debugfs.root, gcam, &gb_camera_debugfs_ops); - } }return 0 ;
Signature · 1 line
2.19.1
Quoted 4 lines · Ioannis Valasakis
Remove unmatched right bracket.
Reported by uncrustify.Signed-off-by Ioannis Valasakis <[email protected]>
I wondered how such a problem could go unnoticed, but this file seems to have a lot of other compilation problems that could perhaps also be fixed up.
julia
Quoted 27 lines
--- drivers/staging/greybus/camera.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/greybus/camera.c +0
-2@@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)debugfs_create_file (entry->name, entry->mask, gcam->debugfs.root, gcam, &gb_camera_debugfs_ops); - } }return 0 ; --2.19.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.
Quoted 7 lines · Julia Lawall
Quoted 3 lines · Ioannis Valasakis
Remove unmatched right bracket.
Reported by uncrustify.
Quoted 7 lines
Quoted 1 line
Signed-off-by Ioannis Valasakis <[email protected]>Acked-by Julia Lawall <[email protected]>I wondered how such a problem could go unnoticed, but this file seems to have a lot of other compilation problems that could perhaps also be fixed up.
Weird indeed. I was wondering myself after compiling the modules but I noticed that camera isn't compile by running a make. Could you let me know how did you find out the compilation problems, i.e. how did you try compiling camera.c, so that I can replicate?
thanks
ioannis
Quoted 30 lines
julia
Quoted 27 lines
--- drivers/staging/greybus/camera.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/greybus/camera.c +0
-2@@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)debugfs_create_file (entry->name, entry->mask, gcam->debugfs.root, gcam, &gb_camera_debugfs_ops); - } }return 0 ; --2.19.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.
Quoted 12 lines · Ioannis Valasakis
Quoted 11 lines · Julia Lawall
Quoted 4 lines · Ioannis Valasakis
Remove unmatched right bracket.
Reported by uncrustify.Signed-off-by Ioannis Valasakis <[email protected]>Acked-by Julia Lawall <[email protected]>
Quoted 7 lines
Quoted 3 lines
I wondered how such a problem could go unnoticed, but this file seems to have a lot of other compilation problems that could perhaps also be fixed up.
Weird indeed. I was wondering myself after compiling the modules but I noticed that camera isn't compile by running a make. Could you let me know how did you find out the compilation problems, i.e. how did you try compiling
camera.c, so that I can replicate?
make drivers/staging/greybus/camera.o
julia
Quoted 41 lines
thanks
ioannisQuoted 23 lines
julia
Quoted 20 lines
--- drivers/staging/greybus/camera.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/greybus/camera.c +0
-2@@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)debugfs_create_file (entry->name, entry->mask, gcam->debugfs.root, gcam, &gb_camera_debugfs_ops); - } }return 0 ; --2.19.1
Quoted 7 lines
Quoted 7 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104120107.GA12077%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.
Quoted 19 lines · Julia Lawall
Quoted 15 lines · Ioannis Valasakis
Quoted 14 lines · Julia Lawall
Quoted 4 lines · Ioannis Valasakis
Remove unmatched right bracket.
Reported by uncrustify.Signed-off-by Ioannis Valasakis <[email protected]>Acked-by Julia Lawall <[email protected]>I wondered how such a problem could go unnoticed, but this file seems to have a lot of other compilation problems that could perhaps also be fixed up.
Quoted 6 lines
Quoted 4 lines
Weird indeed. I was wondering myself after compiling the modules but I noticed that camera isn't compile by running a make. Could you let me know how did you find out the compilation problems, i.e. how did you try compiling
camera.c, so that I can replicate?make
drivers/staging/greybus/camera.o
Of course, you do that from the top level directory. I was running make from inside the greybus folder and I was getting path include errors!
thanks!
Quoted 45 lines
julia
Quoted 41 lines
thanks
ioannisQuoted 23 lines
julia
Quoted 20 lines
--- drivers/staging/greybus/camera.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/greybus/camera.c +0
-2@@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)debugfs_create_file (entry->name, entry->mask, gcam->debugfs.root, gcam, &gb_camera_debugfs_ops); - } }return 0 ; --2.19.1
Quoted 7 lines
Quoted 7 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104020212.GA18914%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104120107.GA12077%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.