Skip to contentSkip to conversation

package/libid3tag: add .pc file and install to staging hook

PATCH New Jörg Krause 2 participants 3 messages Nov 5, 2018

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 package/libid3tag: add .pc file and install to staging hook

Signed-off-by J?rg Krause <[email protected]>
---
 package/libid3tag/id3tag.pc    | 11 +++++++++++
 package/libid3tag/libid3tag.mk |  7 +++++++
 2 files changed, 18 insertions(+)
 create mode 100644 package/libid3tag/id3tag.pc
package/libid3tag/id3tag.pc new file +11 -0
new file mode 100644
index 0000000000..845eb3276b
@@ -0,0 +1,11 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: id3tag
+Description: ID3 tag reading library
+Version: 0.15.1b
+Requires:
+Libs: -L${libdir} -lid3tag
+Cflags: -I${includedir}
package/libid3tag/libid3tag.mk +7 -0
index 951ae09c77..24342186cc 100644
@@ -12,4 +12,11 @@ LIBID3TAG_INSTALL_STAGING = YES
 LIBID3TAG_DEPENDENCIES = zlib
 LIBID3TAG_LIBTOOL_PATCH = NO
 
+define LIBID3TAG_INSTALL_STAGING_PC
+	$(INSTALL) -D package/libid3tag/id3tag.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/id3tag.pc
+endef
+
+LIBID3TAG_POST_INSTALL_STAGING_HOOKS += LIBID3TAG_INSTALL_STAGING_PC
+
 $(eval $(autotools-package))
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 package/libid3tag: add .pc file and install to staging hook

Hello,

Quoted 1 line · J?rg Krause
Signed-off-by J?rg Krause <[email protected]>

This probably needs a non-empty commit log. What is the motivation for adding a .pc file ? Is it used by some other package in Buildroot ? By a private application/library ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 package/libid3tag: add .pc file and install to staging hook

Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 1 line · J?rg Krause
Signed-off-by J?rg Krause <[email protected]>

This probably needs a non-empty commit log. What is the motivation for adding a .pc file ? Is it used by some other package in Buildroot ? By a private application/library ?

Sorry for being lazy :-) Thought it is a trivial change...

I am porting the mpd 0.21 release to the meson build system. It uses pkg-config for detecting libid3tag and fails, because of the missing .pc file.

Shall I send a v2 with a non-empty commit log?

J?rg