Skip to contentSkip to conversation

ASoC: imx-audmux: complete dt-bindings for imx6

PATCH Superseded Clément Péron 4 participants 7 messages Nov 5, 2018 – Nov 17, 2018

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape ASoC

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Clément Péron

author
#0 lore raw

PATCH 1/1 ASoC: imx-audmux: complete dt-bindings for imx6

From: Colin Didier <[email protected]>

The MX6 Audmux differs from MX51.

This patch adds the audmux for i.MX6 family.

Signed-off-by Colin Didier <[email protected]>
Signed-off-by Cl?ment P?ron <[email protected]>
---
 include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
 1 file changed, 8 insertions(+)
include/dt-bindings/sound/fsl-imx-audmux.h +8 -0
index 15f138bebe16..a1d0741d9ed1 100644
@@ -25,6 +25,14 @@
 #define MX51_AUDMUX_PORT6		5
 #define MX51_AUDMUX_PORT7		6
 
+#define MX6_AUDMUX_PORT1_SSI1		0
+#define MX6_AUDMUX_PORT2_SSI2		1
+#define MX6_AUDMUX_PORT3		2
+#define MX6_AUDMUX_PORT4		3
+#define MX6_AUDMUX_PORT5		4
+#define MX6_AUDMUX_PORT6		5
+#define MX6_AUDMUX_PORT7_SSI3		6
+
 /*
  * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
  * can be sourced from Rx/Tx.
Signature · 1 line
2.19.1
maintainer
#1 lore raw

PATCH 1/1 ASoC: imx-audmux: complete dt-bindings for imx6

Quoted 4 lines · On Mon, 5 Nov 2018 14:58:02 +0100, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= wrote:

From: Colin Didier <[email protected]>

The MX6 Audmux differs from MX51.

Quoted 8 lines

This patch adds the audmux for i.MX6 family.

Signed-off-by Colin Didier <[email protected]>
Signed-off-by Cl??ment P??ron <[email protected]>
---
 include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
 1 file changed, 8 insertions(+)
Reviewed-by Rob Herring <[email protected]>
#2 lore raw
In reply to Clément Péron
Quoted 8 lines · Cl?ment P?ron

From: Colin Didier <[email protected]>

The MX6 Audmux differs from MX51.

This patch adds the audmux for i.MX6 family.

Signed-off-by Colin Didier <[email protected]>
Signed-off-by Cl?ment P?ron <[email protected]>

I think you should send it to ASoC maintainer and list for applying.

Shawn

Quoted 26 lines
---
 include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
 1 file changed, 8 insertions(+)
include/dt-bindings/sound/fsl-imx-audmux.h +8 -0
index 15f138bebe16..a1d0741d9ed1 100644
@@ -25,6 +25,14 @@
 #define MX51_AUDMUX_PORT6		5
 #define MX51_AUDMUX_PORT7		6
 
+#define MX6_AUDMUX_PORT1_SSI1		0
+#define MX6_AUDMUX_PORT2_SSI2		1
+#define MX6_AUDMUX_PORT3		2
+#define MX6_AUDMUX_PORT4		3
+#define MX6_AUDMUX_PORT5		4
+#define MX6_AUDMUX_PORT6		5
+#define MX6_AUDMUX_PORT7_SSI3		6
+
 /*
  * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
  * can be sourced from Rx/Tx.
Signature · 1 line
2.19.1
author
#3 lore raw

Hi Shawn,

Quoted 4 lines · Shawn Guo
Quoted 2 lines · Cl?ment P?ron

From: Colin Didier <[email protected]>

Quoted 8 lines
Quoted 6 lines

The MX6 Audmux differs from MX51.

This patch adds the audmux for i.MX6 family.

Signed-off-by Colin Didier <[email protected]>
Signed-off-by Cl?ment P?ron <[email protected]>

I think you should send it to ASoC maintainer and list for applying.

It's still quite new for me to submit patch, but if this patch should be sent to ASoC maintainer maybe there is a line missing in the MAINTAINERS file no ?

SOUND

M:      Jaroslav Kysela <[email protected]>
M:      Takashi Iwai <[email protected]>
L:      alsa-devel at alsa-project.org (moderated for non-subscribers)
W:      http://www.alsa-project.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
T:      git git://git.alsa-project.org/alsa-kernel.git
Q:      http://patchwork.kernel.org/project/alsa-devel/list/
S:      Maintained
F:      Documentation/sound/
+ F:      include/dt-bindings/sound/
F:      include/sound/
F:      include/uapi/sound/
F:      sound/

Regards,
Clement

Quoted 29 lines

Shawn

Quoted 26 lines
---
 include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
 1 file changed, 8 insertions(+)
include/dt-bindings/sound/fsl-imx-audmux.h +8 -1
index 15f138bebe16..a1d0741d9ed1 100644
@@ -25,6 +25,14 @@
 #define MX51_AUDMUX_PORT6            5
 #define MX51_AUDMUX_PORT7            6
 
+#define MX6_AUDMUX_PORT1_SSI1                0
+#define MX6_AUDMUX_PORT2_SSI2                1
+#define MX6_AUDMUX_PORT3             2
+#define MX6_AUDMUX_PORT4             3
+#define MX6_AUDMUX_PORT5             4
+#define MX6_AUDMUX_PORT6             5
+#define MX6_AUDMUX_PORT7_SSI3                6
+
 /*
  * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
  * can be sourced from Rx/Tx.
--

2.19.1

#4 lore raw
Quoted 11 lines · Cl?ment P?ron

Hi Shawn,

Quoted 8 lines · Shawn Guo
Quoted 6 lines · Cl?ment P?ron

From: Colin Didier <[email protected]>

The MX6 Audmux differs from MX51.

This patch adds the audmux for i.MX6 family.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Colin Didier <[email protected]>
Signed-off-by Cl?ment P?ron <[email protected]>

I think you should send it to ASoC maintainer and list for applying.

It's still quite new for me to submit patch, but if this patch should be sent to ASoC maintainer maybe there is a line missing in the MAINTAINERS file no ?

@Mark, comment?

Shawn

Quoted 48 lines

SOUND

M:      Jaroslav Kysela <[email protected]>
M:      Takashi Iwai <[email protected]>
L:      alsa-devel at alsa-project.org (moderated for non-subscribers)
W:      http://www.alsa-project.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
T:      git git://git.alsa-project.org/alsa-kernel.git
Q:      http://patchwork.kernel.org/project/alsa-devel/list/
S:      Maintained
F:      Documentation/sound/
+ F:      include/dt-bindings/sound/
F:      include/sound/
F:      include/uapi/sound/
F:      sound/

Regards,
Clement

Quoted 29 lines

Shawn

Quoted 26 lines
---
 include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
 1 file changed, 8 insertions(+)
include/dt-bindings/sound/fsl-imx-audmux.h +8 -1
index 15f138bebe16..a1d0741d9ed1 100644
@@ -25,6 +25,14 @@
 #define MX51_AUDMUX_PORT6            5
 #define MX51_AUDMUX_PORT7            6
 
+#define MX6_AUDMUX_PORT1_SSI1                0
+#define MX6_AUDMUX_PORT2_SSI2                1
+#define MX6_AUDMUX_PORT3             2
+#define MX6_AUDMUX_PORT4             3
+#define MX6_AUDMUX_PORT5             4
+#define MX6_AUDMUX_PORT6             5
+#define MX6_AUDMUX_PORT7_SSI3                6
+
 /*
  * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
  * can be sourced from Rx/Tx.
--

2.19.1

maintainer
#5 lore raw
Quoted 7 lines · Shawn Guo
Quoted 3 lines · Cl?ment P?ron

It's still quite new for me to submit patch, but if this patch should be sent to ASoC maintainer maybe there is a line missing in the MAINTAINERS file no ?

@Mark, comment?

Adding a file pattern for this seems sensible, yes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181116/6452e180/attachment.sig>

author
#6 lore raw

Hi Mark,

Quoted 11 lines · Mark Brown
Quoted 7 lines · Shawn Guo
Quoted 3 lines · Cl?ment P?ron

It's still quite new for me to submit patch, but if this patch should be sent to ASoC maintainer maybe there is a line missing in the MAINTAINERS file no ?

@Mark, comment?

Adding a file pattern for this seems sensible, yes.

OK,

I will send a v2 for the IMX6 Audmux bindings with ASoC List and Maintainers.

Thanks,
Clement