Skip to contentSkip to conversation

clocksource: imx-gpt: remove unnecessary irq protection

PATCH Applied Clément Péron 2 participants 2 messages Nov 5, 2018

Subsystems (2)
Arm i.MX and Layerscape Clocksource, clockevent drivers
lore
Share & tools
lore

Clément Péron

author
#0 lore raw

PATCH 1/1 clocksource: imx-gpt: remove unnecessary irq protection

shutdown and oneshot are already protected against irq interruptions

Signed-off-by Cl?ment P?ron <[email protected]>
---
 drivers/clocksource/timer-imx-gpt.c | 17 -----------------
 1 file changed, 17 deletions(-)
drivers/clocksource/timer-imx-gpt.c +0 -17
index 165fbbb1c9a0..48e025e8dc82 100644
@@ -198,15 +198,8 @@ static int v2_set_next_event(unsigned long evt,
 static int mxc_shutdown(struct clock_event_device *ced)
 {
 	struct imx_timer *imxtm = to_imx_timer(ced);
-	unsigned long flags;
 	u32 tcn;
 
-	/*
-	 * The timer interrupt generation is disabled at least
-	 * for enough time to call mxc_set_next_event()
-	 */
-	local_irq_save(flags);
-
 	/* Disable interrupt in GPT module */
 	imxtm->gpt->gpt_irq_disable(imxtm);
 

@@ -221,21 +214,12 @@ static int mxc_shutdown(struct clock_event_device *ced)
 	printk(KERN_INFO "%s: changing mode\n", __func__);
 #endif /* DEBUG */
 
-	local_irq_restore(flags);
-
 	return 0;
 }
 
 static int mxc_set_oneshot(struct clock_event_device *ced)
 {
 	struct imx_timer *imxtm = to_imx_timer(ced);
-	unsigned long flags;
-
-	/*
-	 * The timer interrupt generation is disabled at least
-	 * for enough time to call mxc_set_next_event()
-	 */
-	local_irq_save(flags);
 
 	/* Disable interrupt in GPT module */
 	imxtm->gpt->gpt_irq_disable(imxtm);

@@ -260,7 +244,6 @@ static int mxc_set_oneshot(struct clock_event_device *ced)
 	 * mode switching
 	 */
 	imxtm->gpt->gpt_irq_enable(imxtm);
-	local_irq_restore(flags);
 
 	return 0;
 }
Signature · 1 line
2.19.1
Applied
#1 lore raw
Quoted 4 lines · Cl?ment P?ron

shutdown and oneshot are already protected against irq interruptions

Signed-off-by Cl?ment P?ron <[email protected]>

---

Applied, thanks!

-- Daniel

Signature · 5 lines
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog