staging: greybus: various code cleanups

PATCH In review Ioannis Valasakis 3 participants 19 messages Nov 5, 2018

Subsystems (6)

Staging Greybus Greybus audio protocols drivers Greybus FW/HID/SPI protocols drivers +2 more subsystems

lore

Share & tools

lore

Ioannis Valasakis

author

2018-11-05 14:18 UTC #0 lore raw

cover staging: greybus: various code cleanups

staging: greybus: Various code cleanups reported by checkpatch.

Ioannis Valasakis (14):
staging: greybus Align parameters to parentheses
staging: greybus Add a blank line after declaration
staging: greybus Fix SPDX identifier
staging: greybus Align arguments with parentheses
staging: greybus Shorten comparison to NULL
staging: greybus Correct SPDX License Identifier
staging: greybus Remove multiple blank lines
staging: greybus Insert empty line after struct
staging: greybus Remove space before tab
staging: greybus: cleanup long line in gb_uart_probe()
staging: greybus: remove multiple blank lines
staging: greybus: Add extra space around OR operator
staging: greybus: remove extra space before tab
staging: greybus: correct SPDX license identifiers

 drivers/staging/greybus/arche-apb-ctrl.c      |  1 -
 drivers/staging/greybus/arche_platform.h      |  2 +-
 drivers/staging/greybus/arpc.h                |  2 +-
 drivers/staging/greybus/audio_apbridgea.h     |  2 +-
 drivers/staging/greybus/audio_codec.h         |  2 +-
 drivers/staging/greybus/audio_manager.h       |  2 +-
 .../staging/greybus/audio_manager_private.h   |  2 +-
 drivers/staging/greybus/bundle.h              |  3 +-
 drivers/staging/greybus/connection.c          |  4 ---
 drivers/staging/greybus/connection.h          |  2 +-
 drivers/staging/greybus/control.h             |  5 ++--
 drivers/staging/greybus/core.c                |  6 ++--
 drivers/staging/greybus/firmware.h            |  2 +-
 drivers/staging/greybus/gb-camera.h           |  2 +-
 drivers/staging/greybus/gbphy.h               |  2 +-
 drivers/staging/greybus/greybus.h             |  2 +-
 .../staging/greybus/greybus_authentication.h  |  2 +-
 drivers/staging/greybus/greybus_firmware.h    |  2 +-
 drivers/staging/greybus/greybus_manifest.h    |  2 +-
 drivers/staging/greybus/greybus_protocols.h   | 29 +++++--------------
 drivers/staging/greybus/greybus_trace.h       |  2 +-
 drivers/staging/greybus/hd.h                  |  2 +-
 drivers/staging/greybus/interface.h           |  2 +-
 drivers/staging/greybus/manifest.h            |  2 +-
 drivers/staging/greybus/module.h              |  2 +-
 drivers/staging/greybus/operation.h           |  2 +-
 drivers/staging/greybus/spilib.h              |  2 +-
 drivers/staging/greybus/svc.h                 |  2 +-
 drivers/staging/greybus/uart.c                |  8 ++---
 29 files changed, 41 insertions(+), 59 deletions(-)

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:18 UTC #1 lore raw

PATCH 1/14 staging: greybus Align parameters to parentheses

Align parameters to the right side of the left parentheses Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/staging/greybus/core.c +3 -3

index dafa430d176e..d28773e06838 100644
@@ -28,7 +28,7 @@ int greybus_disabled(void)
 EXPORT_SYMBOL_GPL(greybus_disabled);
 
 static bool greybus_match_one_id(struct gb_bundle *bundle,
-				     const struct greybus_bundle_id *id)
+				 const struct greybus_bundle_id *id)
 {
 	if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
 	    (id->vendor != bundle->intf->vendor_id))

@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
 static const struct greybus_bundle_id *
 greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
 {
-	if (id == NULL)
+	if (!id == NULL)
 		return NULL;
 
 	for (; id->vendor || id->product || id->class || id->driver_info;

@@ -266,7 +266,7 @@ static int greybus_remove(struct device *dev)
 }
 
 int greybus_register_driver(struct greybus_driver *driver, struct module *owner,
-		const char *mod_name)
+			    const char *mod_name)
 {
 	int retval;

Signature · 1 line

2.19.1

Greg KH

maintainer

2018-11-05 14:27 UTC #2 lore raw

Re: [PATCH 01/14] staging: greybus Align parameters to parentheses

Quoted 7 lines · Ioannis Valasakis

Align parameters to the right side of the left parentheses Reported by checkpatch.
Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

You forgot a ":" after "greybus" on most of the subject lines in this patch series :(

Please fix up and resend the whole thing.

thanks,

greg k-h

Ioannis Valasakis

author

2018-11-05 14:18 UTC #3 lore raw

PATCH 2/14 staging: greybus Add a blank line after declaration

In reply to Ioannis Valasakis

Add a blank line after the struct declaration
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/control.h | 1 +
 1 file changed, 1 insertion(+)

drivers/staging/greybus/control.h +1 -0

index 643ddb9e0f92..9c453e0b1b33 100644
@@ -24,6 +24,7 @@ struct gb_control {
 	char *vendor_string;
 	char *product_string;
 };
+
 #define to_gb_control(d) container_of(d, struct gb_control, dev)
 
 struct gb_control *gb_control_create(struct gb_interface *intf);

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:19 UTC #4 lore raw

PATCH 3/14 staging: greybus Fix SPDX identifier

In reply to Ioannis Valasakis

Fix the SPDX identifier as by replacing with standard C comment the file
Reported by checkpatch

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/control.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/greybus/control.h +1 -1

index 9c453e0b1b33..ebb7a2ee17dc 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus CPort control protocol
  *

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:19 UTC #5 lore raw

PATCH 4/14 staging: greybus Align arguments with parentheses

In reply to Ioannis Valasakis

Align arguments with the right side of the open left parentheses Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/control.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/greybus/control.h +1 -1

index ebb7a2ee17dc..5a45d55349a1 100644
@@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
 int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
 int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
 int gb_control_disconnecting_operation(struct gb_control *control,
-					u16 cport_id);
+				       u16 cport_id);
 int gb_control_mode_switch_operation(struct gb_control *control);
 void gb_control_mode_switch_prepare(struct gb_control *control);
 void gb_control_mode_switch_complete(struct gb_control *control);

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:19 UTC #6 lore raw

PATCH 5/14 staging: greybus Shorten comparison to NULL

In reply to Ioannis Valasakis

Shorten pointer NULL check by simple truth test
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/greybus/core.c +1 -1

index d28773e06838..0ed3b0ffee5a 100644
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
 static const struct greybus_bundle_id *
 greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
 {
-	if (!id == NULL)
+	if (id)
 		return NULL;
 
 	for (; id->vendor || id->product || id->class || id->driver_info;

Signature · 1 line

2.19.1

Julia Lawall

2018-11-05 14:22 UTC #7 lore raw

Re: [Outreachy kernel] [PATCH 05/14] staging: greybus Shorten comparison to NULL

Quoted 13 lines · Ioannis Valasakis

Shorten pointer NULL check by simple truth test
Reported by checkpatch.
Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/core.c +0 -0
index d28773e06838..0ed3b0ffee5a 100644

drivers/staging/greybus/core.c static bool greybus_match_one_id(struct gb_bundle *bundle, · line 51

Quoted 5 lines

drivers/staging/greybus/core.c +1 -1

@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
 static const struct greybus_bundle_id *
 greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
 {
-	if (!id == NULL)
+	if (id)

This is not the right starting point. It is on top of on of your incorrect patches. Overall, I think you have done something wrong in redoing this series.

julia

Quoted 14 lines

drivers/staging/greybus/core.c +0 -1
 		return NULL;
 
 	for (; id->vendor || id->product || id->class || id->driver_info;
--
2.19.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/abb81a5c17d259dcd043049d3d77b704a364b437.1541427415.git.code%40wizofe.uk.
For more options, visit https://groups.google.com/d/optout.

Ioannis Valasakis

author

2018-11-05 14:19 UTC #8 lore raw

PATCH 6/14 staging: greybus Correct SPDX License Identifier

In reply to Ioannis Valasakis

Correct the SPDX License Identifier by using C style comments Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/arche_platform.h        | 2 +-
 drivers/staging/greybus/arpc.h                  | 2 +-
 drivers/staging/greybus/audio_apbridgea.h       | 2 +-
 drivers/staging/greybus/audio_codec.h           | 2 +-
 drivers/staging/greybus/audio_manager.h         | 2 +-
 drivers/staging/greybus/audio_manager_private.h | 2 +-
 drivers/staging/greybus/bundle.h                | 2 +-
 drivers/staging/greybus/connection.h            | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

drivers/staging/greybus/arche_platform.h +1 -1

index 02056351d25a..9d997f2d6517 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Arche Platform driver to enable Unipro link.
  *

drivers/staging/greybus/arpc.h +1 -1

index 3534ba1a4e6c..3dab6375909c 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * This file is provided under a dual BSD/GPLv2 license.  When using or
  * redistributing this file, you may do so under either license.

drivers/staging/greybus/audio_apbridgea.h +1 -1

index 42ac6059bfc7..330fc7a397eb 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
+/* SPDX-License-Identifier: BSD-3-Clause */
 /**
  * Copyright (c) 2015-2016 Google Inc.
  * All rights reserved.

drivers/staging/greybus/audio_codec.h +1 -1

index 4efd8b3ebe07..d36f8cd35e06 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus audio driver
  * Copyright 2015 Google Inc.

drivers/staging/greybus/audio_manager.h +1 -1

index dcb1a20f5ff1..be605485a8ce 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus operations
  *

drivers/staging/greybus/audio_manager_private.h +1 -1

index 9d9b58fc54c4..2b3a766c7de7 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus operations
  *

drivers/staging/greybus/bundle.h +1 -1

index ffcfd43802cc..8734d2055657 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus bundles
  *

drivers/staging/greybus/connection.h +1 -1

index ec3f1d3ef3b9..8deeb1d5f008 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus connections
  *

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:19 UTC #9 lore raw

PATCH 7/14 staging: greybus Remove multiple blank lines

In reply to Ioannis Valasakis

Remove continuous multiple blank lines
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/arche-apb-ctrl.c | 1 -
 drivers/staging/greybus/connection.c     | 4 ----
 2 files changed, 5 deletions(-)

drivers/staging/greybus/arche-apb-ctrl.c +0 -1

index cc8d6fc831b4..be5ffed90bcf 100644
@@ -20,7 +20,6 @@
 #include <linux/spinlock.h>
 #include "arche_platform.h"
 
-
 static void apb_bootret_deassert(struct device *dev);
 
 struct arche_apb_ctrl_drvdata {

drivers/staging/greybus/connection.c +0 -4

index 2103168b585e..56ae30533a70 100644
@@ -11,17 +11,13 @@
 #include "greybus.h"
 #include "greybus_trace.h"
 
-
 #define GB_CONNECTION_CPORT_QUIESCE_TIMEOUT	1000
 
-
 static void gb_connection_kref_release(struct kref *kref);
 
-
 static DEFINE_SPINLOCK(gb_connections_lock);
 static DEFINE_MUTEX(gb_connection_mutex);
 
-
 /* Caller holds gb_connection_mutex. */
 static bool gb_connection_cport_in_use(struct gb_interface *intf, u16 cport_id)
 {

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:19 UTC #10 lore raw

PATCH 8/14 staging: greybus Insert empty line after struct

In reply to Ioannis Valasakis

Insert empty line after struct definition
Reported by checkpatch

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/bundle.h | 1 +
 1 file changed, 1 insertion(+)

drivers/staging/greybus/bundle.h +1 -0

index 8734d2055657..4aaf7a0880fd 100644
@@ -31,6 +31,7 @@ struct gb_bundle {
 
 	struct list_head	links;	/* interface->bundles */
 };
+
 #define to_gb_bundle(d) container_of(d, struct gb_bundle, dev)
 
 /* Greybus "private" definitions" */

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:19 UTC #11 lore raw

PATCH 9/14 staging: greybus Remove space before tab

In reply to Ioannis Valasakis

Remove extra space before a tab character
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/greybus/uart.c +2 -2

index 3313cb0b60af..b3bffe91ae99 100644
@@ -805,8 +805,8 @@ static const struct tty_operations gb_ops = {
 	.tiocmget =		gb_tty_tiocmget,
 	.tiocmset =		gb_tty_tiocmset,
 	.get_icount =		gb_tty_get_icount,
-	.set_serial = 		set_serial_info,
-	.get_serial = 		get_serial_info,
+	.set_serial =		set_serial_info,
+	.get_serial =		get_serial_info,
 };
 
 static const struct tty_port_operations gb_port_ops = {

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:20 UTC #12 lore raw

PATCH 10/14 staging: greybus: cleanup long line in gb_uart_probe()

In reply to Ioannis Valasakis

Clear line over 80 characters warning in gb_uart_probe() by adding appropriate lines breaks.
Reported by checkpatch

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/greybus/uart.c +2 -2

index b3bffe91ae99..735f70c09823 100644
@@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 	if (!gb_tty)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
+	connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
+					 (gbphy_dev->cport_desc->id),
 					  gb_uart_request_handler);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);

Signature · 1 line

2.19.1

Julia Lawall

2018-11-05 14:21 UTC #13 lore raw

Re: [Outreachy kernel] [PATCH 10/14] staging: greybus: cleanup long line in gb_uart_probe()

Quoted 14 lines · Ioannis Valasakis

Clear line over 80 characters warning in gb_uart_probe() by adding appropriate lines breaks.
Reported by checkpatch
Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/uart.c +0 -0
index b3bffe91ae99..735f70c09823 100644

drivers/staging/greybus/uart.c static int gb_uart_probe(struct gbphy_device *gbphy_dev, · line 833

Quoted 7 lines

drivers/staging/greybus/uart.c +2 -2

@@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 	if (!gb_tty)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
+	connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
+					 (gbphy_dev->cport_desc->id),

This is not a good way to make the change. Put le16_to_cpu in front of its argument list and move the indentation back to some multiple of tabs if needed.

julia

Quoted 14 lines

drivers/staging/greybus/uart.c +0 -1
 					  gb_uart_request_handler);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);
--
2.19.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/7fe735d1e4a5d0497711c8a34c95184dfc3c9930.1541427415.git.code%40wizofe.uk.
For more options, visit https://groups.google.com/d/optout.

Ioannis Valasakis

author

2018-11-05 14:20 UTC #14 lore raw

PATCH 11/14 staging: greybus: remove multiple blank lines

In reply to Ioannis Valasakis

Remove extra blank lines to conform with the warning. Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/greybus_protocols.h | 15 ---------------
 1 file changed, 15 deletions(-)

drivers/staging/greybus/greybus_protocols.h +0 ~~-15~~

index 9bd7b6dfb476..f38f4a8db2b7 100644
@@ -65,7 +65,6 @@
 #define GB_CONTROL_BUNDLE_ID			0
 #define GB_CONTROL_CPORT_ID			0
 
-
 /*
  * All operation messages (both requests and responses) begin with
  * a header that encodes the size of the message (header included).

@@ -95,7 +94,6 @@ struct gb_operation_msg_hdr {
 	__u8	pad[2];		/* must be zero (ignore when read) */
 } __packed;
 
-
 /* Generic request types */
 #define GB_REQUEST_TYPE_CPORT_SHUTDOWN		0x00
 #define GB_REQUEST_TYPE_INVALID			0x7f

@@ -104,7 +102,6 @@ struct gb_cport_shutdown_request {
 	__u8 phase;
 } __packed;
 
-
 /* Control Protocol */
 
 /* Greybus control request types */

@@ -249,7 +246,6 @@ struct gb_apb_request_cport_flags {
 #define GB_APB_CPORT_FLAG_HIGH_PRIO		0x02
 } __packed;
 
-
 /* Firmware Download Protocol */
 
 /* Request Types */

@@ -286,7 +282,6 @@ struct gb_fw_download_release_firmware_request {
 } __packed;
 /* firmware download release firmware response has no payload */
 
-
 /* Firmware Management Protocol */
 
 /* Request Types */

@@ -368,7 +363,6 @@ struct gb_fw_mgmt_backend_fw_updated_request {
 } __packed;
 /* firmware management backend firmware updated response has no payload */
 
-
 /* Component Authentication Protocol (CAP) */
 
 /* Request Types */

@@ -405,7 +399,6 @@ struct gb_cap_authenticate_response {
 	__u8			signature[0];
 } __packed;
 
-
 /* Bootrom Protocol */
 
 /* Version of the Greybus bootrom protocol we support */

@@ -474,7 +467,6 @@ struct gb_bootrom_get_vid_pid_response {
 	__le32			product_id;
 } __packed;
 
-
 /* Power Supply */
 
 /* Greybus power supply request types */

@@ -648,7 +640,6 @@ struct gb_power_supply_event_request {
 #define GB_POWER_SUPPLY_UPDATE		0x01
 } __packed;
 
-
 /* HID */
 
 /* Greybus HID operation types */

@@ -694,7 +685,6 @@ struct gb_hid_input_report_request {
 	__u8				report[0];
 } __packed;
 
-
 /* I2C */
 
 /* Greybus i2c request types */

@@ -730,7 +720,6 @@ struct gb_i2c_transfer_response {
 	__u8				data[0];	/* inbound data */
 } __packed;
 
-
 /* GPIO */
 
 /* Greybus GPIO request types */

@@ -829,7 +818,6 @@ struct gb_gpio_irq_event_request {
 } __packed;
 /* irq event has no response */
 
-
 /* PWM */
 
 /* Greybus PWM operation types */

@@ -1317,7 +1305,6 @@ struct gb_svc_intf_oops_request {
 } __packed;
 /* intf_oops response has no payload */
 
-
 /* RAW */
 
 /* Greybus raw request types */

@@ -1328,7 +1315,6 @@ struct gb_raw_send_request {
 	__u8	data[0];
 } __packed;
 
-
 /* UART */
 
 /* Greybus UART operation types */

@@ -2204,7 +2190,6 @@ struct gb_audio_send_data_request {
 	__u8	data[0];
 } __packed;
 
-
 /* Log */
 
 /* operations */

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:20 UTC #15 lore raw

PATCH 12/14 staging: greybus: Add extra space around OR operator

In reply to Ioannis Valasakis

Add extra spaces around the OR operator.
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/greybus_protocols.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

drivers/staging/greybus/greybus_protocols.h +4 -4

index f38f4a8db2b7..5783f715bdc2 100644
@@ -866,10 +866,10 @@ struct gb_pwm_disable_request {
 /* Should match up with modes in linux/spi/spi.h */
 #define GB_SPI_MODE_CPHA		0x01		/* clock phase */
 #define GB_SPI_MODE_CPOL		0x02		/* clock polarity */
-#define GB_SPI_MODE_MODE_0		(0|0)		/* (original MicroWire) */
-#define GB_SPI_MODE_MODE_1		(0|GB_SPI_MODE_CPHA)
-#define GB_SPI_MODE_MODE_2		(GB_SPI_MODE_CPOL|0)
-#define GB_SPI_MODE_MODE_3		(GB_SPI_MODE_CPOL|GB_SPI_MODE_CPHA)
+#define GB_SPI_MODE_MODE_0		(0 | 0)		/* (original MicroWire) */
+#define GB_SPI_MODE_MODE_1		(0 | GB_SPI_MODE_CPHA)
+#define GB_SPI_MODE_MODE_2		(GB_SPI_MODE_CPOL | 0)
+#define GB_SPI_MODE_MODE_3		(GB_SPI_MODE_CPOL | GB_SPI_MODE_CPHA)
 #define GB_SPI_MODE_CS_HIGH		0x04		/* chipselect active high? */
 #define GB_SPI_MODE_LSB_FIRST		0x08		/* per-word bits-on-wire */
 #define GB_SPI_MODE_3WIRE		0x10		/* SI/SO signals shared */

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:20 UTC #16 lore raw

PATCH 13/14 staging: greybus: remove extra space before tab

In reply to Ioannis Valasakis

Remove extra spaces before the tab character inside a comment section. Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/greybus_protocols.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/greybus/greybus_protocols.h +2 -2

index 5783f715bdc2..429a952c5200 100644
@@ -918,8 +918,8 @@ struct gb_spi_device_config_response {
  *	0 the default (from @spi_device) is used.
  * @len: size of rx and tx buffers (in bytes)
  * @delay_usecs: microseconds to delay after this transfer before (optionally)
- * 	changing the chipselect status, then starting the next transfer or
- * 	completing this spi_message.
+ *	changing the chipselect status, then starting the next transfer or
+ *	completing this spi_message.
  * @cs_change: affects chipselect after this transfer completes
  * @bits_per_word: select a bits_per_word other than the device default for this
  *	transfer. If 0 the default (from @spi_device) is used.

Signature · 1 line

2.19.1

Ioannis Valasakis

author

2018-11-05 14:20 UTC #17 lore raw

PATCH 14/14 staging: greybus: correct SPDX license identifiers

In reply to Ioannis Valasakis

Correct the SPDX License Identifiers by replacing the comment to C-style comment.
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/firmware.h               | 2 +-
 drivers/staging/greybus/gb-camera.h              | 2 +-
 drivers/staging/greybus/gbphy.h                  | 2 +-
 drivers/staging/greybus/greybus.h                | 2 +-
 drivers/staging/greybus/greybus_authentication.h | 2 +-
 drivers/staging/greybus/greybus_firmware.h       | 2 +-
 drivers/staging/greybus/greybus_manifest.h       | 2 +-
 drivers/staging/greybus/greybus_protocols.h      | 2 +-
 drivers/staging/greybus/greybus_trace.h          | 2 +-
 drivers/staging/greybus/hd.h                     | 2 +-
 drivers/staging/greybus/interface.h              | 2 +-
 drivers/staging/greybus/manifest.h               | 2 +-
 drivers/staging/greybus/module.h                 | 2 +-
 drivers/staging/greybus/operation.h              | 2 +-
 drivers/staging/greybus/spilib.h                 | 2 +-
 drivers/staging/greybus/svc.h                    | 2 +-
 16 files changed, 16 insertions(+), 16 deletions(-)

drivers/staging/greybus/firmware.h +1 -1

index 946221307ef6..72dfabfa4704 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Firmware Management Header
  *

drivers/staging/greybus/gb-camera.h +1 -1

index ee293e461fc3..5fc469101fc1 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Camera protocol driver.
  *

drivers/staging/greybus/gbphy.h +1 -1

index 99463489d7d6..087928a586fb 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Bridged-Phy Bus driver
  *

drivers/staging/greybus/greybus.h +1 -1

index d03ddb7c9df0..f0488ffff93e 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus driver and device API
  *

drivers/staging/greybus/greybus_authentication.h +1 -1

index 03ea9615b217..d654760cf175 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * Greybus Component Authentication User Header
  *

drivers/staging/greybus/greybus_firmware.h +1 -1

index b58281a63ba4..13ef3aa5279e 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * Greybus Firmware Management User Header
  *

drivers/staging/greybus/greybus_manifest.h +1 -1

index 2cec5cf7a846..db68f7e7d5a7 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus manifest definition
  *

drivers/staging/greybus/greybus_protocols.h +1 -1

index 429a952c5200..ee3bbdfa1477 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * This file is provided under a dual BSD/GPLv2 license.  When using or
  * redistributing this file, you may do so under either license.

drivers/staging/greybus/greybus_trace.h +1 -1

index 7b5e2c6b1f6b..1bc9f1275c65 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus driver and device API
  *

drivers/staging/greybus/hd.h +1 -1

index 6cf024a20a58..348b76fabc9a 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Host Device
  *

drivers/staging/greybus/interface.h +1 -1

index 1c00c5bb3ec9..8fb1eacda302 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Interface Block code
  *

drivers/staging/greybus/manifest.h +1 -1

index f3c95a255631..88aa7e44cad5 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus manifest parsing
  *

drivers/staging/greybus/module.h +1 -1

index b1ebcc6636db..2a27e520ee94 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Module code
  *

drivers/staging/greybus/operation.h +1 -1

index 40b7b02fff88..17ba3daf111b 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus operations
  *

drivers/staging/greybus/spilib.h +1 -1

index 043d4d32c3ee..9d416839e3be 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus SPI library header
  *

drivers/staging/greybus/svc.h +1 -1

index ad01783bac9c..e7452057cfe4 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus SVC code
  *

Signature · 1 line

2.19.1

Greg KH

maintainer

2018-11-05 14:28 UTC #18 lore raw

In reply to Ioannis Valasakis

Quoted 17 lines · Ioannis Valasakis

staging: greybus: Various code cleanups reported by checkpatch.
Ioannis Valasakis (14):
staging: greybus Align parameters to parentheses
staging: greybus Add a blank line after declaration
staging: greybus Fix SPDX identifier
staging: greybus Align arguments with parentheses
staging: greybus Shorten comparison to NULL
staging: greybus Correct SPDX License Identifier
staging: greybus Remove multiple blank lines
staging: greybus Insert empty line after struct
staging: greybus Remove space before tab
staging: greybus: cleanup long line in gb_uart_probe()
staging: greybus: remove multiple blank lines
staging: greybus: Add extra space around OR operator
staging: greybus: remove extra space before tab
staging: greybus: correct SPDX license identifiers

You can see the missed ":" very easily here. It's a good check to verify that you got the text correct to look at this output.

thanks,

greg k-h