Skip to contentSkip to conversation

KVM: PPC: Book3S HV: Change to use DEFINE_SHOW_ATTRIBUTE macro

PATCH In review Yangtao Li 2 participants 3 messages Nov 5, 2018 – Dec 18, 2018

Subsystems (2)
PowerPC KVM PowerPC
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 KVM: PPC: Book3S HV: Change to use DEFINE_SHOW_ATTRIBUTE macro

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 arch/powerpc/kvm/book3s_xics.c | 12 +-----------
 arch/powerpc/kvm/book3s_xive.c | 12 +-----------
 2 files changed, 2 insertions(+), 22 deletions(-)
arch/powerpc/kvm/book3s_xics.c +1 -11
index b8356cdc0c04..8fdc8eb77039 100644
@@ -1017,17 +1017,7 @@ static int xics_debug_show(struct seq_file *m, void *private)
 	return 0;
 }
 
-static int xics_debug_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, xics_debug_show, inode->i_private);
-}
-
-static const struct file_operations xics_debug_fops = {
-	.open = xics_debug_open,
-	.read = seq_read,
-	.llseek = seq_lseek,
-	.release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(xics_debug);
 
 static void xics_debugfs_init(struct kvmppc_xics *xics)
 {
arch/powerpc/kvm/book3s_xive.c +1 -11
index 30c2eb766954..57ef1502a52c 100644
@@ -1905,17 +1905,7 @@ static int xive_debug_show(struct seq_file *m, void *private)
 	return 0;
 }
 
-static int xive_debug_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, xive_debug_show, inode->i_private);
-}
-
-static const struct file_operations xive_debug_fops = {
-	.open = xive_debug_open,
-	.read = seq_read,
-	.llseek = seq_lseek,
-	.release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(xive_debug);
 
 static void xive_debugfs_init(struct kvmppc_xive *xive)
 {
Signature · 1 line
2.17.0