Skip to contentSkip to conversation

nvme: fixup ANA group descriptor offset

PATCH New Hannes Reinecke 4 participants 4 messages Nov 5, 2018 – Nov 8, 2018 NVMe

lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 1/1 nvme: fixup ANA group descriptor offset

The ANA group descriptor offset changed between the specification sent for ratification and the final ratified document, causing the ANA log page not to be displayed correctly.

Signed-off-by Hannes Reinecke <hare at suse.com>
---
 linux/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/nvme.h +1 -1
index 37d3bc1..1ad970a 100644
@@ -546,7 +546,7 @@ struct nvme_ana_group_desc {
 	__le32  nnsids;
 	__le64  chgcnt;
 	__u8    state;
-	__u8    rsvd17[7];
+	__u8    rsvd17[15];
 	__le32  nsids[];
 };
Signature · 1 line
2.13.7
#1 lore raw

PATCH 1/1 nvme: fixup ANA group descriptor offset

Quoted 25 lines

From: Linux-nvme <linux-nvme-bounces at lists.infradead.org> On Behalf Of Hannes Reinecke

The ANA group descriptor offset changed between the specification sent for ratification and the final ratified document, causing the ANA log page not to be displayed correctly.

Signed-off-by Hannes Reinecke <hare at suse.com>
---
 linux/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/nvme.h +1 -2
index 37d3bc1..1ad970a 100644
@@ -546,7 +546,7 @@ struct nvme_ana_group_desc {
        __le32  nnsids;
        __le64  chgcnt;
        __u8    state;
-       __u8    rsvd17[7];
+       __u8    rsvd17[15];
        __le32  nsids[];
 };
 
--
Quoted 1 line

2.13.7

Thanks, I was just getting ready to create a patch for this.

Reviewed-by Steve Schremmer <steve.schremmer at netapp.com>
Applied
#2 lore raw

PATCH 1/1 nvme: fixup ANA group descriptor offset

Quoted 24 lines · Steven
Quoted 24 lines

From: Linux-nvme <linux-nvme-bounces at lists.infradead.org> On Behalf Of Hannes Reinecke

The ANA group descriptor offset changed between the specification sent for ratification and the final ratified document, causing the ANA log page not to be displayed correctly.

Signed-off-by Hannes Reinecke <hare at suse.com>
---
 linux/nvme.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
linux/nvme.h +1 -1
index 37d3bc1..1ad970a 100644
@@ -546,7 +546,7 @@ struct nvme_ana_group_desc {
        __le32  nnsids;
        __le64  chgcnt;
        __u8    state;
-       __u8    rsvd17[7];
+       __u8    rsvd17[15];
        __le32  nsids[];
 };
Quoted 7 lines
Quoted 2 lines

--
2.13.7

Thanks, I was just getting ready to create a patch for this.

Reviewed-by Steve Schremmer <steve.schremmer at netapp.com>

Applied, thanks!

maintainer
#3 lore raw

PATCH 1/1 nvme: fixup ANA group descriptor offset

In reply to Hannes Reinecke
Quoted 3 lines · Hannes Reinecke

The ANA group descriptor offset changed between the specification sent for ratification and the final ratified document, causing the ANA log page not to be displayed correctly.

Please fix the subject line, this is a nvme-cli patch.