Skip to contentSkip to conversation

Cleanup runtests containing duplicate definitions

RFC PATCH New Petr Vorel 3 participants 9 messages Oct 15, 2018 – Nov 6, 2018 Kbuild

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

cover Cleanup runtests containing duplicate definitions

Hi,

anyone using these? Objections?
IMHO there is no point trying to keep them sync.

Kind regards,
Petr

Petr Vorel (2):
Remove LTP stress tests
Remove ltplite and runltplite.sh

 Makefile                 |    2 +-
 doc/ltp-run-files.txt    |    3 -
 runltplite.sh            |  392 --------------
 runtest/ltplite          | 1113 --------------------------------------
 runtest/stress.part1     |  209 -------
 runtest/stress.part2     |   53 --
 runtest/stress.part3     |  893 ------------------------------
 testscripts/ltpstress.sh |  349 ------------
 8 files changed, 1 insertion(+), 3013 deletions(-)
 delete mode 100755 runltplite.sh
 delete mode 100644 runtest/ltplite
 delete mode 100644 runtest/stress.part1
 delete mode 100644 runtest/stress.part2
 delete mode 100644 runtest/stress.part3
 delete mode 100755 testscripts/ltpstress.sh
Signature · 1 line
2.19.0
author
#1 lore raw

RFC PATCH 1/2 Remove LTP stress tests

ltpstress.sh runs stress.part[1-3]. But these runtest files just duplicate definitions:
* stress.part1: fs, mm, nfs
* stress.part2: ipc, math, nptl
* stress.part3: net.multicast, pty, syscalls

Definitions are outdated anyway. There is no point trying trying to keep them sync.

---
 doc/ltp-run-files.txt    |   3 -
 runtest/stress.part1     | 209 ---------
 runtest/stress.part2     |  53 ---
 runtest/stress.part3     | 893 ---------------------------------------
 testscripts/ltpstress.sh | 349 ---------------
 5 files changed, 1507 deletions(-)
 delete mode 100644 runtest/stress.part1
 delete mode 100644 runtest/stress.part2
 delete mode 100644 runtest/stress.part3
 delete mode 100755 testscripts/ltpstress.sh
doc/ltp-run-files.txt +0 -3
index f8cc36b9e..c29086987 100644
@@ -75,9 +75,6 @@ other filesystem or disk type tests
  - isofs.sh
  - sysfs.sh
 
-LTP Stress tests
- - ltpstress.sh
-
 AIO/DIO filesystem tests
  - ltp-aiodio.sh
 
runtest/stress.part1 deleted +0 -209

209 lines not on this page · raw message

runtest/stress.part2 deleted +0 -53

53 lines not on this page · raw message

runtest/stress.part3 deleted +0 -893

893 lines not on this page · raw message

testscripts/ltpstress.sh deleted +0 -349

349 lines not on this page · raw message

Signature · 1 line
2.19.0
author
#2 lore raw

RFC PATCH 2/2 Remove ltplite and runltplite.sh

In reply to Petr Vorel

ltplite was meant to be used as a quick test for install base. It contains duplicate definitions:
fs, ipc, math, mm, nptl, pty, sched, syscalls

Definitions are outdated anyway. There is no point trying trying to keep them sync.

---
 Makefile        |    2 +-
 runltplite.sh   |  392 -----------------
 runtest/ltplite | 1113 -----------------------------------------------
 3 files changed, 1 insertion(+), 1506 deletions(-)
 delete mode 100755 runltplite.sh
 delete mode 100644 runtest/ltplite
Makefile +1 -1
index b0368a472..bcadd21b2 100644
@@ -163,7 +163,7 @@ clean:: $(CLEAN_TARGETS)
 $(foreach tgt,$(MAKE_TARGETS) include-all lib-all $(filter-out clean_install_dir,$(CLEAN_TARGETS)) $(INSTALL_TARGETS) include-install lib-install,$(eval $(call target_to_dir_dep_mapping,$(tgt))))
 
 BINDIR_INSTALL_SCRIPTS	:= execltp
-SRCDIR_INSTALL_SCRIPTS	:= IDcheck.sh runltp runltplite.sh ver_linux
+SRCDIR_INSTALL_SCRIPTS	:= IDcheck.sh runltp ver_linux
 SRCDIR_INSTALL_READONLY	:= Version
 SRCDIR_INSTALL_TARGETS	:= $(SRCDIR_INSTALL_SCRIPTS) $(SRCDIR_INSTALL_READONLY)
 
runltplite.sh deleted +0 -392

392 lines not on this page · raw message

runtest/ltplite deleted +0 -1113

1,113 lines not on this page · raw message

Signature · 1 line
2.19.0
author
#3 lore raw

cover Cleanup runtests containing duplicate definitions

In reply to Petr Vorel

Hi,

Quoted 2 lines

anyone using these? Objections?
IMHO there is no point trying to keep them sync.

It looks like no objection to this, so I'll remove it.

Kind regards,
Petr

#4 lore raw

cover Cleanup runtests containing duplicate definitions

Jan, did we internal ltp-lite take reference from the ltplite file? I wanna know how do we customize our internal ltp-lite testcases.

-- Sending by my PH1 phone.

Quoted 9 lines · On Mon, Nov 5, 2018, 19:43 Petr Vorel <[email protected] wrote:

Hi,

Quoted 2 lines

anyone using these? Objections?
IMHO there is no point trying to keep them sync.

It looks like no objection to this, so I'll remove it.

Kind regards,
Petr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20181105/c898e360/attachment.html>

#5 lore raw

cover Cleanup runtests containing duplicate definitions

----- Original Message -----

Quoted 1 line

Jan, did we internal ltp-lite take reference from the ltplite file?

Probably only at the beginning, when original author of beaker test forked ltplite runtest file. I've been using syscalls/other runtest files, since those are more up to date.

Quoted 2 lines

I wanna
know how do we customize our internal ltp-lite testcases.

syscalls + cherry-picked tests from other runtest files. We might be getting off-topic w.r.t this mailing list.

Regards,
Jan

Quoted 15 lines

-- Sending by my PH1 phone.

Quoted 9 lines · On Mon, Nov 5, 2018, 19:43 Petr Vorel <[email protected] wrote:

Hi,

Quoted 2 lines

anyone using these? Objections?
IMHO there is no point trying to keep them sync.

It looks like no objection to this, so I'll remove it.

Kind regards,
Petr

author
#6 lore raw

cover Cleanup runtests containing duplicate definitions

Hi Jan, Li,

Quoted 10 lines
Quoted 1 line

Jan, did we internal ltp-lite take reference from the ltplite file?

Probably only at the beginning, when original author of beaker test forked ltplite runtest file. I've been using syscalls/other runtest files, since those are more up to date.

Quoted 2 lines

I wanna
know how do we customize our internal ltp-lite testcases.

syscalls + cherry-picked tests from other runtest files.

Is it problematic for you to remove these runtest files?
Hope not, but if yes, please let me know. I'll wait for your ack before removing it.

Kind regards,
Petr

#7 lore raw

cover Cleanup runtests containing duplicate definitions

Quoted 8 lines · Petr Vorel

Hi Jan, Li,

Quoted 5 lines
Quoted 1 line

Jan, did we internal ltp-lite take reference from the ltplite file?

Probably only at the beginning, when original author of beaker test forked ltplite runtest file. I've been using syscalls/other runtest files, since those are more up to date.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

I wanna
know how do we customize our internal ltp-lite testcases.

syscalls + cherry-picked tests from other runtest files.

Is it problematic for you to remove these runtest files?

I think we're OK to remove that in upstream.

Quoted 6 lines

Hope not, but if yes, please let me know. I'll wait for your ack before removing it.

Kind regards,
Petr

Signature · 5 lines
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20181106/db4c71ad/attachment.html>
author
#8 lore raw

cover Cleanup runtests containing duplicate definitions

Hi Li,

Quoted 13 lines · Petr Vorel
Quoted 11 lines

Hi Jan, Li,

Quoted 8 lines
Quoted 1 line

Jan, did we internal ltp-lite take reference from the ltplite file?

Probably only at the beginning, when original author of beaker test forked ltplite runtest file. I've been using syscalls/other runtest files, since those are more up to date.

Quoted 2 lines

I wanna
know how do we customize our internal ltp-lite testcases.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

syscalls + cherry-picked tests from other runtest files.

Is it problematic for you to remove these runtest files?

I think we're OK to remove that in upstream.

Thanks for info, pushed.

Kind regards,
Petr