Skip to contentSkip to conversation

dmaengine: pxa: make the filter function internal

PATCH RESEND New Daniel Mack 3 participants 4 messages Nov 5, 2018 – Nov 7, 2018

Subsystems (2)
dmaengine PXA2xx/PXA3xx support
lore
Share & tools
lore

Daniel Mack

author maintainer
#0 lore raw

PATCH RESEND 1/1 dmaengine: pxa: make the filter function internal

From: Robert Jarzmik <[email protected]>

As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace.

Signed-off-by Robert Jarzmik <[email protected]>
Acked-by Vinod Koul <[email protected]>

---

I'm resending this as it appears to be the last patch that's missing from the PXA DMA transition series.

Robert, any reason why it wasn't applied?

Thanks,
Daniel

 drivers/dma/pxa_dma.c       |  5 ++---
 include/linux/dma/pxa-dma.h | 11 -----------
 2 files changed, 2 insertions(+), 14 deletions(-)
drivers/dma/pxa_dma.c +2 -3
index 825725057e00..c7a328f81485 100644
@@ -179,7 +179,7 @@ static unsigned int pxad_drcmr(unsigned int line)
 	return 0x1000 + line * 4;
 }
 
-bool pxad_filter_fn(struct dma_chan *chan, void *param);
+static bool pxad_filter_fn(struct dma_chan *chan, void *param);
 
 /*
  * Debug fs

@@ -1500,7 +1500,7 @@ static struct platform_driver pxad_driver = {
 	.remove		= pxad_remove,
 };
 
-bool pxad_filter_fn(struct dma_chan *chan, void *param)
+static bool pxad_filter_fn(struct dma_chan *chan, void *param)
 {
 	struct pxad_chan *c = to_pxad_chan(chan);
 	struct pxad_param *p = param;

@@ -1513,7 +1513,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param)
 
 	return true;
 }
-EXPORT_SYMBOL_GPL(pxad_filter_fn);
 
 module_platform_driver(pxad_driver);
include/linux/dma/pxa-dma.h +0 -11
index 9fc594f69eff..fceb5df07097 100644
@@ -23,15 +23,4 @@ struct pxad_param {
 	enum pxad_chan_prio prio;
 };
 
-struct dma_chan;
-
-#ifdef CONFIG_PXA_DMA
-bool pxad_filter_fn(struct dma_chan *chan, void *param);
-#else
-static inline bool pxad_filter_fn(struct dma_chan *chan, void *param)
-{
-	return false;
-}
-#endif
-
 #endif /* _PXA_DMA_H_ */
Signature · 1 line
2.17.2
maintainer
#1 lore raw

PATCH RESEND 1/1 dmaengine: pxa: make the filter function internal

Quoted 6 lines · Daniel Mack

From: Robert Jarzmik <[email protected]>

As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace.

Quoted 8 lines
Signed-off-by Robert Jarzmik <[email protected]>
Acked-by Vinod Koul <[email protected]>

---

I'm resending this as it appears to be the last patch that's missing from the PXA DMA transition series.

Robert, any reason why it wasn't applied?

Ah this is because my pull request was ... not taken into account.

Arnd, Kevin, Olof, did you receive this
https://www.spinics.net/lists/arm-kernel/msg679383.html ? It might be my mailer getting me into trouble once more.

Cheers.

--
Robert

#2 lore raw

PATCH RESEND 1/1 dmaengine: pxa: make the filter function internal

Quoted 16 lines · Robert Jarzmik
Quoted 13 lines · Daniel Mack

From: Robert Jarzmik <[email protected]>

As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace.

Signed-off-by Robert Jarzmik <[email protected]>
Acked-by Vinod Koul <[email protected]>

---

I'm resending this as it appears to be the last patch that's missing from the PXA DMA transition series.

Quoted 6 lines
Quoted 1 line

Robert, any reason why it wasn't applied?

Ah this is because my pull request was ... not taken into account.

Arnd, Kevin, Olof, did you receive this
https://www.spinics.net/lists/arm-kernel/msg679383.html ? It might be my mailer getting me into trouble once more.

I only have a record of the DT pull request here, so yeah, something must have happened to that one. It's odd that it got to the archive but not my mail client though.

Either that, or it got labelled as Spam and auto-purged since it was a little while ago.

In the future, if we haven't merged in 1 or 2 weeks, feel free to ping.

-Olof

-Olof

maintainer
#3 lore raw

PATCH RESEND 1/1 dmaengine: pxa: make the filter function internal

Quoted 8 lines · Olof Johansson
Quoted 6 lines · Robert Jarzmik
Quoted 1 line

Robert, any reason why it wasn't applied?

Ah this is because my pull request was ... not taken into account.

Arnd, Kevin, Olof, did you receive this
https://www.spinics.net/lists/arm-kernel/msg679383.html ? It might be my mailer getting me into trouble once more.

Quoted 8 lines

I only have a record of the DT pull request here, so yeah, something must have happened to that one. It's odd that it got to the archive but not my mail client though.

Either that, or it got labelled as Spam and auto-purged since it was a little while ago.

In the future, if we haven't merged in 1 or 2 weeks, feel free to ping.

Okay, but not worries, that's more a "cleanup" stuff which can miss one cycle. It was so small I didn't even bother checking linux-next at the time, and it will just shift to the next pull request.

Cheers.

Signature · 1 line
Robert