Skip to contentSkip to conversation

target/core: Avoid that a kernel oops is triggered when COMPARE AND WRITE fails

PATCH Applied Bart Van Assche 2 participants 2 messages Nov 6, 2018 SCSI target

lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH v3 1/1 target/core: Avoid that a kernel oops is triggered when COMPARE AND WRITE fails

Fixes aa73237dcb2d ("scsi: target/core: Always call transport_complete_callback() upon failure")
Reviewed-by David Disseldorp <[email protected]>
Cc Nicholas Bellinger <[email protected]>
Cc Mike Christie <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Hannes Reinecke <[email protected]>
Signed-off-by Bart Van Assche <[email protected]>

---

Changes:
- v2 -> v3: modified patch title
- v1 -> v2: changed approach of this patch as requested by David Disseldorp.

 drivers/target/target_core_transport.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/target/target_core_transport.c +2 -2
index e31e4fc31aa1..2cfd61d62e97 100644
@@ -1778,7 +1778,7 @@ EXPORT_SYMBOL(target_submit_tmr);
 void transport_generic_request_failure(struct se_cmd *cmd,
 		sense_reason_t sense_reason)
 {
-	int ret = 0;
+	int ret = 0, post_ret;
 
 	pr_debug("-----[ Storage Engine Exception; sense_reason %d\n",
 		 sense_reason);

@@ -1790,7 +1790,7 @@ void transport_generic_request_failure(struct se_cmd *cmd,
 	transport_complete_task_attr(cmd);
 
 	if (cmd->transport_complete_callback)
-		cmd->transport_complete_callback(cmd, false, NULL);
+		cmd->transport_complete_callback(cmd, false, &post_ret);
 
 	if (transport_check_aborted_status(cmd, 1))
 		return;
Signature · 1 line
2.19.1.930.g4563a0d9d0-goog
Applied
#1 lore raw

Bart,

Quoted 1 line
Fixes aa73237dcb2d ("scsi: target/core: Always call transport_complete_callback() upon failure")

Applied to 4.20/scsi-fixes. Thank you!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering