mm: Create the new vm_fault_t type
Subsystems (2)
PATCH v3 1/1 mm: Create the new vm_fault_t type
Page fault handlers are supposed to return VM_FAULT codes, but some drivers/file systems mistakenly return error numbers. Now that all drivers/file systems have been converted to use the vm_fault_t return type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not a VM_FAULT code.
VM_FAULT_SET_HINDEX and VM_FAULT_GET_HINDEX values are changed to avoid conflict with other VM_FAULT codes.
---
v2: Updated the change log and corrected the document part.
name added to the enum that kernel-doc able to parse it.
v3: Corrected the documentation.
include/linux/mm.h | 46 ------------------------------ include/linux/mm_types.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 47 deletions(-)
include/linux/mm.h +0 -46
@@ -1267,52 +1267,6 @@ static inline void clear_page_pfmemalloc(struct page *page) }/* -* Different kinds of faults, as returned by handle_mm_fault(). -* Used to decide whether a process gets delivered SIGBUS or -* just gets major/minor fault counters bumped up. -*/ - -#define VM_FAULT_OOM 0x0001 -#define VM_FAULT_SIGBUS 0x0002 -#define VM_FAULT_MAJOR 0x0004 -#define VM_FAULT_WRITE 0x0008/* Special case for get_user_pages */ -#define VM_FAULT_HWPOISON 0x0010/* Hit poisoned small page */ -#define VM_FAULT_HWPOISON_LARGE 0x0020/* Hit poisoned large page. Index encoded in upper bits */ -#define VM_FAULT_SIGSEGV 0x0040 - -#define VM_FAULT_NOPAGE 0x0100/* ->fault installed the pte, not return page */ -#define VM_FAULT_LOCKED 0x0200/* ->fault locked the returned page */ -#define VM_FAULT_RETRY 0x0400/* ->fault blocked, must retry */ -#define VM_FAULT_FALLBACK 0x0800/* huge page fault failed, fall back to small */ -#define VM_FAULT_DONE_COW 0x1000/* ->fault has fully handled COW */ -#define VM_FAULT_NEEDDSYNC 0x2000/* ->fault did not modify page tables -* and needs fsync() to complete (for -* synchronous page faults in DAX) */ - -#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_SIGSEGV | \ - VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_LARGE | \ - VM_FAULT_FALLBACK) - -#define VM_FAULT_RESULT_TRACE \ - { VM_FAULT_OOM, "OOM" }, \ - { VM_FAULT_SIGBUS, "SIGBUS" }, \ - { VM_FAULT_MAJOR, "MAJOR" }, \ - { VM_FAULT_WRITE, "WRITE" }, \ - { VM_FAULT_HWPOISON, "HWPOISON" }, \ - { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ - { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ - { VM_FAULT_NOPAGE, "NOPAGE" }, \ - { VM_FAULT_LOCKED, "LOCKED" }, \ - { VM_FAULT_RETRY, "RETRY" }, \ - { VM_FAULT_FALLBACK, "FALLBACK" }, \ - { VM_FAULT_DONE_COW, "DONE_COW" }, \ - { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } - -/* Encode hstate index for a hwpoisoned large page */ -#define VM_FAULT_SET_HINDEX (x) ((x) << 12) -#define VM_FAULT_GET_HINDEX (x) (((x) >> 12) & 0xf) - -/* * Can be called by the pagefault handler when it gets a VM_FAULT_OOM. */ extern void pagefault_out_of_memory (void );
include/linux/mm_types.h +72 -1
85 lines not on this page · raw message
Signature · 1 line
1.9.1
[off-list]
Please do not submit a new version of the patch just after a minor feedback to the documentation. Wait for some more feedback. Sending 3 versions in about 2 days is just way too much.
Thanks!
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 10 lines · Souptick Joarder
Page fault handlers are supposed to return
VM_FAULTcodes, but somedrivers/filesystems mistakenly return error numbers. Now that alldrivers/filesystems have been converted to use thevm_fault_treturn type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not aVM_FAULTcode.
Quoted 4 lines
VM_FAULT_SET_HINDEXandVM_FAULT_GET_HINDEXvalues are changed to avoid conflict with otherVM_FAULTcodes.Signed-off-by Souptick Joarder <[email protected]>
Any further comment on this patch ?
Quoted 161 lines
---
v2: Updated the change log and corrected the document part.
name added to the enum that kernel-doc able to parse it.v3: Corrected the documentation.
include/linux/mm.h | 46 ------------------------------ include/linux/mm_types.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 47 deletions(-)include/linux/mm.h +0
-46@@ -1267,52 +1267,6 @@ static inline void clear_page_pfmemalloc(struct page *page) }/* -* Different kinds of faults, as returned by handle_mm_fault(). -* Used to decide whether a process gets delivered SIGBUS or -* just gets major/minor fault counters bumped up. -*/ - -#define VM_FAULT_OOM 0x0001 -#define VM_FAULT_SIGBUS 0x0002 -#define VM_FAULT_MAJOR 0x0004 -#define VM_FAULT_WRITE 0x0008/* Special case for get_user_pages */ -#define VM_FAULT_HWPOISON 0x0010/* Hit poisoned small page */ -#define VM_FAULT_HWPOISON_LARGE 0x0020/* Hit poisoned large page. Index encoded in upper bits */ -#define VM_FAULT_SIGSEGV 0x0040 - -#define VM_FAULT_NOPAGE 0x0100/* ->fault installed the pte, not return page */ -#define VM_FAULT_LOCKED 0x0200/* ->fault locked the returned page */ -#define VM_FAULT_RETRY 0x0400/* ->fault blocked, must retry */ -#define VM_FAULT_FALLBACK 0x0800/* huge page fault failed, fall back to small */ -#define VM_FAULT_DONE_COW 0x1000/* ->fault has fully handled COW */ -#define VM_FAULT_NEEDDSYNC 0x2000/* ->fault did not modify page tables -* and needs fsync() to complete (for -* synchronous page faults in DAX) */ - -#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_SIGSEGV | \ - VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_LARGE | \ - VM_FAULT_FALLBACK) - -#define VM_FAULT_RESULT_TRACE \ - { VM_FAULT_OOM, "OOM" }, \ - { VM_FAULT_SIGBUS, "SIGBUS" }, \ - { VM_FAULT_MAJOR, "MAJOR" }, \ - { VM_FAULT_WRITE, "WRITE" }, \ - { VM_FAULT_HWPOISON, "HWPOISON" }, \ - { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ - { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ - { VM_FAULT_NOPAGE, "NOPAGE" }, \ - { VM_FAULT_LOCKED, "LOCKED" }, \ - { VM_FAULT_RETRY, "RETRY" }, \ - { VM_FAULT_FALLBACK, "FALLBACK" }, \ - { VM_FAULT_DONE_COW, "DONE_COW" }, \ - { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } - -/* Encode hstate index for a hwpoisoned large page */ -#define VM_FAULT_SET_HINDEX (x) ((x) << 12) -#define VM_FAULT_GET_HINDEX (x) (((x) >> 12) & 0xf) - -/* * Can be called by the pagefault handler when it gets a VM_FAULT_OOM. */ extern void pagefault_out_of_memory (void );include/linux/mm_types.h +72
-2@@ -22,7 +22,6 @@#endif #define AT_VECTOR_SIZE (2*(AT_VECTOR_SIZE_ARCH + AT_VECTOR_SIZE_BASE + 1)) -typedef int vm_fault_t ;struct address_space ;struct mem_cgroup ;@@ -609,6 +608,78 @@ static inline bool mm_tlb_flush_nested(struct mm_struct *mm)struct vm_fault ; +/** +* typedef vm_fault_t - Return type for page fault handlers. +* +* Page fault handlers return a bitmask of %VM_FAULT values. +*/ +typedef __bitwise unsigned int vm_fault_t ; + +/** +* enum vm_fault_reason - Page fault handlers return a bitmask of +* these values to tell the core VM what happened when handling the +* fault. Used to decide whether a process gets delivered SIGBUS or +* just gets major/minor fault counters bumped up. +* +* @VM_FAULT_OOM: Out Of Memory +* @VM_FAULT_SIGBUS: Bad access +* @VM_FAULT_MAJOR: Page read from storage +* @VM_FAULT_WRITE: Special case for get_user_pages +* @VM_FAULT_HWPOISON: Hit poisoned small page +* @VM_FAULT_HWPOISON_LARGE: Hit poisoned large page. Index encoded +* in upper bits +* @VM_FAULT_SIGSEGV: segmentation fault +* @VM_FAULT_NOPAGE: ->fault installed the pte, not return page +* @VM_FAULT_LOCKED: ->fault locked the returned page +* @VM_FAULT_RETRY: ->fault blocked, must retry +* @VM_FAULT_FALLBACK: huge page fault failed, fall back to small +* @VM_FAULT_DONE_COW: ->fault has fully handled COW +* @VM_FAULT_NEEDDSYNC: ->fault did not modify page tables and needs +* fsync() to complete (for synchronous page faults +* in DAX) +* @VM_FAULT_HINDEX_MASK: mask HINDEX value +* +*/ +enum vm_fault_reason { +VM_FAULT_OOM = (__force vm_fault_t )0x000001 , +VM_FAULT_SIGBUS = (__force vm_fault_t )0x000002 , +VM_FAULT_MAJOR = (__force vm_fault_t )0x000004 , +VM_FAULT_WRITE = (__force vm_fault_t )0x000008 , +VM_FAULT_HWPOISON = (__force vm_fault_t )0x000010 , +VM_FAULT_HWPOISON_LARGE = (__force vm_fault_t )0x000020 , +VM_FAULT_SIGSEGV = (__force vm_fault_t )0x000040 , +VM_FAULT_NOPAGE = (__force vm_fault_t )0x000100 , +VM_FAULT_LOCKED = (__force vm_fault_t )0x000200 , +VM_FAULT_RETRY = (__force vm_fault_t )0x000400 , +VM_FAULT_FALLBACK = (__force vm_fault_t )0x000800 , +VM_FAULT_DONE_COW = (__force vm_fault_t )0x001000 , +VM_FAULT_NEEDDSYNC = (__force vm_fault_t )0x002000 , +VM_FAULT_HINDEX_MASK = (__force vm_fault_t )0x0f0000 , +}; + +/* Encode hstate index for a hwpoisoned large page */ +#define VM_FAULT_SET_HINDEX (x) ((__force vm_fault_t)((x) << 16)) +#define VM_FAULT_GET_HINDEX (x) (((x) >> 16) & 0xf) + +#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | \ + VM_FAULT_SIGSEGV | VM_FAULT_HWPOISON | \ + VM_FAULT_HWPOISON_LARGE | VM_FAULT_FALLBACK) + +#define VM_FAULT_RESULT_TRACE \ + { VM_FAULT_OOM, "OOM" }, \ + { VM_FAULT_SIGBUS, "SIGBUS" }, \ + { VM_FAULT_MAJOR, "MAJOR" }, \ + { VM_FAULT_WRITE, "WRITE" }, \ + { VM_FAULT_HWPOISON, "HWPOISON" }, \ + { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ + { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ + { VM_FAULT_NOPAGE, "NOPAGE" }, \ + { VM_FAULT_LOCKED, "LOCKED" }, \ + { VM_FAULT_RETRY, "RETRY" }, \ + { VM_FAULT_FALLBACK, "FALLBACK" }, \ + { VM_FAULT_DONE_COW, "DONE_COW" }, \ + { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } +struct vm_special_mapping {const char *name;/* The name, e.g. "[vdso]". */ --1.9.1
William Kucharski
Reviewed-byQuoted 15 lines · Souptick Joarder
Quoted 10 lines · Souptick Joarder
Page fault handlers are supposed to return
VM_FAULTcodes, but somedrivers/filesystems mistakenly return error numbers. Now that alldrivers/filesystems have been converted to use thevm_fault_treturn type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not aVM_FAULTcode.
Quoted 6 lines
Quoted 4 lines
VM_FAULT_SET_HINDEXandVM_FAULT_GET_HINDEXvalues are changed to avoid conflict with otherVM_FAULTcodes.Signed-off-by Souptick Joarder <[email protected]>Any further comment on this patch ?
Quoted 9 lines · Souptick Joarder
Page fault handlers are supposed to return
VM_FAULTcodes, but somedrivers/filesystems mistakenly return error numbers. Now that alldrivers/filesystems have been converted to use thevm_fault_treturn type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not aVM_FAULTcode.
Quoted 4 lines
VM_FAULT_SET_HINDEXandVM_FAULT_GET_HINDEXvalues are changed to avoid conflict with otherVM_FAULTcodes.Signed-off-by Souptick Joarder <[email protected]>
For the docs part
Quoted 161 lines
---
v2: Updated the change log and corrected the document part.
name added to the enum that kernel-doc able to parse it.v3: Corrected the documentation.
include/linux/mm.h | 46 ------------------------------ include/linux/mm_types.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 47 deletions(-)include/linux/mm.h +0
-46@@ -1267,52 +1267,6 @@ static inline void clear_page_pfmemalloc(struct page *page) }/* -* Different kinds of faults, as returned by handle_mm_fault(). -* Used to decide whether a process gets delivered SIGBUS or -* just gets major/minor fault counters bumped up. -*/ - -#define VM_FAULT_OOM 0x0001 -#define VM_FAULT_SIGBUS 0x0002 -#define VM_FAULT_MAJOR 0x0004 -#define VM_FAULT_WRITE 0x0008/* Special case for get_user_pages */ -#define VM_FAULT_HWPOISON 0x0010/* Hit poisoned small page */ -#define VM_FAULT_HWPOISON_LARGE 0x0020/* Hit poisoned large page. Index encoded in upper bits */ -#define VM_FAULT_SIGSEGV 0x0040 - -#define VM_FAULT_NOPAGE 0x0100/* ->fault installed the pte, not return page */ -#define VM_FAULT_LOCKED 0x0200/* ->fault locked the returned page */ -#define VM_FAULT_RETRY 0x0400/* ->fault blocked, must retry */ -#define VM_FAULT_FALLBACK 0x0800/* huge page fault failed, fall back to small */ -#define VM_FAULT_DONE_COW 0x1000/* ->fault has fully handled COW */ -#define VM_FAULT_NEEDDSYNC 0x2000/* ->fault did not modify page tables -* and needs fsync() to complete (for -* synchronous page faults in DAX) */ - -#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_SIGSEGV | \ - VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_LARGE | \ - VM_FAULT_FALLBACK) - -#define VM_FAULT_RESULT_TRACE \ - { VM_FAULT_OOM, "OOM" }, \ - { VM_FAULT_SIGBUS, "SIGBUS" }, \ - { VM_FAULT_MAJOR, "MAJOR" }, \ - { VM_FAULT_WRITE, "WRITE" }, \ - { VM_FAULT_HWPOISON, "HWPOISON" }, \ - { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ - { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ - { VM_FAULT_NOPAGE, "NOPAGE" }, \ - { VM_FAULT_LOCKED, "LOCKED" }, \ - { VM_FAULT_RETRY, "RETRY" }, \ - { VM_FAULT_FALLBACK, "FALLBACK" }, \ - { VM_FAULT_DONE_COW, "DONE_COW" }, \ - { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } - -/* Encode hstate index for a hwpoisoned large page */ -#define VM_FAULT_SET_HINDEX (x) ((x) << 12) -#define VM_FAULT_GET_HINDEX (x) (((x) >> 12) & 0xf) - -/* * Can be called by the pagefault handler when it gets a VM_FAULT_OOM. */ extern void pagefault_out_of_memory (void );include/linux/mm_types.h +72
-1@@ -22,7 +22,6 @@#endif #define AT_VECTOR_SIZE (2*(AT_VECTOR_SIZE_ARCH + AT_VECTOR_SIZE_BASE + 1)) -typedef int vm_fault_t ;struct address_space ;struct mem_cgroup ;@@ -609,6 +608,78 @@ static inline bool mm_tlb_flush_nested(struct mm_struct *mm)struct vm_fault ; +/** +* typedef vm_fault_t - Return type for page fault handlers. +* +* Page fault handlers return a bitmask of %VM_FAULT values. +*/ +typedef __bitwise unsigned int vm_fault_t ; + +/** +* enum vm_fault_reason - Page fault handlers return a bitmask of +* these values to tell the core VM what happened when handling the +* fault. Used to decide whether a process gets delivered SIGBUS or +* just gets major/minor fault counters bumped up. +* +* @VM_FAULT_OOM: Out Of Memory +* @VM_FAULT_SIGBUS: Bad access +* @VM_FAULT_MAJOR: Page read from storage +* @VM_FAULT_WRITE: Special case for get_user_pages +* @VM_FAULT_HWPOISON: Hit poisoned small page +* @VM_FAULT_HWPOISON_LARGE: Hit poisoned large page. Index encoded +* in upper bits +* @VM_FAULT_SIGSEGV: segmentation fault +* @VM_FAULT_NOPAGE: ->fault installed the pte, not return page +* @VM_FAULT_LOCKED: ->fault locked the returned page +* @VM_FAULT_RETRY: ->fault blocked, must retry +* @VM_FAULT_FALLBACK: huge page fault failed, fall back to small +* @VM_FAULT_DONE_COW: ->fault has fully handled COW +* @VM_FAULT_NEEDDSYNC: ->fault did not modify page tables and needs +* fsync() to complete (for synchronous page faults +* in DAX) +* @VM_FAULT_HINDEX_MASK: mask HINDEX value +* +*/ +enum vm_fault_reason { +VM_FAULT_OOM = (__force vm_fault_t )0x000001 , +VM_FAULT_SIGBUS = (__force vm_fault_t )0x000002 , +VM_FAULT_MAJOR = (__force vm_fault_t )0x000004 , +VM_FAULT_WRITE = (__force vm_fault_t )0x000008 , +VM_FAULT_HWPOISON = (__force vm_fault_t )0x000010 , +VM_FAULT_HWPOISON_LARGE = (__force vm_fault_t )0x000020 , +VM_FAULT_SIGSEGV = (__force vm_fault_t )0x000040 , +VM_FAULT_NOPAGE = (__force vm_fault_t )0x000100 , +VM_FAULT_LOCKED = (__force vm_fault_t )0x000200 , +VM_FAULT_RETRY = (__force vm_fault_t )0x000400 , +VM_FAULT_FALLBACK = (__force vm_fault_t )0x000800 , +VM_FAULT_DONE_COW = (__force vm_fault_t )0x001000 , +VM_FAULT_NEEDDSYNC = (__force vm_fault_t )0x002000 , +VM_FAULT_HINDEX_MASK = (__force vm_fault_t )0x0f0000 , +}; + +/* Encode hstate index for a hwpoisoned large page */ +#define VM_FAULT_SET_HINDEX (x) ((__force vm_fault_t)((x) << 16)) +#define VM_FAULT_GET_HINDEX (x) (((x) >> 16) & 0xf) + +#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | \ + VM_FAULT_SIGSEGV | VM_FAULT_HWPOISON | \ + VM_FAULT_HWPOISON_LARGE | VM_FAULT_FALLBACK) + +#define VM_FAULT_RESULT_TRACE \ + { VM_FAULT_OOM, "OOM" }, \ + { VM_FAULT_SIGBUS, "SIGBUS" }, \ + { VM_FAULT_MAJOR, "MAJOR" }, \ + { VM_FAULT_WRITE, "WRITE" }, \ + { VM_FAULT_HWPOISON, "HWPOISON" }, \ + { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ + { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ + { VM_FAULT_NOPAGE, "NOPAGE" }, \ + { VM_FAULT_LOCKED, "LOCKED" }, \ + { VM_FAULT_RETRY, "RETRY" }, \ + { VM_FAULT_FALLBACK, "FALLBACK" }, \ + { VM_FAULT_DONE_COW, "DONE_COW" }, \ + { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } +struct vm_special_mapping {const char *name;/* The name, e.g. "[vdso]". */ Signature · 1 line
1.9.1
Signature · 2 lines
Sincerely yours, Mike.
Quoted 11 lines · Mike Rapoport
Quoted 9 lines · Souptick Joarder
Page fault handlers are supposed to return
VM_FAULTcodes, but somedrivers/filesystems mistakenly return error numbers. Now that alldrivers/filesystems have been converted to use thevm_fault_treturn type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not aVM_FAULTcode.
Quoted 13 lines
Quoted 4 lines
VM_FAULT_SET_HINDEXandVM_FAULT_GET_HINDEXvalues are changed to avoid conflict with otherVM_FAULTcodes.Signed-off-by Souptick Joarder <[email protected]>For the docs part
Reviewed-by Mike Rapoport <[email protected]>Quoted 5 lines
---
v2: Updated the change log and corrected the document part.
name added to the enum that kernel-doc able to parse it.v3: Corrected the documentation.
If no further comment, can we get this patch in queue for 4.21 ?
Quoted 161 lines
Quoted 154 lines
include/linux/mm.h | 46 ------------------------------ include/linux/mm_types.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 47 deletions(-)include/linux/mm.h +0
-46@@ -1267,52 +1267,6 @@ static inline void clear_page_pfmemalloc(struct page *page) }/* -* Different kinds of faults, as returned by handle_mm_fault(). -* Used to decide whether a process gets delivered SIGBUS or -* just gets major/minor fault counters bumped up. -*/ - -#define VM_FAULT_OOM 0x0001 -#define VM_FAULT_SIGBUS 0x0002 -#define VM_FAULT_MAJOR 0x0004 -#define VM_FAULT_WRITE 0x0008/* Special case for get_user_pages */ -#define VM_FAULT_HWPOISON 0x0010/* Hit poisoned small page */ -#define VM_FAULT_HWPOISON_LARGE 0x0020/* Hit poisoned large page. Index encoded in upper bits */ -#define VM_FAULT_SIGSEGV 0x0040 - -#define VM_FAULT_NOPAGE 0x0100/* ->fault installed the pte, not return page */ -#define VM_FAULT_LOCKED 0x0200/* ->fault locked the returned page */ -#define VM_FAULT_RETRY 0x0400/* ->fault blocked, must retry */ -#define VM_FAULT_FALLBACK 0x0800/* huge page fault failed, fall back to small */ -#define VM_FAULT_DONE_COW 0x1000/* ->fault has fully handled COW */ -#define VM_FAULT_NEEDDSYNC 0x2000/* ->fault did not modify page tables -* and needs fsync() to complete (for -* synchronous page faults in DAX) */ - -#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_SIGSEGV | \ - VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_LARGE | \ - VM_FAULT_FALLBACK) - -#define VM_FAULT_RESULT_TRACE \ - { VM_FAULT_OOM, "OOM" }, \ - { VM_FAULT_SIGBUS, "SIGBUS" }, \ - { VM_FAULT_MAJOR, "MAJOR" }, \ - { VM_FAULT_WRITE, "WRITE" }, \ - { VM_FAULT_HWPOISON, "HWPOISON" }, \ - { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ - { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ - { VM_FAULT_NOPAGE, "NOPAGE" }, \ - { VM_FAULT_LOCKED, "LOCKED" }, \ - { VM_FAULT_RETRY, "RETRY" }, \ - { VM_FAULT_FALLBACK, "FALLBACK" }, \ - { VM_FAULT_DONE_COW, "DONE_COW" }, \ - { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } - -/* Encode hstate index for a hwpoisoned large page */ -#define VM_FAULT_SET_HINDEX (x) ((x) << 12) -#define VM_FAULT_GET_HINDEX (x) (((x) >> 12) & 0xf) - -/* * Can be called by the pagefault handler when it gets a VM_FAULT_OOM. */ extern void pagefault_out_of_memory (void );include/linux/mm_types.h +72
-2@@ -22,7 +22,6 @@#endif #define AT_VECTOR_SIZE (2*(AT_VECTOR_SIZE_ARCH + AT_VECTOR_SIZE_BASE + 1)) -typedef int vm_fault_t ;struct address_space ;struct mem_cgroup ;@@ -609,6 +608,78 @@ static inline bool mm_tlb_flush_nested(struct mm_struct *mm)struct vm_fault ; +/** +* typedef vm_fault_t - Return type for page fault handlers. +* +* Page fault handlers return a bitmask of %VM_FAULT values. +*/ +typedef __bitwise unsigned int vm_fault_t ; + +/** +* enum vm_fault_reason - Page fault handlers return a bitmask of +* these values to tell the core VM what happened when handling the +* fault. Used to decide whether a process gets delivered SIGBUS or +* just gets major/minor fault counters bumped up. +* +* @VM_FAULT_OOM: Out Of Memory +* @VM_FAULT_SIGBUS: Bad access +* @VM_FAULT_MAJOR: Page read from storage +* @VM_FAULT_WRITE: Special case for get_user_pages +* @VM_FAULT_HWPOISON: Hit poisoned small page +* @VM_FAULT_HWPOISON_LARGE: Hit poisoned large page. Index encoded +* in upper bits +* @VM_FAULT_SIGSEGV: segmentation fault +* @VM_FAULT_NOPAGE: ->fault installed the pte, not return page +* @VM_FAULT_LOCKED: ->fault locked the returned page +* @VM_FAULT_RETRY: ->fault blocked, must retry +* @VM_FAULT_FALLBACK: huge page fault failed, fall back to small +* @VM_FAULT_DONE_COW: ->fault has fully handled COW +* @VM_FAULT_NEEDDSYNC: ->fault did not modify page tables and needs +* fsync() to complete (for synchronous page faults +* in DAX) +* @VM_FAULT_HINDEX_MASK: mask HINDEX value +* +*/ +enum vm_fault_reason { +VM_FAULT_OOM = (__force vm_fault_t )0x000001 , +VM_FAULT_SIGBUS = (__force vm_fault_t )0x000002 , +VM_FAULT_MAJOR = (__force vm_fault_t )0x000004 , +VM_FAULT_WRITE = (__force vm_fault_t )0x000008 , +VM_FAULT_HWPOISON = (__force vm_fault_t )0x000010 , +VM_FAULT_HWPOISON_LARGE = (__force vm_fault_t )0x000020 , +VM_FAULT_SIGSEGV = (__force vm_fault_t )0x000040 , +VM_FAULT_NOPAGE = (__force vm_fault_t )0x000100 , +VM_FAULT_LOCKED = (__force vm_fault_t )0x000200 , +VM_FAULT_RETRY = (__force vm_fault_t )0x000400 , +VM_FAULT_FALLBACK = (__force vm_fault_t )0x000800 , +VM_FAULT_DONE_COW = (__force vm_fault_t )0x001000 , +VM_FAULT_NEEDDSYNC = (__force vm_fault_t )0x002000 , +VM_FAULT_HINDEX_MASK = (__force vm_fault_t )0x0f0000 , +}; + +/* Encode hstate index for a hwpoisoned large page */ +#define VM_FAULT_SET_HINDEX (x) ((__force vm_fault_t)((x) << 16)) +#define VM_FAULT_GET_HINDEX (x) (((x) >> 16) & 0xf) + +#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | \ + VM_FAULT_SIGSEGV | VM_FAULT_HWPOISON | \ + VM_FAULT_HWPOISON_LARGE | VM_FAULT_FALLBACK) + +#define VM_FAULT_RESULT_TRACE \ + { VM_FAULT_OOM, "OOM" }, \ + { VM_FAULT_SIGBUS, "SIGBUS" }, \ + { VM_FAULT_MAJOR, "MAJOR" }, \ + { VM_FAULT_WRITE, "WRITE" }, \ + { VM_FAULT_HWPOISON, "HWPOISON" }, \ + { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ + { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ + { VM_FAULT_NOPAGE, "NOPAGE" }, \ + { VM_FAULT_LOCKED, "LOCKED" }, \ + { VM_FAULT_RETRY, "RETRY" }, \ + { VM_FAULT_FALLBACK, "FALLBACK" }, \ + { VM_FAULT_DONE_COW, "DONE_COW" }, \ + { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } +struct vm_special_mapping {const char *name;/* The name, e.g. "[vdso]". */ --Quoted 2 lines
1.9.1
--
Sincerely yours,
Mike.
Hi Andrew,
Quoted 21 lines · Souptick Joarder
Quoted 19 lines · Mike Rapoport
Quoted 9 lines · Souptick Joarder
Page fault handlers are supposed to return
VM_FAULTcodes, but somedrivers/filesystems mistakenly return error numbers. Now that alldrivers/filesystems have been converted to use thevm_fault_treturn type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not aVM_FAULTcode.Quoted 4 lines
VM_FAULT_SET_HINDEXandVM_FAULT_GET_HINDEXvalues are changed to avoid conflict with otherVM_FAULTcodes.Signed-off-by Souptick Joarder <[email protected]>For the docs part
Reviewed-by Mike Rapoport <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
---
v2: Updated the change log and corrected the document part.
name added to the enum that kernel-doc able to parse it.v3: Corrected the documentation.
If no further comment, can we get this patch in queue for 4.21 ?
Do I need to make any further improvement for this patch ?
Quoted 162 lines
Quoted 162 lines
Quoted 155 lines
include/linux/mm.h | 46 ------------------------------ include/linux/mm_types.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 47 deletions(-)include/linux/mm.h +0
-46@@ -1267,52 +1267,6 @@ static inline void clear_page_pfmemalloc(struct page *page) }/* -* Different kinds of faults, as returned by handle_mm_fault(). -* Used to decide whether a process gets delivered SIGBUS or -* just gets major/minor fault counters bumped up. -*/ - -#define VM_FAULT_OOM 0x0001 -#define VM_FAULT_SIGBUS 0x0002 -#define VM_FAULT_MAJOR 0x0004 -#define VM_FAULT_WRITE 0x0008/* Special case for get_user_pages */ -#define VM_FAULT_HWPOISON 0x0010/* Hit poisoned small page */ -#define VM_FAULT_HWPOISON_LARGE 0x0020/* Hit poisoned large page. Index encoded in upper bits */ -#define VM_FAULT_SIGSEGV 0x0040 - -#define VM_FAULT_NOPAGE 0x0100/* ->fault installed the pte, not return page */ -#define VM_FAULT_LOCKED 0x0200/* ->fault locked the returned page */ -#define VM_FAULT_RETRY 0x0400/* ->fault blocked, must retry */ -#define VM_FAULT_FALLBACK 0x0800/* huge page fault failed, fall back to small */ -#define VM_FAULT_DONE_COW 0x1000/* ->fault has fully handled COW */ -#define VM_FAULT_NEEDDSYNC 0x2000/* ->fault did not modify page tables -* and needs fsync() to complete (for -* synchronous page faults in DAX) */ - -#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_SIGSEGV | \ - VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_LARGE | \ - VM_FAULT_FALLBACK) - -#define VM_FAULT_RESULT_TRACE \ - { VM_FAULT_OOM, "OOM" }, \ - { VM_FAULT_SIGBUS, "SIGBUS" }, \ - { VM_FAULT_MAJOR, "MAJOR" }, \ - { VM_FAULT_WRITE, "WRITE" }, \ - { VM_FAULT_HWPOISON, "HWPOISON" }, \ - { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ - { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ - { VM_FAULT_NOPAGE, "NOPAGE" }, \ - { VM_FAULT_LOCKED, "LOCKED" }, \ - { VM_FAULT_RETRY, "RETRY" }, \ - { VM_FAULT_FALLBACK, "FALLBACK" }, \ - { VM_FAULT_DONE_COW, "DONE_COW" }, \ - { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } - -/* Encode hstate index for a hwpoisoned large page */ -#define VM_FAULT_SET_HINDEX (x) ((x) << 12) -#define VM_FAULT_GET_HINDEX (x) (((x) >> 12) & 0xf) - -/* * Can be called by the pagefault handler when it gets a VM_FAULT_OOM. */ extern void pagefault_out_of_memory (void );include/linux/mm_types.h +72
-2@@ -22,7 +22,6 @@#endif #define AT_VECTOR_SIZE (2*(AT_VECTOR_SIZE_ARCH + AT_VECTOR_SIZE_BASE + 1)) -typedef int vm_fault_t ;struct address_space ;struct mem_cgroup ;@@ -609,6 +608,78 @@ static inline bool mm_tlb_flush_nested(struct mm_struct *mm)struct vm_fault ; +/** +* typedef vm_fault_t - Return type for page fault handlers. +* +* Page fault handlers return a bitmask of %VM_FAULT values. +*/ +typedef __bitwise unsigned int vm_fault_t ; + +/** +* enum vm_fault_reason - Page fault handlers return a bitmask of +* these values to tell the core VM what happened when handling the +* fault. Used to decide whether a process gets delivered SIGBUS or +* just gets major/minor fault counters bumped up. +* +* @VM_FAULT_OOM: Out Of Memory +* @VM_FAULT_SIGBUS: Bad access +* @VM_FAULT_MAJOR: Page read from storage +* @VM_FAULT_WRITE: Special case for get_user_pages +* @VM_FAULT_HWPOISON: Hit poisoned small page +* @VM_FAULT_HWPOISON_LARGE: Hit poisoned large page. Index encoded +* in upper bits +* @VM_FAULT_SIGSEGV: segmentation fault +* @VM_FAULT_NOPAGE: ->fault installed the pte, not return page +* @VM_FAULT_LOCKED: ->fault locked the returned page +* @VM_FAULT_RETRY: ->fault blocked, must retry +* @VM_FAULT_FALLBACK: huge page fault failed, fall back to small +* @VM_FAULT_DONE_COW: ->fault has fully handled COW +* @VM_FAULT_NEEDDSYNC: ->fault did not modify page tables and needs +* fsync() to complete (for synchronous page faults +* in DAX) +* @VM_FAULT_HINDEX_MASK: mask HINDEX value +* +*/ +enum vm_fault_reason { +VM_FAULT_OOM = (__force vm_fault_t )0x000001 , +VM_FAULT_SIGBUS = (__force vm_fault_t )0x000002 , +VM_FAULT_MAJOR = (__force vm_fault_t )0x000004 , +VM_FAULT_WRITE = (__force vm_fault_t )0x000008 , +VM_FAULT_HWPOISON = (__force vm_fault_t )0x000010 , +VM_FAULT_HWPOISON_LARGE = (__force vm_fault_t )0x000020 , +VM_FAULT_SIGSEGV = (__force vm_fault_t )0x000040 , +VM_FAULT_NOPAGE = (__force vm_fault_t )0x000100 , +VM_FAULT_LOCKED = (__force vm_fault_t )0x000200 , +VM_FAULT_RETRY = (__force vm_fault_t )0x000400 , +VM_FAULT_FALLBACK = (__force vm_fault_t )0x000800 , +VM_FAULT_DONE_COW = (__force vm_fault_t )0x001000 , +VM_FAULT_NEEDDSYNC = (__force vm_fault_t )0x002000 , +VM_FAULT_HINDEX_MASK = (__force vm_fault_t )0x0f0000 , +}; + +/* Encode hstate index for a hwpoisoned large page */ +#define VM_FAULT_SET_HINDEX (x) ((__force vm_fault_t)((x) << 16)) +#define VM_FAULT_GET_HINDEX (x) (((x) >> 16) & 0xf) + +#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | \ + VM_FAULT_SIGSEGV | VM_FAULT_HWPOISON | \ + VM_FAULT_HWPOISON_LARGE | VM_FAULT_FALLBACK) + +#define VM_FAULT_RESULT_TRACE \ + { VM_FAULT_OOM, "OOM" }, \ + { VM_FAULT_SIGBUS, "SIGBUS" }, \ + { VM_FAULT_MAJOR, "MAJOR" }, \ + { VM_FAULT_WRITE, "WRITE" }, \ + { VM_FAULT_HWPOISON, "HWPOISON" }, \ + { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ + { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ + { VM_FAULT_NOPAGE, "NOPAGE" }, \ + { VM_FAULT_LOCKED, "LOCKED" }, \ + { VM_FAULT_RETRY, "RETRY" }, \ + { VM_FAULT_FALLBACK, "FALLBACK" }, \ + { VM_FAULT_DONE_COW, "DONE_COW" }, \ + { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } +struct vm_special_mapping {const char *name;/* The name, e.g. "[vdso]". */ --Quoted 2 lines
1.9.1
--
Sincerely yours,
Mike.
Quoted 29 lines · Souptick Joarder
Hi Andrew,
Quoted 25 lines · Souptick Joarder
Quoted 23 lines · Mike Rapoport
Quoted 9 lines · Souptick Joarder
Page fault handlers are supposed to return
VM_FAULTcodes, but somedrivers/filesystems mistakenly return error numbers. Now that alldrivers/filesystems have been converted to use thevm_fault_treturn type, change the type definition to no longer be compatible with 'int'. By making it an unsigned int, the function prototype becomes incompatible with a function which returns int. Sparse will detect any attempts to return a value which is not aVM_FAULTcode.Quoted 4 lines
VM_FAULT_SET_HINDEXandVM_FAULT_GET_HINDEXvalues are changed to avoid conflict with otherVM_FAULTcodes.Signed-off-by Souptick Joarder <[email protected]>For the docs part
Reviewed-by Mike Rapoport <[email protected]>Quoted 4 lines
---
v2: Updated the change log and corrected the document part.
name added to the enum that kernel-doc able to parse it.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
v3: Corrected the documentation.
If no further comment, can we get this patch in queue for 4.21 ?
Do I need to make any further improvement for this patch ?
If no further comment, can we get this patch in queue for 5.0-rcX ?
Quoted 162 lines
Quoted 162 lines
Quoted 162 lines
Quoted 155 lines
include/linux/mm.h | 46 ------------------------------ include/linux/mm_types.h | 73 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 47 deletions(-)include/linux/mm.h +0
-46@@ -1267,52 +1267,6 @@ static inline void clear_page_pfmemalloc(struct page *page) }/* -* Different kinds of faults, as returned by handle_mm_fault(). -* Used to decide whether a process gets delivered SIGBUS or -* just gets major/minor fault counters bumped up. -*/ - -#define VM_FAULT_OOM 0x0001 -#define VM_FAULT_SIGBUS 0x0002 -#define VM_FAULT_MAJOR 0x0004 -#define VM_FAULT_WRITE 0x0008/* Special case for get_user_pages */ -#define VM_FAULT_HWPOISON 0x0010/* Hit poisoned small page */ -#define VM_FAULT_HWPOISON_LARGE 0x0020/* Hit poisoned large page. Index encoded in upper bits */ -#define VM_FAULT_SIGSEGV 0x0040 - -#define VM_FAULT_NOPAGE 0x0100/* ->fault installed the pte, not return page */ -#define VM_FAULT_LOCKED 0x0200/* ->fault locked the returned page */ -#define VM_FAULT_RETRY 0x0400/* ->fault blocked, must retry */ -#define VM_FAULT_FALLBACK 0x0800/* huge page fault failed, fall back to small */ -#define VM_FAULT_DONE_COW 0x1000/* ->fault has fully handled COW */ -#define VM_FAULT_NEEDDSYNC 0x2000/* ->fault did not modify page tables -* and needs fsync() to complete (for -* synchronous page faults in DAX) */ - -#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | VM_FAULT_SIGSEGV | \ - VM_FAULT_HWPOISON | VM_FAULT_HWPOISON_LARGE | \ - VM_FAULT_FALLBACK) - -#define VM_FAULT_RESULT_TRACE \ - { VM_FAULT_OOM, "OOM" }, \ - { VM_FAULT_SIGBUS, "SIGBUS" }, \ - { VM_FAULT_MAJOR, "MAJOR" }, \ - { VM_FAULT_WRITE, "WRITE" }, \ - { VM_FAULT_HWPOISON, "HWPOISON" }, \ - { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ - { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ - { VM_FAULT_NOPAGE, "NOPAGE" }, \ - { VM_FAULT_LOCKED, "LOCKED" }, \ - { VM_FAULT_RETRY, "RETRY" }, \ - { VM_FAULT_FALLBACK, "FALLBACK" }, \ - { VM_FAULT_DONE_COW, "DONE_COW" }, \ - { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } - -/* Encode hstate index for a hwpoisoned large page */ -#define VM_FAULT_SET_HINDEX (x) ((x) << 12) -#define VM_FAULT_GET_HINDEX (x) (((x) >> 12) & 0xf) - -/* * Can be called by the pagefault handler when it gets a VM_FAULT_OOM. */ extern void pagefault_out_of_memory (void );include/linux/mm_types.h +72
-2@@ -22,7 +22,6 @@#endif #define AT_VECTOR_SIZE (2*(AT_VECTOR_SIZE_ARCH + AT_VECTOR_SIZE_BASE + 1)) -typedef int vm_fault_t ;struct address_space ;struct mem_cgroup ;@@ -609,6 +608,78 @@ static inline bool mm_tlb_flush_nested(struct mm_struct *mm)struct vm_fault ; +/** +* typedef vm_fault_t - Return type for page fault handlers. +* +* Page fault handlers return a bitmask of %VM_FAULT values. +*/ +typedef __bitwise unsigned int vm_fault_t ; + +/** +* enum vm_fault_reason - Page fault handlers return a bitmask of +* these values to tell the core VM what happened when handling the +* fault. Used to decide whether a process gets delivered SIGBUS or +* just gets major/minor fault counters bumped up. +* +* @VM_FAULT_OOM: Out Of Memory +* @VM_FAULT_SIGBUS: Bad access +* @VM_FAULT_MAJOR: Page read from storage +* @VM_FAULT_WRITE: Special case for get_user_pages +* @VM_FAULT_HWPOISON: Hit poisoned small page +* @VM_FAULT_HWPOISON_LARGE: Hit poisoned large page. Index encoded +* in upper bits +* @VM_FAULT_SIGSEGV: segmentation fault +* @VM_FAULT_NOPAGE: ->fault installed the pte, not return page +* @VM_FAULT_LOCKED: ->fault locked the returned page +* @VM_FAULT_RETRY: ->fault blocked, must retry +* @VM_FAULT_FALLBACK: huge page fault failed, fall back to small +* @VM_FAULT_DONE_COW: ->fault has fully handled COW +* @VM_FAULT_NEEDDSYNC: ->fault did not modify page tables and needs +* fsync() to complete (for synchronous page faults +* in DAX) +* @VM_FAULT_HINDEX_MASK: mask HINDEX value +* +*/ +enum vm_fault_reason { +VM_FAULT_OOM = (__force vm_fault_t )0x000001 , +VM_FAULT_SIGBUS = (__force vm_fault_t )0x000002 , +VM_FAULT_MAJOR = (__force vm_fault_t )0x000004 , +VM_FAULT_WRITE = (__force vm_fault_t )0x000008 , +VM_FAULT_HWPOISON = (__force vm_fault_t )0x000010 , +VM_FAULT_HWPOISON_LARGE = (__force vm_fault_t )0x000020 , +VM_FAULT_SIGSEGV = (__force vm_fault_t )0x000040 , +VM_FAULT_NOPAGE = (__force vm_fault_t )0x000100 , +VM_FAULT_LOCKED = (__force vm_fault_t )0x000200 , +VM_FAULT_RETRY = (__force vm_fault_t )0x000400 , +VM_FAULT_FALLBACK = (__force vm_fault_t )0x000800 , +VM_FAULT_DONE_COW = (__force vm_fault_t )0x001000 , +VM_FAULT_NEEDDSYNC = (__force vm_fault_t )0x002000 , +VM_FAULT_HINDEX_MASK = (__force vm_fault_t )0x0f0000 , +}; + +/* Encode hstate index for a hwpoisoned large page */ +#define VM_FAULT_SET_HINDEX (x) ((__force vm_fault_t)((x) << 16)) +#define VM_FAULT_GET_HINDEX (x) (((x) >> 16) & 0xf) + +#define VM_FAULT_ERROR (VM_FAULT_OOM | VM_FAULT_SIGBUS | \ + VM_FAULT_SIGSEGV | VM_FAULT_HWPOISON | \ + VM_FAULT_HWPOISON_LARGE | VM_FAULT_FALLBACK) + +#define VM_FAULT_RESULT_TRACE \ + { VM_FAULT_OOM, "OOM" }, \ + { VM_FAULT_SIGBUS, "SIGBUS" }, \ + { VM_FAULT_MAJOR, "MAJOR" }, \ + { VM_FAULT_WRITE, "WRITE" }, \ + { VM_FAULT_HWPOISON, "HWPOISON" }, \ + { VM_FAULT_HWPOISON_LARGE, "HWPOISON_LARGE" }, \ + { VM_FAULT_SIGSEGV, "SIGSEGV" }, \ + { VM_FAULT_NOPAGE, "NOPAGE" }, \ + { VM_FAULT_LOCKED, "LOCKED" }, \ + { VM_FAULT_RETRY, "RETRY" }, \ + { VM_FAULT_FALLBACK, "FALLBACK" }, \ + { VM_FAULT_DONE_COW, "DONE_COW" }, \ + { VM_FAULT_NEEDDSYNC, "NEEDDSYNC" } +struct vm_special_mapping {const char *name;/* The name, e.g. "[vdso]". */ --Quoted 2 lines
1.9.1
--
Sincerely yours,
Mike.
Andrew Morton
maintainerQuoted 3 lines · On Mon, 7 Jan 2019 11:47:12 +0530 Souptick Joarder <[email protected]> wrote:
Quoted 1 line
Do I need to make any further improvement for this patch ?
If no further comment, can we get this patch in queue for 5.0-rcX ?
I stopped paying attention a while ago, sorry.
Please resend everything which you believe is ready to go.
Quoted 10 lines · Andrew Morton
Quoted 3 lines · On Mon, 7 Jan 2019 11:47:12 +0530 Souptick Joarder <[email protected]> wrote:
Quoted 1 line
Do I need to make any further improvement for this patch ?
If no further comment, can we get this patch in queue for 5.0-rcX ?
I stopped paying attention a while ago, sorry.
Please resend everything which you believe is ready to go.
Sure, I will resend. no prob :)