drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
Subsystems (2)
PATCH v4 1/4 drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
Both functions have the same code to disable PSR, so let's reuse that code instead of duplicate.
--- drivers/gpu/drm/i915/intel_psr.c | 50 ++++++++++++++------------------ 1 file changed, 21 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/intel_psr.c +21 -29
@@ -657,6 +657,25 @@ void intel_psr_enable(struct intel_dp *intel_dp,mutex_unlock (&dev_priv->psr.lock); } +static void intel_psr_exit (struct drm_i915_private *dev_priv) +{ +u32 val; + +if (!dev_priv->psr.active) +return ; + +if (dev_priv->psr.psr2_enabled) { + val =I915_READ (EDP_PSR2_CTL ); +WARN_ON (!(val &EDP_PSR2_ENABLE )); +I915_WRITE (EDP_PSR2_CTL , val & ~EDP_PSR2_ENABLE ); + }else { + val =I915_READ (EDP_PSR_CTL ); +WARN_ON (!(val &EDP_PSR_ENABLE )); +I915_WRITE (EDP_PSR_CTL , val & ~EDP_PSR_ENABLE ); + } + dev_priv->psr.active = false; +} +static void intel_psr_disable_source (struct intel_dp *intel_dp) {
@@ -666,20 +685,14 @@ intel_psr_disable_source(struct intel_dp *intel_dp)i915_reg_t psr_status;u32 psr_status_mask; +intel_psr_exit (dev_priv); +if (dev_priv->psr.psr2_enabled) { psr_status =EDP_PSR2_STATUS ; psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; - -I915_WRITE (EDP_PSR2_CTL , -I915_READ (EDP_PSR2_CTL ) & - ~(EDP_PSR2_ENABLE |EDP_SU_TRACK_ENABLE )); - }else { psr_status =EDP_PSR_STATUS ; psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; - -I915_WRITE (EDP_PSR_CTL , -I915_READ (EDP_PSR_CTL ) & ~EDP_PSR_ENABLE ); }/* Wait till PSR is idle */
@@ -687,8 +700,6 @@ intel_psr_disable_source(struct intel_dp *intel_dp) psr_status, psr_status_mask, 0, 2000))DRM_ERROR ("Timed out waiting for PSR Idle State\n" ); - - dev_priv->psr.active = false; }else {if (dev_priv->psr.psr2_enabled)WARN_ON (I915_READ (EDP_PSR2_CTL ) &EDP_PSR2_ENABLE );
@@ -926,25 +937,6 @@ static void intel_psr_work(struct work_struct *work)mutex_unlock (&dev_priv->psr.lock); } -static void intel_psr_exit (struct drm_i915_private *dev_priv) -{ -u32 val; - -if (!dev_priv->psr.active) -return ; - -if (dev_priv->psr.psr2_enabled) { - val =I915_READ (EDP_PSR2_CTL ); -WARN_ON (!(val &EDP_PSR2_ENABLE )); -I915_WRITE (EDP_PSR2_CTL , val & ~EDP_PSR2_ENABLE ); - }else { - val =I915_READ (EDP_PSR_CTL ); -WARN_ON (!(val &EDP_PSR_ENABLE )); -I915_WRITE (EDP_PSR_CTL , val & ~EDP_PSR_ENABLE ); - } - dev_priv->psr.active = false; -} -/** * intel_psr_invalidate - Invalidade PSR * @dev_priv: i915 device
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 2/4 drm/i915/psr: Always wait for idle state when disabling PSR
It should always wait for idle state when disabling PSR because PSR could be inactive due a call to intel_psr_exit() and while PSR is still being disabled asynchronously userspace could change the modeset causing a call to psr_disable() that will not wait for PSR idle and then PSR will be enabled again while PSR is still not idle.
v2: rebased on top of the patch reusing psr_exit()
--- drivers/gpu/drm/i915/intel_psr.c | 41 ++++++++++++++------------------ 1 file changed, 18 insertions(+), 23 deletions(-)
drivers/gpu/drm/i915/intel_psr.c +18 -23
@@ -661,8 +661,12 @@ static void intel_psr_exit(struct drm_i915_private *dev_priv) {u32 val; -if (!dev_priv->psr.active) +if (!dev_priv->psr.active) { +if (INTEL_GEN (dev_priv) >=9 ) +WARN_ON (I915_READ (EDP_PSR2_CTL ) &EDP_PSR2_ENABLE ); +WARN_ON (I915_READ (EDP_PSR_CTL ) &EDP_PSR_ENABLE );return ; + }if (dev_priv->psr.psr2_enabled) { val =I915_READ (EDP_PSR2_CTL );
@@ -680,32 +684,23 @@ static void intel_psr_disable_source(struct intel_dp *intel_dp) {struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); +i915_reg_t psr_status; +u32 psr_status_mask; -if (dev_priv->psr.active) { -i915_reg_t psr_status; -u32 psr_status_mask; - -intel_psr_exit (dev_priv); +intel_psr_exit (dev_priv); -if (dev_priv->psr.psr2_enabled) { - psr_status =EDP_PSR2_STATUS ; - psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; - }else { - psr_status =EDP_PSR_STATUS ; - psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; - } - -/* Wait till PSR is idle */ -if (intel_wait_for_register (dev_priv, - psr_status, psr_status_mask,0 , -2000 )) -DRM_ERROR ("Timed out waiting for PSR Idle State\n" ); +if (dev_priv->psr.psr2_enabled) { + psr_status =EDP_PSR2_STATUS ; + psr_status_mask =EDP_PSR2_STATUS_STATE_MASK ; }else { -if (dev_priv->psr.psr2_enabled) -WARN_ON (I915_READ (EDP_PSR2_CTL ) &EDP_PSR2_ENABLE ); -else -WARN_ON (I915_READ (EDP_PSR_CTL ) &EDP_PSR_ENABLE ); + psr_status =EDP_PSR_STATUS ; + psr_status_mask =EDP_PSR_STATUS_STATE_MASK ; } + +/* Wait till PSR is idle */ +if (intel_wait_for_register (dev_priv, psr_status, psr_status_mask,0 , +2000 )) +DRM_ERROR ("Timed out waiting PSR idle state\n" ); }static void intel_psr_disable_locked (struct intel_dp *intel_dp)
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 3/4 drm/i915/icl: Reset PSR interruptions
In reply to José Roberto de SouzaAll other interruptions gen11 interruptions are reset in gen11_irq_reset() also it is done for other gens that supports PSR.
--- drivers/gpu/drm/i915/i915_irq.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_irq.c +3 -0
@@ -3679,6 +3679,9 @@ static void gen11_irq_reset(struct drm_device *dev)I915_WRITE (GEN11_DISPLAY_INT_CTL ,0 ); +I915_WRITE (EDP_PSR_IMR ,0xffffffff ); +I915_WRITE (EDP_PSR_IIR ,0xffffffff ); +for_each_pipe (dev_priv, pipe)if (intel_display_power_is_enabled (dev_priv,POWER_DOMAIN_PIPE (pipe)))
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v4 4/4 drm/i915/psr: Move intel_psr_disable_source() code to intel_psr_disable_locked()
In reply to José Roberto de SouzaIn the past we had hooks to configure HW for VLV/CHV too, in the drop of VLV/CHV support the intel_psr_disable_source() code was not moved to the caller, so doing it here.
--- drivers/gpu/drm/i915/intel_psr.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/intel_psr.c +9 -16
@@ -680,13 +680,20 @@ static void intel_psr_exit(struct drm_i915_private *dev_priv) dev_priv->psr.active = false; } -static void -intel_psr_disable_source (struct intel_dp *intel_dp) +static void intel_psr_disable_locked (struct intel_dp *intel_dp) {struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp);i915_reg_t psr_status;u32 psr_status_mask; +lockdep_assert_held (&dev_priv->psr.lock); + +if (!dev_priv->psr.enabled) +return ; + +DRM_DEBUG_KMS ("Disabling PSR%s\n" , + dev_priv->psr.psr2_enabled ?"2" :"1" ); +intel_psr_exit (dev_priv);if (dev_priv->psr.psr2_enabled) {
@@ -701,20 +708,6 @@ intel_psr_disable_source(struct intel_dp *intel_dp)if (intel_wait_for_register (dev_priv, psr_status, psr_status_mask,0 ,2000 ))DRM_ERROR ("Timed out waiting PSR idle state\n" ); -} - -static void intel_psr_disable_locked (struct intel_dp *intel_dp) -{ -struct drm_i915_private *dev_priv =dp_to_i915 (intel_dp); - -lockdep_assert_held (&dev_priv->psr.lock); - -if (!dev_priv->psr.enabled) -return ; - -DRM_DEBUG_KMS ("Disabling PSR%s\n" , - dev_priv->psr.psr2_enabled ?"2" :"1" ); -intel_psr_disable_source (intel_dp);/* Disable PSR on Sink */ drm_dp_dpcd_writeb (&intel_dp->aux,DP_PSR_EN_CFG ,0 );
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/52113/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5096 -> Patchwork_10743 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52113/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10743 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_contexts:
fi-icl-u2: NOTRUN -> DMESG-FAIL (fdo#108569)
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: NOTRUN -> INCOMPLETE (fdo#107718)
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-skl-guc: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106725, fdo#106248) -> PASS
igt@drv_module_reload@basic-reload-inject:
fi-byt-clapper: WARN (fdo#108688) -> PASS
igt@drv_selftest@live_contexts:
fi-bsw-n3050: DMESG-FAIL (fdo#108626) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@pm_rpm@module-reload:
fi-byt-clapper: FAIL (fdo#108675) -> PASS fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
fdo#108626 https://bugs.freedesktop.org/show_bug.cgi?id=108626
fdo#108675 https://bugs.freedesktop.org/show_bug.cgi?id=108675
fdo#108688 https://bugs.freedesktop.org/show_bug.cgi?id=108688
== Participating hosts (51 -> 44) ==
Additional (1): fi-icl-u2
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 fi-pnv-d510
== Build changes ==
* Linux: CI_DRM_5096 -> Patchwork_10743
CI_DRM_5096: 9dd45e92a3e9b238d044adde1061a8ee0ce24b73 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4711: cc41f4c921e56c62c85ec5349c47022ae9b5f008 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10743: 97a2d767b57222e9b40a1445ec02fafe7fb34e0a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
97a2d767b572 drm/i915/psr: Move intel_psr_disable_source() code to intel_psr_disable_locked() 378e7ab1a7f5 drm/i915/icl: Reset PSR interruptions008bfe179d1e drm/i915/psr: Always wait for idle state when disabling PSR 1c6d6a54255f drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10743/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/52113/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5103 -> Patchwork_10762 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10762 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10762, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52113/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10762:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_hangcheck:
fi-cfl-8109u: PASS -> DMESG-FAIL== Known issues ==
Here are the changes found in Patchwork_10762 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_contexts:
fi-bsw-kefka: PASS -> DMESG-FAIL (fdo#108656, fdo#108626)
igt@drv_selftest@live_execlists:
fi-apl-guc: PASS -> DMESG-WARN (fdo#108622)
igt@gem_ctx_create@basic-files:
fi-bsw-kefka: PASS -> FAIL (fdo#108656)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-icl-u: PASS -> INCOMPLETE (fdo#107713)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-icl-u2: DMESG-WARN (fdo#107724) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#108622 https://bugs.freedesktop.org/show_bug.cgi?id=108622
fdo#108626 https://bugs.freedesktop.org/show_bug.cgi?id=108626
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
== Participating hosts (54 -> 47) ==
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5103 -> Patchwork_10762
CI_DRM_5103: 23c1138030ad65402f698ab0b356e2f55722bc77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10762: eb5e7e4dbadc074d65045e4967bdb1e6220d9b5b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
eb5e7e4dbadc drm/i915/psr: Move intel_psr_disable_source() code to intel_psr_disable_locked() adc4443f768e drm/i915/icl: Reset PSR interruptions4fc0d348336e drm/i915/psr: Always wait for idle state when disabling PSR 383daddf1134 drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10762/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/52113/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5103 -> Patchwork_10765 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10765 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10765, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52113/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10765:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_guc:
fi-skl-iommu: PASS -> SKIP +1== Known issues ==
Here are the changes found in Patchwork_10765 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-iommu: PASS -> INCOMPLETE (fdo#108602)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@kms_flip@basic-flip-vs-modeset:
fi-hsw-4770r: DMESG-WARN (fdo#105602) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#108602 https://bugs.freedesktop.org/show_bug.cgi?id=108602
== Participating hosts (54 -> 47) ==
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_5103 -> Patchwork_10765
CI_DRM_5103: 23c1138030ad65402f698ab0b356e2f55722bc77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4712: a3ede1b535ac8137f6949c468edd7054453d5dae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10765: b97631a51588ef27325f5f828e45aa0f1e0e4b06 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b97631a51588 drm/i915/psr: Move intel_psr_disable_source() code to intel_psr_disable_locked() 4972ed6d04ac drm/i915/icl: Reset PSR interruptions1d38097c1d66 drm/i915/psr: Always wait for idle state when disabling PSR 0d9f575095bf drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10765/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/52113/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5106 -> Patchwork_10780 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10780 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10780, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/52113/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10780:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_basic@basic-render:
fi-bsw-n3050: PASS -> SKIP +85== Known issues ==
Here are the changes found in Patchwork_10780 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ctx_create@basic-files:
fi-bsw-n3050: PASS -> DMESG-FAIL (fdo#108656)
igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
fi-bsw-n3050: PASS -> DMESG-WARN (fdo#108656) +82
igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@prime_vgem@basic-fence-flip:
fi-byt-n2820: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@drv_selftest@live_contexts:
fi-cfl-8109u: DMESG-FAIL -> PASS
igt@drv_selftest@live_hangcheck:
fi-icl-u: INCOMPLETE (fdo#108315) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-icl-u2: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
==== Warnings ====
igt@drv_selftest@live_contexts:
fi-icl-u: INCOMPLETE (fdo#108315) -> DMESG-FAIL (fdo#108569) fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
fdo#108569 https://bugs.freedesktop.org/show_bug.cgi?id=108569
fdo#108656 https://bugs.freedesktop.org/show_bug.cgi?id=108656
== Participating hosts (55 -> 45) ==
Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-pnv-d510 fi-bdw-samus fi-skl-6700k2
== Build changes ==
* Linux: CI_DRM_5106 -> Patchwork_10780
CI_DRM_5106: 852b9329fbb6ea8bdbb3dac78328aae73d919305 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4713: 3acf5c5b74ebf89c8b389b19d59f12c409e1dc52 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10780: 3c473c4bf0f75df4e80a314b0fc51d1a4e983aa0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3c473c4bf0f7 drm/i915/psr: Move intel_psr_disable_source() code to intel_psr_disable_locked() f36324bd214e drm/i915/icl: Reset PSR interruptions9e84b38561ea drm/i915/psr: Always wait for idle state when disabling PSR d7d14818e339 drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10780/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/52113/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5106_full -> Patchwork_10780_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10780_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10780_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10780_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_10780_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-render:
shard-glk: NOTRUN -> FAIL (fdo#103158)
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@gem_pipe_control_store_loop@fresh-buffer:
shard-apl: NOTRUN -> INCOMPLETE (fdo#103927)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-glk: NOTRUN -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-render-c:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-glk: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_cursor_crc@cursor-128x42-random:
shard-glk: NOTRUN -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_fbcon_fbt@psr-suspend:
shard-skl: NOTRUN -> FAIL (fdo#107882)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-apl: PASS -> FAIL (fdo#103167, fdo#105682)
igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack:
shard-skl: NOTRUN -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: NOTRUN -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
shard-skl: NOTRUN -> FAIL (fdo#105682)
igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
shard-skl: NOTRUN -> FAIL (fdo#105683)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
shard-skl: NOTRUN -> FAIL (fdo#107362, fdo#103191)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
shard-skl: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_plane@pixel-format-pipe-c-planes:
shard-apl: PASS -> FAIL (fdo#103166) +3
shard-skl: NOTRUN -> DMESG-WARN (fdo#106885)
igt@kms_plane@plane-position-covered-pipe-b-planes:
shard-glk: NOTRUN -> FAIL (fdo#103166)
igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
shard-glk: NOTRUN -> FAIL (fdo#108145) +1
igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
shard-skl: NOTRUN -> FAIL (fdo#107815, fdo#108145) +1
igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb:
shard-kbl: NOTRUN -> FAIL (fdo#108145)
shard-skl: NOTRUN -> FAIL (fdo#108145) +3
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-skl: NOTRUN -> FAIL (fdo#103166, fdo#107815)
shard-kbl: NOTRUN -> FAIL (fdo#103166)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@fences:
shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +3
igt@pm_rpm@gem-mmap-cpu:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
igt@pm_rpm@system-suspend-devices:
shard-skl: NOTRUN -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@gem_softpin@noreloc-s3:
shard-skl: INCOMPLETE (fdo#107773, fdo#104108) -> PASS
igt@kms_chv_cursor_fail@pipe-a-128x128-right-edge:
shard-skl: FAIL (fdo#104671) -> PASS
igt@kms_color@pipe-a-legacy-gamma:
shard-apl: FAIL (fdo#104782, fdo#108145) -> PASS
igt@kms_color@pipe-b-ctm-max:
shard-apl: FAIL (fdo#108147) -> PASS
igt@kms_cursor_crc@cursor-128x42-onscreen:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-64x21-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_fbcon_fbt@fbc-suspend:
shard-skl: FAIL (fdo#103833, fdo#105682) -> PASS
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
shard-skl: FAIL (fdo#103167) -> PASS +1
igt@kms_plane@plane-position-covered-pipe-c-planes:
shard-apl: FAIL (fdo#103166) -> PASS +1
igt@pm_rpm@modeset-pc8-residency-stress:
shard-skl: INCOMPLETE (fdo#107807) -> SKIP fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103833 https://bugs.freedesktop.org/show_bug.cgi?id=103833
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_5106 -> Patchwork_10780
CI_DRM_5106: 852b9329fbb6ea8bdbb3dac78328aae73d919305 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4713: 3acf5c5b74ebf89c8b389b19d59f12c409e1dc52 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10780: 3c473c4bf0f75df4e80a314b0fc51d1a4e983aa0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10780/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.IGT: success for series starting with [v4,1/4] drm/i915/psr: Use intel_psr_exit() in intel_psr_disable_source()
Thanks for the reviews DK, patches pushed to drm-intel-next-queued
Quoted 217 lines · Patchwork
== Series Details ==
Series: series starting with [v4,1/4] drm/i915/psr: Use
intel_psr_exit()inintel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/52113/
State : success== Summary ==
= CI Bug Log - changes from
CI_DRM_5106_full->Patchwork_10780_full=== Summary - WARNING ==
Minor unknown changes coming with
Patchwork_10780_fullneed to be
verified
manually.If you think the reported changes have nothing to do with the
changes
introduced inPatchwork_10780_full, please notify your bug team to
allow them
to document this new failure mode, which will reduce false
positives in CI.== Possible new issues ==
Here are the unknown changes that may have been introduced in
Patchwork_10780_full:=== IGT changes ===
==== Warnings ==== igt@pm_rc6_residency@rc6-accuracy: shard-snb: PASS -> SKIP== Known issues ==
Here are the changes found in
Patchwork_10780_fullthat come from
known issues:=== IGT changes ===
==== Issues hit ==== igt@gem_exec_schedule@pi-ringfull-render: shard-glk: NOTRUN -> FAIL (fdo#103158) shard-skl: NOTRUN -> FAIL (fdo#103158) igt@gem_pipe_control_store_loop@fresh-buffer: shard-apl: NOTRUN -> INCOMPLETE (fdo#103927) igt@kms_available_modes_crc@available_mode_test_crc: shard-glk: NOTRUN -> FAIL (fdo#106641) igt@kms_busy@extended-modeset-hang-newfb-render-c: shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +2 igt@kms_busy@extended-pageflip-hang-newfb-render-a: shard-glk: NOTRUN -> DMESG-WARN (fdo#107956) +2 igt@kms_cursor_crc@cursor-128x42-random: shard-glk: NOTRUN -> FAIL (fdo#103232) +1 igt@kms_cursor_crc@cursor-256x85-sliding: shard-apl: PASS -> FAIL (fdo#103232) +2 igt@kms_fbcon_fbt@psr-suspend: shard-skl: NOTRUN -> FAIL (fdo#107882) igt@kms _frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite: shard-apl: PASS -> FAIL (fdo#103167) igt@kms_frontbuffer_tracking@fbc-1p-rte: shard-apl: PASS -> FAIL (fdo#103167, fdo#105682) igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack: shard-skl: NOTRUN -> FAIL (fdo#103167) igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt: shard-glk: PASS -> FAIL (fdo#103167) igt@kms _frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc: shard-glk: NOTRUN -> FAIL (fdo#103167) +2 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move: shard-skl: NOTRUN -> FAIL (fdo#105682) igt@kms_frontbuffer_tracking@fbcpsr-stridechange: shard-skl: NOTRUN -> FAIL (fdo#105683) igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: shard-skl: NOTRUN -> FAIL (fdo#107362, fdo#103191) igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: shard-skl: PASS -> FAIL (fdo#107362, fdo#103191) igt@kms_plane@pixel-format-pipe-c-planes: shard-apl: PASS -> FAIL (fdo#103166) +3 shard-skl: NOTRUN -> DMESG-WARN (fdo#106885) igt@kms_plane@plane-position-covered-pipe-b-planes: shard-glk: NOTRUN -> FAIL (fdo#103166) igt@kms_plane_alpha_blend@pipe-a-alpha-basic: shard-glk: NOTRUN -> FAIL (fdo#108145) +1 igt@kms_plane_alpha_blend@pipe-b-alpha-7efc: shard-skl: NOTRUN -> FAIL (fdo#107815, fdo#108145) +1 igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb: shard-kbl: NOTRUN -> FAIL (fdo#108145) shard-skl: NOTRUN -> FAIL (fdo#108145) +3 igt@kms_plane_multiple@atomic-pipe-a-tiling-x: shard-skl: NOTRUN -> FAIL (fdo#103166, fdo#107815) shard-kbl: NOTRUN -> FAIL (fdo#103166) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) igt@pm_rpm@fences: shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602)+3
igt@pm_rpm@gem-mmap-cpu: shard-skl: PASS -> INCOMPLETE (fdo#107807) igt@pm_rpm@system-suspend-devices: shard-skl: NOTRUN -> INCOMPLETE (fdo#107807) ==== Possible fixes ==== igt@gem_softpin@noreloc-s3: shard-skl: INCOMPLETE (fdo#107773, fdo#104108) -> PASS igt@kms_chv_cursor_fail@pipe-a-128x128-right-edge: shard-skl: FAIL (fdo#104671) -> PASS igt@kms_color@pipe-a-legacy-gamma: shard-apl: FAIL (fdo#104782, fdo#108145) -> PASS igt@kms_color@pipe-b-ctm-max: shard-apl: FAIL (fdo#108147) -> PASS igt@kms_cursor_crc@cursor-128x42-onscreen: shard-glk: FAIL (fdo#103232) -> PASS +1 igt@kms_cursor_crc@cursor-64x21-sliding: shard-apl: FAIL (fdo#103232) -> PASS +1 igt@kms_fbcon_fbt@fbc-suspend: shard-skl: FAIL (fdo#103833, fdo#105682) -> PASS igt@kms _frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc: shard-skl: FAIL (fdo#103167) -> PASS +1 igt@kms_plane@plane-position-covered-pipe-c-planes: shard-apl: FAIL (fdo#103166) -> PASS +1 igt@pm_rpm@modeset-pc8-residency-stress: shard-skl: INCOMPLETE (fdo#107807) -> SKIPfdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103833 https://bugs.freedesktop.org/show_bug.cgi?id=103833
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107815 https://bugs.freedesktop.org/show_bug.cgi?id=107815
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux:
CI_DRM_5106->Patchwork_10780
CI_DRM_5106:852b9329fbb6ea8bdbb3dac78328aae73d919305@git://anongit.freedesktop.org/gfx-ci/linux
IGT_4713:3acf5c5b74ebf89c8b389b19d59f12c409e1dc52@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10780:3c473c4bf0f75df4e80a314b0fc51d1a4e983aa0@git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509:fdc5a4ca11124ab8413c7988896eec4c97336694@git://anongit.freedesktop.org/piglit
Quoted 4 lines
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10780/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx