Staging: vchi: Add license id and change int type
Subsystems (2)
PATCH 1/1 Staging: vchi: Add license id and change int type
From: Andr? Almeida <[email protected]>
Fix the following checkpatch issues:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
CHECK: Prefer kernel type 's32' over 'int32_t'
---
Hello! This is my first patch to Linux Kernel. Let me know any feedback
--- drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +3 -3
@@ -1,5 +1,5 @@ -/** -* Copyright (c) 2010-2012 Broadcom. All rights reserved. +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2010-2012 Broadcom. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions
@@ -36,7 +36,7 @@#include <linux/types.h> -typedef int32_t VCHI_MEM_HANDLE_T ; +typedef s32 VCHI_MEM_HANDLE_T ;#define VCHI_MEM_HANDLE_INVALID 0#endif
Signature · 1 line
2.19.1
PATCH 1/1 Staging: vchi: Add license id and change int type
Hi Andre,
Am 07.11.18 um 01:07 schrieb andrealmeid at riseup.net:
Quoted 6 lines
From: Andr? Almeida <[email protected]>
Fix the following checkpatch issues:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
CHECK: Prefer kernel type 's32' over 'int32_t'
thanks for your patch, but there are some changes required.
First don't change two different things in one patch. So please make a V2 with one patch for SPDX and the other one for the type change.
Quoted 15 lines
Signed-off-by Andr? Almeida <[email protected]>---
Hello! This is my first patch to Linux Kernel. Let me know any feedback
--- drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/vc04_services/interface/vchi/vchi_mh.h +0
-0
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 1
Quoted 3 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +1
-2@@ -1,5 +1,5 @@ -/** -* Copyright (c) 2010-2012 Broadcom. All rights reserved. +/* SPDX-License-Identifier: GPL-2.0 */
Please use the C++ style for the SPDX id.
Unfortunately your id doesn't match the license text. It's a dual license|: BSD-3-Clause OR GPL-2.0|
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 5
Quoted 4 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +1
-0+/* Copyright (c) 2010-2012 Broadcom. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions
After adding the SPDX id we can drop the whole license text.
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 39
Quoted 6 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +1
-1@@ -36,7 +36,7 @@#include <linux/types.h> -typedef int32_t VCHI_MEM_HANDLE_T ; +typedef s32 VCHI_MEM_HANDLE_T ;
In general we should drop the whole typedef, but since the firmware counterpart would use this. I'm okay with this change.
Stefan
Quoted 3 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +0
-0#define VCHI_MEM_HANDLE_INVALID 0#endif
PATCH 1/1 Staging: vchi: Add license id and change int type
Hi Andre,
Quoted 13 lines
Stefan Wahren <[email protected]> hat am 7. November 2018 um 09:30 geschrieben:
Quoted 10 lines
Signed-off-by Andr? Almeida <[email protected]>---
Hello! This is my first patch to Linux Kernel. Let me know any feedback
--- drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 10 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 1
Quoted 8 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +1
-2@@ -1,5 +1,5 @@ -/** -* Copyright (c) 2010-2012 Broadcom. All rights reserved. +/* SPDX-License-Identifier: GPL-2.0 */ Please use the C++ style for the SPDX id.
Apologies. Please ignore this suggestion. C style is correct for header files.
Stefan
Greg KH
maintainerPATCH 1/1 Staging: vchi: Add license id and change int type
In reply to andrealmeid at riseup.netQuoted 21 lines · andrealmeid at riseup.net
From: Andr? Almeida <[email protected]>
Fix the following checkpatch issues:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
CHECK: Prefer kernel type 's32' over 'int32_t'Signed-off-by Andr? Almeida <[email protected]>---
Hello! This is my first patch to Linux Kernel. Let me know any feedback
--- drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/vc04_services/interface/vchi/vchi_mh.h +0
-0
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 1
Quoted 1 line
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +0
-1@@ -1,5 +1,5 @@ -/**
Why change this line?
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 1
Quoted 2 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +1
-1-* Copyright (c) 2010-2012 Broadcom. All rights reserved. +/* SPDX-License-Identifier: GPL-2.0 */
That is not the correct license for this file. Please never make a change like this unless you really know your license information.
drivers/staging/vc04_services/interface/vchi/vchi_mh.h line 39
Quoted 10 lines
drivers/staging/vc04_services/interface/vchi/vchi_mh.h +2
-1+/* Copyright (c) 2010-2012 Broadcom. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -36,7 +36,7 @@#include <linux/types.h> -typedef int32_t VCHI_MEM_HANDLE_T ; +typedef s32 VCHI_MEM_HANDLE_T ;
You are doing multiple things in the same patch, which isn't allowed. Please break all patches up into one "logical" thing per patch and send a patch series.
Also, are you sure this type change is correct?
thanks,
greg k-h