Skip to contentSkip to conversation

blueman: fix rdepends issue

PATCH In review Armin Kuster 4 participants 7 messages Nov 7, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blueman: fix rdepends issue

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -2
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
Signature · 1 line
2.7.4
#1 lore raw
Quoted 28 lines · Armin Kuster

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -3
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
--
Quoted 2 lines

2.7.4

This is not right: How shall this happen if meta-xfce is not in your layers - I suggest you run a cleansstate after changing layer configuration

Andreas

author
#2 lore raw
Quoted 25 lines · Andreas Müller
Quoted 24 lines · Armin Kuster

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -2
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
Quoted 8 lines
Quoted 5 lines
meta-networking/recipes-connectivity/blueman/blueman_git.bb +0 -1
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
--

2.7.4

This is not right: How shall this happen if meta-xfce is not in your layers - I suggest you run a cleansstate after changing layer configuration

I am running the yocto-check-layer.  Should this recipe really be in meta-xfce? .. I am out of options on how to get this to pass. Maybe no one cares if it ever does???

- armin

Quoted 1 line

Andreas

#3 lore raw
Quoted 38 lines · On Wed, Nov 7, 2018 at 8:40 PM akuster808 <[email protected]> wrote:
Quoted 25 lines · Andreas Müller
Quoted 24 lines · Armin Kuster

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -2
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
Quoted 8 lines
Quoted 5 lines
meta-networking/recipes-connectivity/blueman/blueman_git.bb +0 -1
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
--

2.7.4

This is not right: How shall this happen if meta-xfce is not in your layers - I suggest you run a cleansstate after changing layer configuration

Quoted 4 lines

I am running the yocto-check-layer.
Should this recipe really be in
meta-xfce? .. I am out of options on how to get this to pass. Maybe no one cares if it ever does???

Put it to meta-xfce to make script happy - what a waste of time...

Andreas

#4 lore raw
Quoted 40 lines · Andreas Müller
Quoted 38 lines · On Wed, Nov 7, 2018 at 8:40 PM akuster808 <[email protected]> wrote:
Quoted 33 lines · Andreas Müller
Quoted 27 lines · Armin Kuster

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -3
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
--
Quoted 2 lines

2.7.4

This is not right: How shall this happen if meta-xfce is not in your layers - I suggest you run a cleansstate after changing layer configuration

Quoted 6 lines
Quoted 4 lines

I am running the yocto-check-layer.
Should this recipe really be in
meta-xfce? .. I am out of options on how to get this to pass. Maybe no one cares if it ever does???

Put it to meta-xfce to make script happy - what a waste of time...

I think we can put a bbappend in meta-xfce which enables this packageconfig and as such
this patch is fine.

Quoted 6 lines

Andreas
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
In reply to akuster808
Quoted 37 lines · On Wed, Nov 07, 2018 at 11:40:40AM -0800, akuster808 wrote:
Quoted 25 lines · Andreas Müller
Quoted 24 lines · Armin Kuster

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -2
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
Quoted 8 lines
Quoted 5 lines
meta-networking/recipes-connectivity/blueman/blueman_git.bb +0 -1
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
--

2.7.4

This is not right: How shall this happen if meta-xfce is not in your layers - I suggest you run a cleansstate after changing layer configuration

Quoted 3 lines

I am running the yocto-check-layer.  Should this recipe really be in meta-xfce? .. I am out of options on how to get this to pass. Maybe no one cares if it ever does???

Isn't the error shown only with your addition to RDEPENDS? Because without this patch the thunar dependency is enabled only when meta-xfce layer is included with:

cat ./meta-xfce/recipes-connectivity/blueman/blueman_%.bbappend PACKAGECONFIG_append = " thunar"

Why would blueman depend on thunar without meta-xfce?
And with both meta-networking and meta-xfce included it will find thunar depdencency in meta-xfce.

But with your change you're adding thunar dependency whenever x11 is in DISTRO_FEATURES with or without meta-xfce included which is clearly wrong and yocto-check-layer would be correct to complain.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#6 lore raw
Quoted 50 lines · Martin Jansa
Quoted 37 lines · On Wed, Nov 07, 2018 at 11:40:40AM -0800, akuster808 wrote:
Quoted 25 lines · Andreas Müller
Quoted 24 lines · Armin Kuster

fixes
ERROR: Required build target 'blueman' has no buildable providers. Missing or unbuildable dependency chain was: ['blueman', 'thunar']

---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-networking/recipes-connectivity/blueman/blueman_git.bb +3 -2
index 8eb99ed..06a11b7 100644
@@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
Quoted 8 lines
Quoted 5 lines
meta-networking/recipes-connectivity/blueman/blueman_git.bb +0 -1
 FILES_${PN} += " \
     ${datadir}/dbus-1 \
--

2.7.4

This is not right: How shall this happen if meta-xfce is not in your layers - I suggest you run a cleansstate after changing layer configuration

Quoted 3 lines

I am running the yocto-check-layer. Should this recipe really be in meta-xfce? .. I am out of options on how to get this to pass. Maybe no one cares if it ever does???

Isn't the error shown only with your addition to RDEPENDS? Because without this patch the thunar dependency is enabled only when meta-xfce layer is included with:

cat ./meta-xfce/recipes-connectivity/blueman/blueman_%.bbappend PACKAGECONFIG_append = " thunar"

Quoted 8 lines

Why would blueman depend on thunar without meta-xfce?
And with both meta-networking and meta-xfce included it will find thunar depdencency in meta-xfce.

But with your change you're adding thunar dependency whenever x11 is in DISTRO_FEATURES with or without meta-xfce included which is clearly wrong and yocto-check-layer would be correct to complain.

My opinion as author and user of blueman recipe: The patch sent is wrong. It breaks blueman's thunar-sendto-blueman.desktop in case thunar is not in the image and I cannot see what's wrong with current layout.

For me this is yet another example of wasting time for the sake of yocto-layer-script. Correct answer should have been: 'Go fix that script' but that certainly would have caused further discussion. So I agreed the suggestion to move blueman to meta-xfce. This makes holy marketing script happy, matches my used-case and I can continue with useful things.

Regards

Andreas