Question on comment header for for_each_domain()
Hello!
The header comment for for_each_domain() talks about a call to synchronize_sched() within detach_destroy_domains(), but I am not seeing any such call. Because synchronize_sched() is now folded into synchronize_rcu(), I have a patch that edits the comment, but it looks like a larger change is needed.
Or am I blind today?
Thanx, Paul
Peter Zijlstra
maintainerQuoted 9 lines · Paul E. McKenney
Hello!
The header comment for
for_each_domain()talks about a call tosynchronize_sched()withindetach_destroy_domains(), but I am not seeing any such call. Becausesynchronize_sched()is now folded intosynchronize_rcu(), I have a patch that edits the comment, but it looks like a larger change is needed.Or am I blind today?
I think you're quite right and that comment is a wee bit stale.
The sched domain tree is indeed protected by regular RCU (not RCU-sched as the comment seems to imply) and this is per destroy_sched_domains() using call_rcu().
And most (I didn't look at all) uses for the sched-domain tree do indeed employ rcu_read_lock().
Quoted 11 lines · Peter Zijlstra
Quoted 9 lines · Paul E. McKenney
Hello!
The header comment for
for_each_domain()talks about a call tosynchronize_sched()withindetach_destroy_domains(), but I am not seeing any such call. Becausesynchronize_sched()is now folded intosynchronize_rcu(), I have a patch that edits the comment, but it looks like a larger change is needed.Or am I blind today?
Quoted 8 lines
I think you're quite right and that comment is a wee bit stale.
The sched domain tree is indeed protected by regular RCU (not RCU-sched as the comment seems to imply) and this is per
destroy_sched_domains()usingcall_rcu().And most (I didn't look at all) uses for the sched-domain tree do indeed employ
rcu_read_lock().
Ah, thank you for the info! Would this patch do the trick?
Thanx, Paul
------------------------------------------------------------------------
commit 4182d416309b11d16e882ab637ab11cecef0bddc
Author: Paul E. McKenney <[email protected]> Date: Tue Nov 6 19:10:53 2018 -0800
sched: Replace call_rcu_sched() with call_rcu()
Now that call_rcu()'s callback is not invoked until after all preempt-disable regions of code have completed (in addition to explicitly marked RCU read-side critical sections), call_rcu() can be used in place of call_rcu_sched(). This commit therefore makes that change.
While in the area, this commit also updates an outdated header comment for for_each_domain().
kernel/sched/sched.h +1 -1
@@ -1237,7 +1237,7 @@ extern void sched_ttwu_pending(void);/* * The domain tree (rq->sd) is protected by RCU's quiescent state transition. -* See detach_destroy_domains: synchronize_sched for details. +* See destroy_sched_domains: call_rcu for details. * * The domain tree of any CPU may only be accessed from within * preempt-disabled sections.
kernel/sched/topology.c +2 -2
@@ -248,7 +248,7 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)raw_spin_unlock_irqrestore (&rq->lock, flags);if (old_rd) -call_rcu_sched (&old_rd->rcu, free_rootdomain); +call_rcu (&old_rd->rcu, free_rootdomain); }void sched_get_rd (struct root_domain *rd)
@@ -261,7 +261,7 @@ void sched_put_rd(struct root_domain *rd)if (!atomic_dec_and_test (&rd->refcount))return ; -call_rcu_sched (&rd->rcu, free_rootdomain); +call_rcu (&rd->rcu, free_rootdomain); }static int init_rootdomain (struct root_domain *rd)
Peter Zijlstra
maintainerQuoted 51 lines · Paul E. McKenney
Quoted 11 lines · Peter Zijlstra
Quoted 9 lines · Paul E. McKenney
Hello!
The header comment for
for_each_domain()talks about a call tosynchronize_sched()withindetach_destroy_domains(), but I am not seeing any such call. Becausesynchronize_sched()is now folded intosynchronize_rcu(), I have a patch that edits the comment, but it looks like a larger change is needed.Or am I blind today?
Quoted 8 lines
I think you're quite right and that comment is a wee bit stale.
The sched domain tree is indeed protected by regular RCU (not RCU-sched as the comment seems to imply) and this is per
destroy_sched_domains()usingcall_rcu().And most (I didn't look at all) uses for the sched-domain tree do indeed employ
rcu_read_lock().Ah, thank you for the info! Would this patch do the trick?
kernel/sched/sched.h +1
-1@@ -1237,7 +1237,7 @@ extern void sched_ttwu_pending(void);/* * The domain tree (rq->sd) is protected by RCU's quiescent state transition. -* See detach_destroy_domains: synchronize_sched for details. +* See destroy_sched_domains: call_rcu for details. * * The domain tree of any CPU may only be accessed from within * preempt-disabled sections. kernel/sched/topology.c +1
-1@@ -248,7 +248,7 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)raw_spin_unlock_irqrestore (&rq->lock, flags);if (old_rd) -call_rcu_sched (&old_rd->rcu, free_rootdomain); +call_rcu (&old_rd->rcu, free_rootdomain); }void sched_get_rd (struct root_domain *rd)
kernel/sched/topology.c void sched_put_rd(struct root_domain *rd) · line 267
Quoted 8 lines
kernel/sched/topology.c +1
-1@@ -261,7 +261,7 @@ void sched_put_rd(struct root_domain *rd)if (!atomic_dec_and_test (&rd->refcount))return ; -call_rcu_sched (&rd->rcu, free_rootdomain); +call_rcu (&rd->rcu, free_rootdomain); }static int init_rootdomain (struct root_domain *rd)
Argh, that is the rootdomain, not the regular sched-domain tree. Now I'll have to go audit that stuff again.
ISTR there being slightly different rules for rootdomain, and with a reason.
Can we hold onto this until after LPC?
Quoted 63 lines · Peter Zijlstra
Quoted 50 lines · Paul E. McKenney
Quoted 11 lines · Peter Zijlstra
Quoted 9 lines · Paul E. McKenney
Hello!
The header comment for
for_each_domain()talks about a call tosynchronize_sched()withindetach_destroy_domains(), but I am not seeing any such call. Becausesynchronize_sched()is now folded intosynchronize_rcu(), I have a patch that edits the comment, but it looks like a larger change is needed.Or am I blind today?
Quoted 8 lines
I think you're quite right and that comment is a wee bit stale.
The sched domain tree is indeed protected by regular RCU (not RCU-sched as the comment seems to imply) and this is per
destroy_sched_domains()usingcall_rcu().And most (I didn't look at all) uses for the sched-domain tree do indeed employ
rcu_read_lock().Ah, thank you for the info! Would this patch do the trick?
kernel/sched/sched.h +1
-1@@ -1237,7 +1237,7 @@ extern void sched_ttwu_pending(void);/* * The domain tree (rq->sd) is protected by RCU's quiescent state transition. -* See detach_destroy_domains: synchronize_sched for details. +* See destroy_sched_domains: call_rcu for details. * * The domain tree of any CPU may only be accessed from within * preempt-disabled sections. kernel/sched/topology.c +1
-1@@ -248,7 +248,7 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)raw_spin_unlock_irqrestore (&rq->lock, flags);if (old_rd) -call_rcu_sched (&old_rd->rcu, free_rootdomain); +call_rcu (&old_rd->rcu, free_rootdomain); }void sched_get_rd (struct root_domain *rd)kernel/sched/topology.c void sched_put_rd(struct root_domain *rd) · line 267
Quoted 8 lines
kernel/sched/topology.c +1
-1@@ -261,7 +261,7 @@ void sched_put_rd(struct root_domain *rd)if (!atomic_dec_and_test (&rd->refcount))return ; -call_rcu_sched (&rd->rcu, free_rootdomain); +call_rcu (&rd->rcu, free_rootdomain); }static int init_rootdomain (struct root_domain *rd)Argh, that is the rootdomain, not the regular sched-domain tree. Now I'll have to go audit that stuff again.
Quoted 4 lines
ISTR there being slightly different rules for rootdomain, and with a reason.
Can we hold onto this until after LPC?
This patch isn't going anywhere irrevocable until -rc5 anyway, so no problem. ;-)
Thanx, Paul