Skip to contentSkip to conversation

s390x: Fixup svc handling

PATCH Cornelia Huck 1 participant 1 message Nov 8, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Cornelia Huck

author Reviewed-by
#1 lore raw
Quoted 26 lines · On Thu, 8 Nov 2018 10:27:04 +0100 Janosch Frank <[email protected]> wrote:

Let's use the svc psw instead of the mccheck psw for svc interrupts and name it supervisor call.

---
 lib/s390x/interrupt.c | 2 +-
 s390x/cstart64.S      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
lib/s390x/interrupt.c +1 -1
index 6d0d4a3..4bcfdd6 100644
@@ -137,6 +137,6 @@ void handle_io_int(void)
 
 void handle_svc_int(void)
 {
-	report_abort("Unexpected service call interrupt: at %#lx",
+	report_abort("Unexpected supervisor call interrupt: at %#lx",
 		     lc->svc_old_psw.addr);
 }
s390x/cstart64.S +0 -0
index d6d40b7..fdcd0e7 100644

s390x/cstart64.S init_psw_cont: · line 36

Quoted 1 line
s390x/cstart64.S +0 -0
@@ -36,7 +36,7 @@ init_psw_cont:
 	larl	%r1, ext_int_psw

Hm... shouldn't that be io_int_psw here? (The other psws look fine.)

s390x/cstart64.S init_psw_cont: · line 42

Quoted 7 lines
s390x/cstart64.S +1 -1
 	mvc	GEN_LC_IO_NEW_PSW(16), 0(%r1)
 	/* setup svc interrupt handler */
-	larl	%r1, mcck_int_psw
+	larl	%r1, svc_int_psw
 	mvc	GEN_LC_SVC_NEW_PSW(16), 0(%r1)
 	/* setup cr0, enabling e.g. AFP-register control */
 	larl	%r1, initial_cr0