Skip to contentSkip to conversation

staging: davinci_vpfe: Remove one blank space

PATCH In review Irenge Jules Bashizi 3 participants 3 messages Nov 8, 2018 – Nov 9, 2018

Subsystems (2)
Media (V4L/DVB) Staging
lore
Share & tools
lore

Irenge Jules Bashizi

author
#0 lore raw

PATCH v2 1/1 staging: davinci_vpfe: Remove one blank space

Remove one blank space complained by checkpatch

Signed-off-by Irenge Jules Bashizi <[email protected]>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +1 -2
index 81b369b28a47..79f7f7f9a36b 100644
@@ -1466,7 +1466,7 @@ ipipe_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
 	struct v4l2_mbus_framefmt *format;
 
 	format = __ipipe_get_format(ipipe, cfg, fmt->pad, fmt->which);
-	if (format == NULL)
+	if (!format)
 		return -EINVAL;
 
 	ipipe_try_format(ipipe, cfg, fmt->pad, &fmt->format, fmt->which);

@@ -1818,7 +1818,6 @@ vpfe_ipipe_init(struct vpfe_ipipe_device *ipipe, struct platform_device *pdev)
 			  V4L2_CID_CONTRAST, 0,
 			  IPIPE_CONTRAST_HIGH, 1, 16);
 
-
 	v4l2_ctrl_handler_setup(&ipipe->ctrls);
 	sd->ctrl_handler = &ipipe->ctrls;
Signature · 1 line
2.17.2
maintainer
#1 lore raw
Quoted 1 line · Irenge Jules Bashizi

Remove one blank space complained by checkpatch

That is not what this patch did :(

#2 lore raw
In reply to Irenge Jules Bashizi
Quoted 12 lines · Irenge Jules Bashizi

Remove one blank space complained by checkpatch

Signed-off-by Irenge Jules Bashizi <[email protected]>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +0 -0
index 81b369b28a47..79f7f7f9a36b 100644

drivers/staging/media/davinci_vpfe/dm365_ipipe.c ipipe_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg, · line 1470

Quoted 6 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +1 -1
@@ -1466,7 +1466,7 @@ ipipe_set_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
 	struct v4l2_mbus_framefmt *format;
 
 	format = __ipipe_get_format(ipipe, cfg, fmt->pad, fmt->which);
-	if (format == NULL)
+	if (!format)
 		return -EINVAL;

This change was part of another patch.

julia

Quoted 20 lines
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +0 -2
 	ipipe_try_format(ipipe, cfg, fmt->pad, &fmt->format, fmt->which);

@@ -1818,7 +1818,6 @@ vpfe_ipipe_init(struct vpfe_ipipe_device *ipipe, struct platform_device *pdev)
 			  V4L2_CID_CONTRAST, 0,
 			  IPIPE_CONTRAST_HIGH, 1, 16);
 
-
 	v4l2_ctrl_handler_setup(&ipipe->ctrls);
 	sd->ctrl_handler = &ipipe->ctrls;
 
--

2.17.2

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181108230918.4477-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.