Skip to contentSkip to conversation

cxgb4: free mac_hlist properly

PATCH Applied Arjun Vynipadath 2 participants 2 messages Nov 9, 2018 – Nov 10, 2018

Subsystems (3)
Networking Network drivers CXGB4 Ethernet driver (CXGB4)
lore
Share & tools
lore

Arjun Vynipadath

author
#0 lore raw

PATCH 1/1 cxgb4: free mac_hlist properly

The locally maintained list for tracking hash mac table was not freed during driver remove.

Signed-off-by Arjun Vynipadath <[email protected]>
Signed-off-by Ganesh Goudar <[email protected]>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +8 -0
index 05a4692..956e708 100644
@@ -2295,6 +2295,8 @@ static int cxgb_up(struct adapter *adap)
 
 static void cxgb_down(struct adapter *adapter)
 {
+	struct hash_mac_addr *entry, *tmp;
+
 	cancel_work_sync(&adapter->tid_release_task);
 	cancel_work_sync(&adapter->db_full_task);
 	cancel_work_sync(&adapter->db_drop_task);

@@ -2303,6 +2305,12 @@ static void cxgb_down(struct adapter *adapter)
 
 	t4_sge_stop(adapter);
 	t4_free_sge_resources(adapter);
+
+	list_for_each_entry_safe(entry, tmp, &adapter->mac_hlist, list) {
+		list_del(&entry->list);
+		kfree(entry);
+	}
+
 	adapter->flags &= ~FULL_INIT_DONE;
 }
Signature · 1 line
1.8.3.1