fuse: fix use-after-free in fuse_direct_IO()
Subsystems (2)
PATCH 1/1 fuse: fix use-after-free in fuse_direct_IO()
In async IO blocking case the additional reference to the io is taken for it to survive fuse_aio_complete(). In non blocking case this additional reference is not needed, however we still reference io to figure out whether to wait for completion or not. This is wrong and will lead to use-after-free. Fix it by storing blocking information in separate variable.
This was spotted by KASAN when running generic/208 fstest.
--- fs/fuse/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
fs/fuse/file.c +3 -1
@@ -2924,10 +2924,12 @@ fuse_direct_IO(struct kiocb *iocb, struct iov_iter *iter) }if (io->async) { +bool blocking = io->blocking; +fuse_aio_complete (io, ret <0 ? ret :0 ,-1 );/* we have a non-extending, async request, so return */ -if (!io->blocking) +if (!blocking)return -EIOCBQUEUED ;wait_for_completion (&wait);
Signature · 1 line
2.17.2
Quoted 8 lines · Lukas Czerner
In async IO blocking case the additional reference to the io is taken for it to survive
fuse_aio_complete(). In non blocking case this additional reference is not needed, however we still reference io to figure out whether to wait for completion or not. This is wrong and will lead to use-after-free. Fix it by storing blocking information in separate variable.This was spotted by KASAN when running generic/208 fstest.
Thanks, applied.
Miklos