Skip to contentSkip to conversation

make-release: add skiboot .version file

PATCH RESEND Applied Michael Roth 3 participants 4 messages Nov 9, 2018 – Nov 15, 2018

lore
Share & tools
lore

Michael Roth

author
#0 lore raw

PATCH RESEND 1/1 make-release: add skiboot .version file

This is needed to build skiboot from tarball-distributed sources since the git data the make_release.sh script relies on to generate it is not available.

Cc [email protected]
Reported-by Michael Tokarev <[email protected]>
Signed-off-by Michael Roth <[email protected]>
---
 scripts/make-release | 1 +
 1 file changed, 1 insertion(+)
scripts/make-release +1 -0
index 04fa9defdc..c14f75b12c 100755
@@ -19,6 +19,7 @@ pushd ${destination}
 git checkout "v${version}"
 git submodule update --init
 (cd roms/seabios && git describe --tags --long --dirty > .version)
+(cd roms/skiboot && ./make_version.sh > .version)
 # FIXME: The following line is a workaround for avoiding filename collisions
 # when unpacking u-boot sources on case-insensitive filesystems. Once we
 # update to something with u-boot commit 610eec7f0 we can drop this line.
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Michael Roth

This is needed to build skiboot from tarball-distributed sources since the git data the make_release.sh script relies on to generate it is not available.

Cc [email protected]
Reported-by Michael Tokarev <[email protected]>
Signed-off-by Michael Roth <[email protected]>
Reviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 20 lines
---
 scripts/make-release | 1 +
 1 file changed, 1 insertion(+)
scripts/make-release +1 -1
index 04fa9defdc..c14f75b12c 100755
@@ -19,6 +19,7 @@ pushd ${destination}
 git checkout "v${version}"
 git submodule update --init
 (cd roms/seabios && git describe --tags --long --dirty > .version)
+(cd roms/skiboot && ./make_version.sh > .version)
 # FIXME: The following line is a workaround for avoiding filename collisions
 # when unpacking u-boot sources on case-insensitive filesystems. Once we
 # update to something with u-boot commit 610eec7f0 we can drop this line.
--

2.17.1

author
#2 lore raw
In reply to Michael Roth

Quoting Michael Roth (2018-11-09 10:13:52)

Quoted 7 lines

This is needed to build skiboot from tarball-distributed sources since the git data the make_release.sh script relies on to generate it is not available.

Cc [email protected]
Reported-by Michael Tokarev <[email protected]>
Signed-off-by Michael Roth <[email protected]>

Hi Peter,

Should I go ahead and send this as a standalone pull or should it go in through someone else?

Quoted 19 lines
---
 scripts/make-release | 1 +
 1 file changed, 1 insertion(+)
scripts/make-release +1 -0
index 04fa9defdc..c14f75b12c 100755
@@ -19,6 +19,7 @@ pushd ${destination}
 git checkout "v${version}"
 git submodule update --init
 (cd roms/seabios && git describe --tags --long --dirty > .version)
+(cd roms/skiboot && ./make_version.sh > .version)
 # FIXME: The following line is a workaround for avoiding filename collisions
 # when unpacking u-boot sources on case-insensitive filesystems. Once we
 # update to something with u-boot commit 610eec7f0 we can drop this line.
Signature · 1 line
2.17.1
Applied
#3 lore raw
Quoted 5 lines · Michael Roth

Quoting Michael Roth (2018-11-09 10:13:52)

Quoted 4 lines

This is needed to build skiboot from tarball-distributed sources since the git data the make_release.sh script relies on to generate it is not available.

Quoted 8 lines
Quoted 3 lines
Cc [email protected]
Reported-by Michael Tokarev <[email protected]>
Signed-off-by Michael Roth <[email protected]>

Hi Peter,

Should I go ahead and send this as a standalone pull or should it go in through someone else?

Applied to master, thanks.

-- PMM