power: reset: gpio-poweroff: add ability to specific active and inactive delays
Subsystems (2)
PATCH 1/1 power: reset: gpio-poweroff: add ability to specific active and inactive delays
From: Heiko Stuebner <[email protected]>
Similar to gpio-reset allow to specify active and inactive delays while keeping the 100ms defaults that were used previously all the time.
The dt-properties are named the same as in gpio-reset but get an "-ms" suffix as properties should contain such a suffix specifying its unit.
--- .../devicetree/bindings/power/reset/gpio-poweroff.txt | 2 ++ drivers/power/reset/gpio-poweroff.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt +2 -0
@@ -27,6 +27,8 @@ Optional properties: it to an output when the power-off handler is called. If this optional property is not specified, the GPIO is initialized as an output in its inactive state. +- active-delay-ms: Delay (default 100) to wait after driving gpio active +- inactive-delay-ms: Delay (default 100) to wait after driving gpio inactive - timeout-ms: Time to wait before asserting a WARN_ON(1). If nothing is specified, 3000 ms is used.
drivers/power/reset/gpio-poweroff.c +8 -2
@@ -26,6 +26,8 @@*/ static struct gpio_desc *reset_gpio;static u32 timeout =DEFAULT_TIMEOUT_MS ; +static u32 active_delay =100 ; +static u32 inactive_delay =100 ;static void gpio_poweroff_do_poweroff (void ) {
@@ -33,10 +35,11 @@ static void gpio_poweroff_do_poweroff(void)/* drive it active, also inactive->active edge */ gpiod_direction_output (reset_gpio,1 ); -mdelay (100 ); +mdelay (active_delay); +/* drive inactive, also active->inactive edge */ gpiod_set_value_cansleep (reset_gpio,0 ); -mdelay (100 ); +mdelay (inactive_delay);/* drive it active, also inactive->active edge */ gpiod_set_value_cansleep (reset_gpio,1 );
@@ -66,6 +69,9 @@ static int gpio_poweroff_probe(struct platform_device *pdev)else flags =GPIOD_OUT_LOW ; +device_property_read_u32 (&pdev->dev,"active-delay-ms" , &active_delay); +device_property_read_u32 (&pdev->dev,"inactive-delay-ms" , + &inactive_delay);device_property_read_u32 (&pdev->dev,"timeout-ms" , &timeout); reset_gpio =devm_gpiod_get (&pdev->dev,NULL , flags);
Signature · 1 line
2.18.0
Quoted 5 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
Similar to gpio-reset allow to specify active and inactive delays while keeping the 100ms defaults that were used previously all the time.
Quoted 9 lines
The dt-properties are named the same as in gpio-reset but get an "-ms" suffix as properties should contain such a suffix specifying its unit.
Signed-off-by Heiko Stuebner <[email protected]>--- .../devicetree/bindings/power/reset/gpio-poweroff.txt | 2 ++ drivers/power/reset/gpio-poweroff.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)
Moritz Fischer
Reviewed-byQuoted 10 lines · Rob Herring
Quoted 8 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
Similar to gpio-reset allow to specify active and inactive delays while keeping the 100ms defaults that were used previously all the time.
The dt-properties are named the same as in gpio-reset but get an "-ms" suffix as properties should contain such a suffix specifying its unit.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Heiko Stuebner <[email protected]>--- .../devicetree/bindings/power/reset/gpio-poweroff.txt | 2 ++ drivers/power/reset/gpio-poweroff.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)Reviewed-by Rob Herring <[email protected]>
Hi,
Quoted 10 lines · Heiko Stuebner
From: Heiko Stuebner <[email protected]>
Similar to gpio-reset allow to specify active and inactive delays while keeping the 100ms defaults that were used previously all the time.
The dt-properties are named the same as in gpio-reset but get an "-ms" suffix as properties should contain such a suffix specifying its unit.
Signed-off-by Heiko Stuebner <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 57 lines
.../devicetree/bindings/power/reset/gpio-poweroff.txt | 2 ++ drivers/power/reset/gpio-poweroff.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt +2
-0@@ -27,6 +27,8 @@ Optional properties: it to an output when the power-off handler is called. If this optional property is not specified, the GPIO is initialized as an output in its inactive state. +- active-delay-ms: Delay (default 100) to wait after driving gpio active +- inactive-delay-ms: Delay (default 100) to wait after driving gpio inactive - timeout-ms: Time to wait before asserting a WARN_ON(1). If nothing is specified, 3000 ms is used.drivers/power/reset/gpio-poweroff.c +8
-2@@ -26,6 +26,8 @@*/ static struct gpio_desc *reset_gpio;static u32 timeout =DEFAULT_TIMEOUT_MS ; +static u32 active_delay =100 ; +static u32 inactive_delay =100 ;static void gpio_poweroff_do_poweroff (void ) {@@ -33,10 +35,11 @@ static void gpio_poweroff_do_poweroff(void)/* drive it active, also inactive->active edge */ gpiod_direction_output (reset_gpio,1 ); -mdelay (100 ); +mdelay (active_delay); +/* drive inactive, also active->inactive edge */ gpiod_set_value_cansleep (reset_gpio,0 ); -mdelay (100 ); +mdelay (inactive_delay);/* drive it active, also inactive->active edge */ gpiod_set_value_cansleep (reset_gpio,1 );@@ -66,6 +69,9 @@ static int gpio_poweroff_probe(struct platform_device *pdev)else flags =GPIOD_OUT_LOW ; +device_property_read_u32 (&pdev->dev,"active-delay-ms" , &active_delay); +device_property_read_u32 (&pdev->dev,"inactive-delay-ms" , + &inactive_delay);device_property_read_u32 (&pdev->dev,"timeout-ms" , &timeout); reset_gpio =devm_gpiod_get (&pdev->dev,NULL , flags);Signature · 1 line
2.18.0