Skip to contentSkip to conversation

imx-uuc: bump revision to 79e9798e

PATCH New Gary Bisson 2 participants 3 messages Nov 12, 2018 – Nov 14, 2018 Arm i.MX and Layerscape

lore
Share & tools
lore

Gary Bisson

author
#0 lore raw

PATCH 1/1 imx-uuc: bump revision to 79e9798e

Main changes:
- fix build error by gcc 8.2
- re-factor the code
- use unique CPU ID when available
- improve UDC management

Fixes:
http://autobuild.buildroot.net/results/b39d56c1573308c4f947de23363da7c05e2aaf0d/

Also switch back the repository from codeauroraforum to NXPmicro now that the Qualcomm/NXP merger was denied.

Signed-off-by Gary Bisson <[email protected]>
---
 package/freescale-imx/imx-uuc/imx-uuc.hash | 2 +-
 package/freescale-imx/imx-uuc/imx-uuc.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
package/freescale-imx/imx-uuc/imx-uuc.hash +1 -1
index c9c29f8692..623bd27644 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 1463e855d1229e6b6c02df2085f6bff5974bc061d13a61646b63675c160cba99  imx-uuc-2ae634281a39c82b6a8ee0fdcfbfbe42183ceb53.tar.gz
+sha256 ac4960b9dc53cfd09709951c4bf1f774567ff0918d0b216b480e1f7df8c6ee48  imx-uuc-79e9798eee9cd972d92ed2b18f170de856d153c9.tar.gz
package/freescale-imx/imx-uuc/imx-uuc.mk +2 -2
index 5e0bb3be0e..bdfa51b171 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-IMX_UUC_VERSION = 2ae634281a39c82b6a8ee0fdcfbfbe42183ceb53
-IMX_UUC_SITE = $(call github,codeauroraforum,imx-uuc,$(IMX_UUC_VERSION))
+IMX_UUC_VERSION = 79e9798eee9cd972d92ed2b18f170de856d153c9
+IMX_UUC_SITE = $(call github,NXPmicro,imx-uuc,$(IMX_UUC_VERSION))
 IMX_UUC_LICENSE = GPL-2.0+
 IMX_UUC_LICENSE_FILES = COPYING
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 imx-uuc: bump revision to 79e9798e

Hello Gary,

Quoted 2 lines · Gary Bisson

Main changes:
- fix build error by gcc 8.2

I know it is what the upstream commit says, but the makedev() issue has nothing to do with gcc 8.2, but with glibc 2.28. I fixed up the commit log on that aspect.

To be honest, I hesitated a bit because we normally don't take version bumps in master at this point. However, this is a fairly small and not that widely used package, the number of upstream changes is not enormous, so I applied it to master. But I really hesitated with asking for just a backport of the glibc 2.28 fix instead.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 imx-uuc: bump revision to 79e9798e

Hi Thomas,

Quoted 10 lines · Thomas Petazzoni

Hello Gary,

Quoted 2 lines · Gary Bisson

Main changes:
- fix build error by gcc 8.2

I know it is what the upstream commit says, but the makedev() issue has nothing to do with gcc 8.2, but with glibc 2.28. I fixed up the commit log on that aspect.

Thanks, I actually didn't even dig deeper once I saw that this commit was fixing the exact same error.

Quoted 5 lines

To be honest, I hesitated a bit because we normally don't take version bumps in master at this point. However, this is a fairly small and not that widely used package, the number of upstream changes is not enormous, so I applied it to master. But I really hesitated with asking for just a backport of the glibc 2.28 fix instead.

I understand, but note that there are a couple of other patches in that bump that also fix some other possible build issues (although the titles aren't very useful):
e05cc55 fix build error when gcc over 7.0
7c7562b fix build error

So really a version bump seemed like the easy route instead of backporting all those patches.
But I understand it isn't ideal at this stage of the 2018.11 release.

Regards,
Gary